Skip to content

Commit 9a7b23a

Browse files
committed
Simplified BaseTestBuilderWithComponentBuilder (#125)
1 parent 82a1c9f commit 9a7b23a

File tree

7 files changed

+11
-43
lines changed

7 files changed

+11
-43
lines changed

src/MyTested.AspNetCore.Mvc.Abstractions/Builders/Base/BaseTestBuilderWithComponent.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ protected BaseTestBuilderWithComponent(ComponentTestContext testContext)
3434

3535
private set
3636
{
37-
CommonValidator.CheckForNullReference(value.Component, nameof(value.Component));
37+
CommonValidator.CheckForNullReference(value, nameof(this.TestContext));
3838
this.testContext = value;
3939
}
4040
}

src/MyTested.AspNetCore.Mvc.Abstractions/Builders/Base/BaseTestBuilderWithComponentBuilder.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,13 @@
33
using Contracts.Base;
44
using Internal.TestContexts;
55

6-
public abstract class BaseTestBuilderWithComponentBuilder<TBuilder> : BaseTestBuilder,
6+
public abstract class BaseTestBuilderWithComponentBuilder<TBuilder> : BaseTestBuilderWithComponent,
77
IBaseTestBuilderWithComponentBuilder<TBuilder>
88
where TBuilder : IBaseTestBuilder
99
{
1010
private TBuilder builder;
1111

12-
protected BaseTestBuilderWithComponentBuilder(HttpTestContext testContext)
12+
protected BaseTestBuilderWithComponentBuilder(ComponentTestContext testContext)
1313
: base(testContext)
1414
{
1515
}

src/MyTested.AspNetCore.Mvc.Abstractions/Builders/Base/BaseTestBuilderWithComponentShouldHaveTestBuilder.cs

Lines changed: 0 additions & 32 deletions
This file was deleted.

src/MyTested.AspNetCore.Mvc.Caching/ComponentShouldHaveTestBuilderCachingExtensions.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ public static class ComponentShouldHaveTestBuilderCachingExtensions
2121
public static TBuilder NoMemoryCache<TBuilder>(this IBaseTestBuilderWithComponentShouldHaveTestBuilder<TBuilder> builder)
2222
where TBuilder : IBaseTestBuilder
2323
{
24-
var actualBuilder = (BaseTestBuilderWithComponentShouldHaveTestBuilder<TBuilder>)builder;
24+
var actualBuilder = (BaseTestBuilderWithComponentBuilder<TBuilder>)builder;
2525

2626
if (actualBuilder.TestContext.GetMockedMemoryCache().Count > 0)
2727
{
@@ -46,7 +46,7 @@ public static TBuilder MemoryCache<TBuilder>(
4646
int? withNumberOfEntries = null)
4747
where TBuilder : IBaseTestBuilder
4848
{
49-
var actualBuilder = (BaseTestBuilderWithComponentShouldHaveTestBuilder<TBuilder>)builder;
49+
var actualBuilder = (BaseTestBuilderWithComponentBuilder<TBuilder>)builder;
5050

5151
DataProviderValidator.ValidateDataProviderNumberOfEntries(
5252
actualBuilder.TestContext,
@@ -69,7 +69,7 @@ public static TBuilder MemoryCache<TBuilder>(
6969
Action<IMemoryCacheTestBuilder> memoryCacheTestBuilder)
7070
where TBuilder : IBaseTestBuilder
7171
{
72-
var actualBuilder = (BaseTestBuilderWithComponentShouldHaveTestBuilder<TBuilder>)builder;
72+
var actualBuilder = (BaseTestBuilderWithComponentBuilder<TBuilder>)builder;
7373

7474
memoryCacheTestBuilder(new MemoryCacheTestBuilder(actualBuilder.TestContext));
7575

src/MyTested.AspNetCore.Mvc.Core/Builders/Actions/ShouldHave/ShouldHaveTestBuilder.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
/// </summary>
1616
/// <typeparam name="TActionResult">Result from invoked action in ASP.NET Core MVC controller.</typeparam>
1717
public partial class ShouldHaveTestBuilder<TActionResult>
18-
: BaseTestBuilderWithComponentShouldHaveTestBuilder<IAndActionResultTestBuilder<TActionResult>>, IShouldHaveTestBuilder<TActionResult>
18+
: BaseTestBuilderWithComponentBuilder<IAndActionResultTestBuilder<TActionResult>>, IShouldHaveTestBuilder<TActionResult>
1919
{
2020
private ControllerTestContext testContext;
2121

src/MyTested.AspNetCore.Mvc.EntityFrameworkCore/ComponentShouldHaveTestBuilderEntityFrameworkCoreExtensions.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ public static TBuilder DbContext<TBuilder>(
2323
Action<IDbContextTestBuilder> dbContextTestBuilder)
2424
where TBuilder : IBaseTestBuilder
2525
{
26-
var actualBuilder = (BaseTestBuilderWithComponentShouldHaveTestBuilder<TBuilder>)builder;
26+
var actualBuilder = (BaseTestBuilderWithComponentBuilder<TBuilder>)builder;
2727

2828
dbContextTestBuilder(new DbContextTestBuilder(actualBuilder.TestContext));
2929

src/MyTested.AspNetCore.Mvc.Session/ComponentShouldHaveTestBuilderSessionExtensions.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public static class ComponentShouldHaveTestBuilderSessionExtensions
2222
public static TBuilder NoSession<TBuilder>(this IBaseTestBuilderWithComponentShouldHaveTestBuilder<TBuilder> builder)
2323
where TBuilder : IBaseTestBuilder
2424
{
25-
var actualBuilder = (BaseTestBuilderWithComponentShouldHaveTestBuilder<TBuilder>)builder;
25+
var actualBuilder = (BaseTestBuilderWithComponentBuilder<TBuilder>)builder;
2626

2727
if (actualBuilder.TestContext.Session.Keys.Any())
2828
{
@@ -47,7 +47,7 @@ public static TBuilder Session<TBuilder>(
4747
int? withNumberOfEntries = null)
4848
where TBuilder : IBaseTestBuilder
4949
{
50-
var actualBuilder = (BaseTestBuilderWithComponentShouldHaveTestBuilder<TBuilder>)builder;
50+
var actualBuilder = (BaseTestBuilderWithComponentBuilder<TBuilder>)builder;
5151

5252
DataProviderValidator.ValidateDataProviderNumberOfEntries(
5353
actualBuilder.TestContext,
@@ -70,7 +70,7 @@ public static TBuilder Session<TBuilder>(
7070
Action<ISessionTestBuilder> sessionTestBuilder)
7171
where TBuilder : IBaseTestBuilder
7272
{
73-
var actualBuilder = (BaseTestBuilderWithComponentShouldHaveTestBuilder<TBuilder>)builder;
73+
var actualBuilder = (BaseTestBuilderWithComponentBuilder<TBuilder>)builder;
7474

7575
sessionTestBuilder(new SessionTestBuilder(actualBuilder.TestContext));
7676

0 commit comments

Comments
 (0)