Implemented part of the pipeline (.Which) functionality (#282)

ivaylokenov · ivaylokenov · commit a3580a40f965 · 2019-08-30T18:56:50.000+03:00
diff --git a/src/MyTested.AspNetCore.Mvc.Abstractions/Utilities/Validators/CommonValidator.cs b/src/MyTested.AspNetCore.Mvc.Abstractions/Utilities/Validators/CommonValidator.cs
@@ -52,29 +52,25 @@ public static void CheckForEqualityWithDefaultValue<T>(T value, string errorMess
                 throw new InvalidOperationException(errorMessage);
             }
         }
-        
+
         /// <summary>
         /// Validates that two objects are equal using the Equals method.
         /// </summary>
         /// <typeparam name="T">Type of the objects.</typeparam>
         /// <param name="expected">Expected object.</param>
         /// <param name="actual">Actual object.</param>
         /// <returns>True or false.</returns>
-        public static bool CheckEquality<T>(T expected, T actual)
-        {
-            return expected.Equals(actual);
-        }
+        public static bool CheckEquality<T>(T expected, T actual) 
+            => expected.Equals(actual);
 
         /// <summary>
         /// Validates whether object equals the default value for its type.
         /// </summary>
         /// <typeparam name="TValue">Type of the value.</typeparam>
         /// <param name="value">Object to test.</param>
         /// <returns>True or false.</returns>
-        public static bool CheckForDefaultValue<TValue>(TValue value)
-        {
-            return EqualityComparer<TValue>.Default.Equals(value, default(TValue));
-        }
+        public static bool CheckForDefaultValue<TValue>(TValue value) 
+            => EqualityComparer<TValue>.Default.Equals(value, default);
 
         /// <summary>
         /// Validates whether type can be null.
@@ -89,11 +85,9 @@ public static void CheckIfTypeCanBeNull(Type type)
             }
         }
 
-        private static string FormatExceptionMessage(string message)
-        {
-            return string.IsNullOrWhiteSpace(message)
+        private static string FormatExceptionMessage(string message) 
+            => string.IsNullOrWhiteSpace(message)
                  ? string.Empty
                  : $" with '{message}' message";
-        }
     }
 }
diff --git a/src/MyTested.AspNetCore.Mvc.Controllers/Builders/Actions/ShouldReturn/ShouldReturnAccepted.cs b/src/MyTested.AspNetCore.Mvc.Controllers/Builders/Actions/ShouldReturn/ShouldReturnAccepted.cs
@@ -18,12 +18,12 @@ public partial class ShouldReturnTestBuilder<TActionResult>
         /// <inheritdoc />
         public IAndTestBuilder Accepted(Action<IAcceptedTestBuilder> acceptedTestBuilder)
         {
-            if (this.ActionResult is AcceptedAtActionResult)
+            if (this.ObjectActionResult is AcceptedAtActionResult)
             {
                 return this.ValidateAcceptedResult<AcceptedAtActionResult>(acceptedTestBuilder);
             }
 
-            if (this.ActionResult is AcceptedAtRouteResult)
+            if (this.ObjectActionResult is AcceptedAtRouteResult)
             {
                 return this.ValidateAcceptedResult<AcceptedAtRouteResult>(acceptedTestBuilder);
             }
diff --git a/src/MyTested.AspNetCore.Mvc.Controllers/Builders/Actions/ShouldReturn/ShouldReturnBadRequest.cs b/src/MyTested.AspNetCore.Mvc.Controllers/Builders/Actions/ShouldReturn/ShouldReturnBadRequest.cs
@@ -17,7 +17,7 @@ public partial class ShouldReturnTestBuilder<TActionResult>
         /// <inheritdoc />
         public IAndTestBuilder BadRequest(Action<IBadRequestTestBuilder> badRequestTestBuilder)
         {
-            if (this.ActionResult is BadRequestObjectResult)
+            if (this.ObjectActionResult is BadRequestObjectResult)
             {
                 return this.ValidateBadRequestResult<BadRequestObjectResult>(badRequestTestBuilder);
             }
diff --git a/src/MyTested.AspNetCore.Mvc.Controllers/Builders/Actions/ShouldReturn/ShouldReturnConflict.cs b/src/MyTested.AspNetCore.Mvc.Controllers/Builders/Actions/ShouldReturn/ShouldReturnConflict.cs
@@ -17,7 +17,7 @@ public partial class ShouldReturnTestBuilder<TActionResult>
         /// <inheritdoc />
         public IAndTestBuilder Conflict(Action<IConflictTestBuilder> conflictTestBuilder)
         {
-            if (this.ActionResult is ConflictObjectResult)
+            if (this.ObjectActionResult is ConflictObjectResult)
             {
                 return this.ValidateConflictResult<ConflictObjectResult>(conflictTestBuilder);
             }
diff --git a/src/MyTested.AspNetCore.Mvc.Controllers/Builders/Actions/ShouldReturn/ShouldReturnCreated.cs b/src/MyTested.AspNetCore.Mvc.Controllers/Builders/Actions/ShouldReturn/ShouldReturnCreated.cs
@@ -18,12 +18,12 @@ public partial class ShouldReturnTestBuilder<TActionResult>
         /// <inheritdoc />
         public IAndTestBuilder Created(Action<ICreatedTestBuilder> createdTestBuilder)
         {
-            if (this.ActionResult is CreatedAtActionResult)
+            if (this.ObjectActionResult is CreatedAtActionResult)
             {
                 return this.ValidateCreatedResult<CreatedAtActionResult>(createdTestBuilder);
             }
 
-            if (this.ActionResult is CreatedAtRouteResult)
+            if (this.ObjectActionResult is CreatedAtRouteResult)
             {
                 return this.ValidateCreatedResult<CreatedAtRouteResult>(createdTestBuilder);
             }
diff --git a/src/MyTested.AspNetCore.Mvc.Controllers/Builders/Actions/ShouldReturn/ShouldReturnFile.cs b/src/MyTested.AspNetCore.Mvc.Controllers/Builders/Actions/ShouldReturn/ShouldReturnFile.cs
@@ -18,12 +18,12 @@ public partial class ShouldReturnTestBuilder<TActionResult>
         /// <inheritdoc />
         public IAndTestBuilder File(Action<IFileTestBuilder> fileTestBuilder)
         {
-            if (this.ActionResult is VirtualFileResult)
+            if (this.ObjectActionResult is VirtualFileResult)
             {
                 return this.ValidateFileResult<VirtualFileResult>(fileTestBuilder);
             }
 
-            if (this.ActionResult is FileStreamResult)
+            if (this.ObjectActionResult is FileStreamResult)
             {
                 return this.ValidateFileResult<FileStreamResult>(fileTestBuilder);
             }
diff --git a/src/MyTested.AspNetCore.Mvc.Controllers/Builders/Actions/ShouldReturn/ShouldReturnNotFound.cs b/src/MyTested.AspNetCore.Mvc.Controllers/Builders/Actions/ShouldReturn/ShouldReturnNotFound.cs
@@ -17,7 +17,7 @@ public partial class ShouldReturnTestBuilder<TActionResult>
         /// <inheritdoc />
         public IAndTestBuilder NotFound(Action<INotFoundTestBuilder> notFoundTestBuilder)
         {
-            if (this.ActionResult is NotFoundObjectResult)
+            if (this.ObjectActionResult is NotFoundObjectResult)
             {
                 return this.ValidateNotFoundResult<NotFoundObjectResult>(notFoundTestBuilder);
             }
diff --git a/src/MyTested.AspNetCore.Mvc.Controllers/Builders/Actions/ShouldReturn/ShouldReturnNullOrDefault.cs b/src/MyTested.AspNetCore.Mvc.Controllers/Builders/Actions/ShouldReturn/ShouldReturnNullOrDefault.cs
@@ -53,18 +53,14 @@ public IAndTestBuilder NotNull()
             return new AndTestBuilder(this.TestContext);
         }
 
-        private bool CheckValidDefaultValue()
-        {
-            return CommonValidator.CheckForDefaultValue(this.ActionResult) && this.CaughtException == null;
-        }
+        private bool CheckValidDefaultValue() 
+            => CommonValidator.CheckForDefaultValue(this.ActionResult) && this.CaughtException == null;
 
-        private void ThrowNewActionResultAssertionException(string message)
-        {
-            throw new InvocationResultAssertionException(string.Format(
+        private void ThrowNewActionResultAssertionException(string message) 
+            => throw new InvocationResultAssertionException(string.Format(
                 "When calling {0} action in {1} expected action result to be {2}",
                 this.ActionName,
                 this.Controller.GetName(),
                 message));
-        }
     }
 }
diff --git a/src/MyTested.AspNetCore.Mvc.Controllers/Builders/Actions/ShouldReturn/ShouldReturnOk.cs b/src/MyTested.AspNetCore.Mvc.Controllers/Builders/Actions/ShouldReturn/ShouldReturnOk.cs
@@ -17,7 +17,7 @@ public partial class ShouldReturnTestBuilder<TActionResult>
         /// <inheritdoc />
         public IAndTestBuilder Ok(Action<IOkTestBuilder> okTestBuilder)
         {
-            if (this.ActionResult is OkObjectResult)
+            if (this.ObjectActionResult is OkObjectResult)
             {
                 return this.ValidateOkResult<OkObjectResult>(okTestBuilder);
             }
diff --git a/src/MyTested.AspNetCore.Mvc.Controllers/Builders/Actions/ShouldReturn/ShouldReturnRedirect.cs b/src/MyTested.AspNetCore.Mvc.Controllers/Builders/Actions/ShouldReturn/ShouldReturnRedirect.cs
@@ -18,12 +18,12 @@ public partial class ShouldReturnTestBuilder<TActionResult>
         /// <inheritdoc />
         public IAndTestBuilder Redirect(Action<IRedirectTestBuilder> redirectTestBuilder)
         {
-            if (this.ActionResult is RedirectToRouteResult)
+            if (this.ObjectActionResult is RedirectToRouteResult)
             {
                 return this.ValidateRedirectResult<RedirectToRouteResult>(redirectTestBuilder);
             }
 
-            if (this.ActionResult is RedirectToActionResult)
+            if (this.ObjectActionResult is RedirectToActionResult)
             {
                 return this.ValidateRedirectResult<RedirectToActionResult>(redirectTestBuilder);
             }
diff --git a/src/MyTested.AspNetCore.Mvc.Controllers/Builders/Actions/ShouldReturn/ShouldReturnStatusCode.cs b/src/MyTested.AspNetCore.Mvc.Controllers/Builders/Actions/ShouldReturn/ShouldReturnStatusCode.cs
@@ -30,7 +30,7 @@ public IAndTestBuilder StatusCode(Action<IStatusCodeTestBuilder> statusCodeTestB
 
         private IAndStatusCodeTestBuilder GetStatusCodeTestBuilder()
         {
-            if (this.ActionResult is StatusCodeResult)
+            if (this.ObjectActionResult is StatusCodeResult)
             {
                 InvocationResultValidator.ValidateInvocationResultType<StatusCodeResult>(this.TestContext);
                 return new StatusCodeTestBuilder<StatusCodeResult>(this.TestContext);
diff --git a/src/MyTested.AspNetCore.Mvc.Controllers/Builders/Actions/ShouldReturn/ShouldReturnUnauthorized.cs b/src/MyTested.AspNetCore.Mvc.Controllers/Builders/Actions/ShouldReturn/ShouldReturnUnauthorized.cs
@@ -18,7 +18,7 @@ public partial class ShouldReturnTestBuilder<TActionResult>
         /// <inheritdoc />	
         public IAndTestBuilder Unauthorized(Action<IUnauthorizedTestBuilder> unauthorizedTestBuilder)
         {
-            if (this.ActionResult is UnauthorizedObjectResult)
+            if (this.ObjectActionResult is UnauthorizedObjectResult)
             {
                 return this.ValidateUnauthorizedResult<UnauthorizedObjectResult>(unauthorizedTestBuilder);
             }
diff --git a/src/MyTested.AspNetCore.Mvc.Controllers/Builders/Actions/ShouldReturn/ShouldReturnUnprocessableEntity.cs b/src/MyTested.AspNetCore.Mvc.Controllers/Builders/Actions/ShouldReturn/ShouldReturnUnprocessableEntity.cs
@@ -20,7 +20,7 @@ public partial class ShouldReturnTestBuilder<TActionResult>
         /// <inheritdoc />
         public IAndTestBuilder UnprocessableEntity(Action<IUnprocessableEntityTestBuilder> unprocessableEntityTestBuilder)
         {
-            if (this.ActionResult is UnprocessableEntityObjectResult)
+            if (this.ObjectActionResult is UnprocessableEntityObjectResult)
             {
                 return this.ValidateUnprocessableEntityResult<UnprocessableEntityObjectResult>(unprocessableEntityTestBuilder);
             }
diff --git a/src/MyTested.AspNetCore.Mvc.Controllers/Builders/Base/BaseTestBuilderWithActionResult.cs b/src/MyTested.AspNetCore.Mvc.Controllers/Builders/Base/BaseTestBuilderWithActionResult.cs
@@ -28,6 +28,12 @@ protected BaseTestBuilderWithActionResult(ControllerTestContext testContext)
         /// <value>Action result to be tested.</value>
         public TActionResult ActionResult => this.TestContext.MethodResultAs<TActionResult>();
 
+        /// <summary>
+        /// Gets the action result which will be tested as object.
+        /// </summary>
+        /// <value>Action result to be tested as object.</value>
+        protected object ObjectActionResult => this.TestContext.MethodResult;
+
         /// <inheritdoc />
         public IAndTestBuilder Passing(Action<TActionResult> assertions)
             => this.Passing<TActionResult>(assertions);
diff --git a/src/MyTested.AspNetCore.Mvc.Pipeline/Builders/Pipeline/WhichControllerInstanceBuilder.cs b/src/MyTested.AspNetCore.Mvc.Pipeline/Builders/Pipeline/WhichControllerInstanceBuilder.cs
@@ -1,50 +1,135 @@
 ﻿namespace MyTested.AspNetCore.Mvc.Builders.Pipeline
 {
+    using System;
+    using System.Linq;
+    using System.Linq.Expressions;
+    using System.Reflection;
+    using System.Threading.Tasks;
+    using Builders.Actions;
     using Builders.Contracts.Actions;
     using Builders.Contracts.Base;
     using Builders.Contracts.CaughtExceptions;
     using Builders.Contracts.Pipeline;
     using Builders.Controllers;
     using Internal.Results;
     using Internal.TestContexts;
+    using Utilities;
 
     public class WhichControllerInstanceBuilder<TController>
         : BaseControllerBuilder<TController, IAndWhichControllerInstanceBuilder<TController>>,
         IAndWhichControllerInstanceBuilder<TController>
         where TController : class
     {
-        public WhichControllerInstanceBuilder(ControllerTestContext testContext) 
+        public WhichControllerInstanceBuilder(ControllerTestContext testContext)
             : base(testContext)
         {
         }
 
         /// <inheritdoc />
         public IShouldHaveTestBuilder<MethodResult> ShouldHave()
         {
-            throw new System.NotImplementedException();
+            this.InvokeAction();
+
+            var actionResultTestBuilder = new ActionResultTestBuilder<MethodResult>(this.TestContext);
+
+            return actionResultTestBuilder.ShouldHave();
         }
 
         /// <inheritdoc />
         public IShouldReturnTestBuilder<MethodResult> ShouldReturn()
         {
-            throw new System.NotImplementedException();
+            this.InvokeAction();
+
+            var actionResultTestBuilder = new ActionResultTestBuilder<MethodResult>(this.TestContext);
+
+            return actionResultTestBuilder.ShouldReturn();
         }
 
         /// <inheritdoc />
         public IBaseTestBuilderWithInvokedAction ShouldReturnEmpty()
         {
-            throw new System.NotImplementedException();
+            this.InvokeAction();
+
+            var actionResultTestBuilder = new VoidActionResultTestBuilder(this.TestContext);
+
+            return actionResultTestBuilder.ShouldReturnEmpty();
         }
 
         /// <inheritdoc />
         public IShouldThrowTestBuilder ShouldThrow()
         {
-            throw new System.NotImplementedException();
+            this.InvokeAction();
+
+            var actionResultTestBuilder = new VoidActionResultTestBuilder(this.TestContext);
+
+            return actionResultTestBuilder.ShouldThrow();
         }
 
         /// <inheritdoc />
         public IWhichControllerInstanceBuilder<TController> AndAlso() => this;
 
         protected override IAndWhichControllerInstanceBuilder<TController> SetBuilder() => this;
+
+        private void InvokeAction()
+        {
+            var methodCall = this.TestContext.MethodCall;
+            var methodInfo = ExpressionParser.GetMethodInfo(methodCall);
+
+            if (methodInfo.ReturnType == typeof(void))
+            {
+                var actionCall = Expression.Lambda<Action<TController>>(
+                    methodCall.Body,
+                    methodCall.Parameters);
+
+                this.Invoke(actionCall);
+            }
+            else if (methodInfo.ReturnType == typeof(Task))
+            {
+                var actionCall = Expression.Lambda<Func<TController, Task>>(
+                    methodCall.Body,
+                    methodCall.Parameters);
+
+                this.Invoke(actionCall);
+            }
+            else
+            {
+                var methodName = nameof(this.CallInvoke);
+                var returnType = methodInfo.ReturnType;
+
+                if (returnType.IsGenericType && returnType.GetGenericTypeDefinition() == typeof(Task<>))
+                {
+                    methodName = nameof(this.CallTaskInvoke);
+                    returnType = returnType.GetGenericArguments().First();
+                }
+
+                var invokeActionOpenGeneric = this.GetType().GetMethod(
+                    methodName,
+                    BindingFlags.Instance | BindingFlags.NonPublic);
+
+                var invokeActionClosedGeneric = invokeActionOpenGeneric.MakeGenericMethod(returnType);
+
+                invokeActionClosedGeneric.Invoke(this, new[] { methodCall });
+            }
+        }
+
+        // Called via reflection.
+        private void CallInvoke<TActionResult>(LambdaExpression methodCall)
+        {
+            var actionCall = Expression.Lambda<Func<TController, TActionResult>>(
+                methodCall.Body,
+                methodCall.Parameters);
+
+            this.Invoke(actionCall);
+        }
+
+        // Called via reflection.
+        private void CallTaskInvoke<TActionResult>(LambdaExpression methodCall)
+        {
+            var actionCall = Expression.Lambda<Func<TController, Task<TActionResult>>>(
+                methodCall.Body,
+                methodCall.Parameters);
+
+            this.Invoke(actionCall);
+        }
     }
 }
diff --git a/src/MyTested.AspNetCore.Mvc.Pipeline/ControllerRouteTestBuilderPipelineExtensions.cs b/src/MyTested.AspNetCore.Mvc.Pipeline/ControllerRouteTestBuilderPipelineExtensions.cs
@@ -7,6 +7,7 @@
     using Builders.Contracts.Routing;
     using Builders.Pipeline;
     using Builders.Routing;
+    using Internal.Results;
     using Internal.TestContexts;
 
     /// <summary>
@@ -30,6 +31,7 @@ public static IWhichControllerInstanceBuilder<TController> Which<TController>(
 
             return new WhichControllerInstanceBuilder<TController>(new ControllerTestContext
             {
+                ComponentConstructionDelegate = () => null,
                 MethodCall = actionCall
             });
         }
@@ -41,7 +43,7 @@ public static IWhichControllerInstanceBuilder<TController> Which<TController>(
         /// <param name="builder">Instance of <see cref="IControllerRouteTestBuilder{TController}"/> type.</param>
         /// <param name="controllerInstanceBuilder">Builder for creating the controller instance.</param>
         /// <returns>Test builder of <see cref="IActionResultTestBuilder{TActionResult}"/> type.</returns>
-        public static IActionResultTestBuilder<object> Which<TController>(
+        public static IActionResultTestBuilder<MethodResult> Which<TController>(
             this IControllerRouteTestBuilder<TController> builder,
             Action<IControllerInstanceBuilder<TController>> controllerInstanceBuilder)
             where TController : class
diff --git a/test/MyTested.AspNetCore.Mvc.Pipeline.Test/BuildersTests/PipelineTests/WhichControllerInstanceBuilderTests.cs b/test/MyTested.AspNetCore.Mvc.Pipeline.Test/BuildersTests/PipelineTests/WhichControllerInstanceBuilderTests.cs
diff --git a/test/MyTested.AspNetCore.Mvc.Test.Setups/Routing/HomeController.cs b/test/MyTested.AspNetCore.Mvc.Test.Setups/Routing/HomeController.cs

Original file line number	Diff line number	Diff line change
`@@ -18,12 +18,12 @@ public partial class ShouldReturnTestBuilder<TActionResult>`
`18`	`18`	`/// <inheritdoc />`
`19`	`19`	`public IAndTestBuilder Accepted(Action<IAcceptedTestBuilder> acceptedTestBuilder)`
`20`	`20`	`{`
`21`		`- if (this.ActionResult is AcceptedAtActionResult)`
	`21`	`+ if (this.ObjectActionResult is AcceptedAtActionResult)`
`22`	`22`	`{`
`23`	`23`	`return this.ValidateAcceptedResult<AcceptedAtActionResult>(acceptedTestBuilder);`
`24`	`24`	`}`
`25`	`25`
`26`		`- if (this.ActionResult is AcceptedAtRouteResult)`
	`26`	`+ if (this.ObjectActionResult is AcceptedAtRouteResult)`
`27`	`27`	`{`
`28`	`28`	`return this.ValidateAcceptedResult<AcceptedAtRouteResult>(acceptedTestBuilder);`
`29`	`29`	`}`
Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ public partial class ShouldReturnTestBuilder<TActionResult>`
`17`	`17`	`/// <inheritdoc />`
`18`	`18`	`public IAndTestBuilder BadRequest(Action<IBadRequestTestBuilder> badRequestTestBuilder)`
`19`	`19`	`{`
`20`		`- if (this.ActionResult is BadRequestObjectResult)`
	`20`	`+ if (this.ObjectActionResult is BadRequestObjectResult)`
`21`	`21`	`{`
`22`	`22`	`return this.ValidateBadRequestResult<BadRequestObjectResult>(badRequestTestBuilder);`
`23`	`23`	`}`