Skip to content

Commit eb8376b

Browse files
committed
FB's review
FB's review
1 parent 36801db commit eb8376b

File tree

9 files changed

+14
-88
lines changed

9 files changed

+14
-88
lines changed

doc/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ DOCNAME = MANGO
77
DOCVERSION = 0.1
88

99
# Publication date, ISO format; update manually for "releases"
10-
DOCDATE = 2025-05-27
10+
DOCDATE = 2025-06-02
1111

1212
# What is it you're writing: NOTE, WD, PR, REC, PEN, or EN
1313
DOCTYPE = PR

doc/ivoatexmeta.tex

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
% GENERATED FILE -- edit this in the Makefile
22
\newcommand{\ivoaDocversion}{0.1}
3-
\newcommand{\ivoaDocdate}{2025-05-27}
4-
\newcommand{\ivoaDocdatecode}{20250527}
3+
\newcommand{\ivoaDocdate}{2025-06-02}
4+
\newcommand{\ivoaDocdatecode}{20250602}
55
\newcommand{\ivoaDoctype}{PR}
66
\newcommand{\ivoaDocname}{MANGO}
77
\renewcommand{\ivoaBaseURL}{https://www.ivoa.net/documents/MANGO}

doc/model.tex

Lines changed: 2 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -181,24 +181,8 @@ \section{Model: mango }
181181
\end{figure}
182182

183183

184-
185-
\begin{figure}[h]
186-
\includegraphics[width=1.0\textwidth]{../model/EpochPosition.png}
187-
\caption{Class EpochPosition}
188-
\label{fig:EpochPosition}
189-
\end{figure}
190-
191-
192-
193-
\begin{figure}[h]
194-
\includegraphics[width=1.0\textwidth]{../model/EpochPosition.png}
195-
\caption{Class EpochPosition}
196-
\label{fig:EpochPosition}
197-
\end{figure}
198-
199-
200184
\label{sect:EpochPosition}
201-
This class (fig \ref{fig:EpochPosition}) is a flattened view of objects/concepts from the Astronomical Measurements Model \citep{2022ivoa.specQ1004R} that have been put together to form a consistent description of the position of an object moving over time. It consists of a celestial position, a proper motion, a radial velocity and a parallax and their associated errors encapsulated into the \texttt{EpochPositionErrors} class. The values of these properties are pulled from the underlying Astronomical Coordinates and Coordinate Systems model \citep{2022ivoa.spec.1004R} At a high level the properties map as follows: \begin{itemize} \item celestial position -> \texttt{meas:Position} \item proper motion -> \texttt{meas:ProperMotion} \item radial velocity -> \texttt{meas.Velocity} \item parallax -> no suitable counterpart at this time \end{itemize} All components use the same coordinate systems for both time and space coordinates. \begin{itemize} \item Both position and proper motion reuse \texttt{coords:LonLatPoint} elements. \item The space coordinate system is imported from \texttt{coords:spaceSys}. \item The time coordinate system is imported from \texttt{coords:timeSys}. \end{itemize} All components have their own units which must be consistent with each other. This consistency is not enforced by the model. Possible correlations between \texttt{EpochPosition} parameters are handled by the \texttt{EpochPositionCorrelations} class. Errors along the different axes are grouped in the \texttt{EpochPositionErrors} class. In some cases the errors might conflict with the correlations: \begin{itemize} \item \texttt{Ellipse} errors on position or proper motion must not be used together with the \texttt{longitudeLatitude} (or \texttt{pmLongitudePmLatitude}) correlation fields. In fact, using elliptical errors implies a correlation between the two spatial axes which must not conflict with the correlations defined in \texttt{EpochPositionCorrelations}. \end{itemize}
185+
This class (fig \ref{fig:EpochPosition}) is a flattened view of objects/concepts from the Astronomical Measurements Model \citep{2022ivoa.specQ1004R} that have been put together to form a consistent description of the position of an object moving over time. It consists of a celestial position, a proper motion, a radial velocity and a parallax and their associated errors encapsulated into the \texttt{EpochPositionErrors} class. The values of these properties are pulled from the underlying Astronomical Coordinates and Coordinate Systems model \citep{2022ivoa.spec.1004R} At a high level the properties map as follows: \begin{itemize} \item celestial position -> \texttt{meas:Position} \item proper motion -> \texttt{meas:ProperMotion} \item radial velocity -> \texttt{meas.Velocity} \item parallax -> no suitable counterpart at this time \end{itemize} All components use the same coordinate systems for both time and space coordinates. \begin{itemize} \item Both position and proper motion reuse \texttt{coords:LonLatPoint} elements. \item The space coordinate system is imported from \texttt{coords:spaceSys}. \item The time coordinate system is imported from \texttt{coords:simeSys}. \end{itemize} It is recommended to use the \texttt{ObsDate} field to store the epoch of the observation instead of the \texttt{epoch} field of \texttt{coords:spaceSys}. There are 2 reasons for this: \begin{itemize} \item Using the epoch of \texttt{coords:spaceSys} requires to work with the \texttt{coords:CustomRefLocation} class to carry the reference location. This class does not support the standard reference locations such as e.g. BARYCENTER. \item the observation date can be read in a column and therefore change with each data row. I this case, it cannot be stored as an element of the space coordinate system but as an \texttt{EPochPosition} attribute. \end{itemize} All components have their own units which must be consistent with each other. This consistency is not enforced by the model. Possible correlations between \texttt{EpochPosition} parameters are handled by the \texttt{EpochPositionCorrelations} class. Errors along the different axes are grouped in the \texttt{EpochPositionErrors} class. In some cases the errors might conflict with the correlations: \begin{itemize} \item \texttt{Ellipse} errors on position or proper motion must not be used together with the \texttt{longitudeLatitude} (or \texttt{pmLongitudePmLatitude}) correlation fields. In fact, using elliptical errors implies a correlation between the two spatial axes which must not conflict with the correlations defined in \texttt{EpochPositionCorrelations}. \end{itemize}
202186

203187
\subsubsection{EpochPosition.longitude}
204188
\textbf{vodml-id: EpochPosition.longitude} \newline
@@ -240,7 +224,7 @@ \section{Model: mango }
240224
\textbf{vodml-id: EpochPosition.obsDate} \newline
241225
\textbf{type: \hyperref[sect:DateTime]{mango:DateTime}} \newline
242226
\textbf{multiplicity: 0..1} \newline
243-
Observation date expressed within the common time system if present. This attribute, if set, supersedes the epoch possibly given with the spatial coordinate system.
227+
Observation date expressed within the common time system if present. This attribute, if set, supersedes the epoch possibly given with the spatial coordinate system(see the above).
244228

245229
\subsubsection{EpochPosition.pmCosLat\_applied}
246230
\textbf{vodml-id: EpochPosition.pmCosLat\_applied} \newline
@@ -578,20 +562,6 @@ \section{Package: error }
578562
\end{figure}
579563

580564

581-
\begin{figure}[h]
582-
\includegraphics[width=1.0\textwidth]{../model/error.png}
583-
\caption{package error}
584-
\label{fig:error}
585-
\end{figure}
586-
587-
588-
\begin{figure}[h]
589-
\includegraphics[width=1.0\textwidth]{../model/error.png}
590-
\caption{package error}
591-
\label{fig:error}
592-
\end{figure}
593-
594-
595565

596566
% INSERT FIGURE HERE
597567
%\begin{figure}[h]
@@ -692,20 +662,6 @@ \section{Package: origin }
692662
\end{figure}
693663

694664

695-
\begin{figure}[h]
696-
\includegraphics[width=1.0\textwidth]{../model/origin.png}
697-
\caption{package origin}
698-
\label{fig:origin}
699-
\end{figure}
700-
701-
702-
\begin{figure}[h]
703-
\includegraphics[width=1.0\textwidth]{../model/origin.png}
704-
\caption{package origin}
705-
\label{fig:origin}
706-
\end{figure}
707-
708-
709665

710666
% INSERT FIGURE HERE
711667
%\begin{figure}[h]

doc/model_toc.tex

Lines changed: 2 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -110,23 +110,13 @@ \section{Epoch Position Properties}
110110
in order to facilitate the annotation process and the job of the clients
111111
that have to interpret them.
112112
\subsection{EpochPosition}
113-
\begin{figure}[h]
114-
\includegraphics[width=1.0\textwidth]{../model/EpochPosition.png}
115-
\caption{Class EpochPosition}
116-
\label{fig:EpochPosition}
117-
\end{figure}
118-
\begin{figure}[h]
119-
\includegraphics[width=1.0\textwidth]{../model/EpochPosition.png}
120-
\caption{Class EpochPosition}
121-
\label{fig:EpochPosition}
122-
\end{figure}
123113
\begin{figure}[h]
124114
\includegraphics[width=1.0\textwidth]{../model/EpochPosition.png}
125115
\caption{Class EpochPosition}
126116
\label{fig:EpochPosition}
127117
\end{figure}
128118
\label{sect:EpochPosition}
129-
This class (fig \ref{fig:EpochPosition}) is a flattened view of objects/concepts from the Astronomical Measurements Model \citep{2022ivoa.specQ1004R} that have been put together to form a consistent description of the position of an object moving over time. It consists of a celestial position, a proper motion, a radial velocity and a parallax and their associated errors encapsulated into the \texttt{EpochPositionErrors} class. The values of these properties are pulled from the underlying Astronomical Coordinates and Coordinate Systems model \citep{2022ivoa.spec.1004R} At a high level the properties map as follows: \begin{itemize} \item celestial position -> \texttt{meas:Position} \item proper motion -> \texttt{meas:ProperMotion} \item radial velocity -> \texttt{meas.Velocity} \item parallax -> no suitable counterpart at this time \end{itemize} All components use the same coordinate systems for both time and space coordinates. \begin{itemize} \item Both position and proper motion reuse \texttt{coords:LonLatPoint} elements. \item The space coordinate system is imported from \texttt{coords:spaceSys}. \item The time coordinate system is imported from \texttt{coords:timeSys}. \end{itemize} All components have their own units which must be consistent with each other. This consistency is not enforced by the model. Possible correlations between \texttt{EpochPosition} parameters are handled by the \texttt{EpochPositionCorrelations} class. Errors along the different axes are grouped in the \texttt{EpochPositionErrors} class. In some cases the errors might conflict with the correlations: \begin{itemize} \item \texttt{Ellipse} errors on position or proper motion must not be used together with the \texttt{longitudeLatitude} (or \texttt{pmLongitudePmLatitude}) correlation fields. In fact, using elliptical errors implies a correlation between the two spatial axes which must not conflict with the correlations defined in \texttt{EpochPositionCorrelations}. \end{itemize}
119+
This class (fig \ref{fig:EpochPosition}) is a flattened view of objects/concepts from the Astronomical Measurements Model \citep{2022ivoa.specQ1004R} that have been put together to form a consistent description of the position of an object moving over time. It consists of a celestial position, a proper motion, a radial velocity and a parallax and their associated errors encapsulated into the \texttt{EpochPositionErrors} class. The values of these properties are pulled from the underlying Astronomical Coordinates and Coordinate Systems model \citep{2022ivoa.spec.1004R} At a high level the properties map as follows: \begin{itemize} \item celestial position -> \texttt{meas:Position} \item proper motion -> \texttt{meas:ProperMotion} \item radial velocity -> \texttt{meas.Velocity} \item parallax -> no suitable counterpart at this time \end{itemize} All components use the same coordinate systems for both time and space coordinates. \begin{itemize} \item Both position and proper motion reuse \texttt{coords:LonLatPoint} elements. \item The space coordinate system is imported from \texttt{coords:spaceSys}. \item The time coordinate system is imported from \texttt{coords:simeSys}. \end{itemize} It is recommended to use the \texttt{ObsDate} field to store the epoch of the observation instead of the \texttt{epoch} field of \texttt{coords:spaceSys}. There are 2 reasons for this: \begin{itemize} \item Using the epoch of \texttt{coords:spaceSys} requires to work with the \texttt{coords:CustomRefLocation} class to carry the reference location. This class does not support the standard reference locations such as e.g. BARYCENTER. \item the observation date can be read in a column and therefore change with each data row. I this case, it cannot be stored as an element of the space coordinate system but as an \texttt{EPochPosition} attribute. \end{itemize} All components have their own units which must be consistent with each other. This consistency is not enforced by the model. Possible correlations between \texttt{EpochPosition} parameters are handled by the \texttt{EpochPositionCorrelations} class. Errors along the different axes are grouped in the \texttt{EpochPositionErrors} class. In some cases the errors might conflict with the correlations: \begin{itemize} \item \texttt{Ellipse} errors on position or proper motion must not be used together with the \texttt{longitudeLatitude} (or \texttt{pmLongitudePmLatitude}) correlation fields. In fact, using elliptical errors implies a correlation between the two spatial axes which must not conflict with the correlations defined in \texttt{EpochPositionCorrelations}. \end{itemize}
130120

131121
\subsubsection{EpochPosition.longitude}
132122
\textbf{vodml-id: EpochPosition.longitude} \newline
@@ -168,7 +158,7 @@ \section{Epoch Position Properties}
168158
\textbf{vodml-id: EpochPosition.obsDate} \newline
169159
\textbf{type: \hyperref[sect:DateTime]{mango:DateTime}} \newline
170160
\textbf{multiplicity: 0..1} \newline
171-
Observation date expressed within the common time system if present. This attribute, if set, supersedes the epoch possibly given with the spatial coordinate system.
161+
Observation date expressed within the common time system if present. This attribute, if set, supersedes the epoch possibly given with the spatial coordinate system(see the above).
172162

173163
\subsubsection{EpochPosition.pmCosLat\_applied}
174164
\textbf{vodml-id: EpochPosition.pmCosLat\_applied} \newline
@@ -551,16 +541,6 @@ \section{Other Properties}
551541
\normalsize
552542

553543
\section{Package: error}
554-
\begin{figure}[h]
555-
\includegraphics[width=1.0\textwidth]{../model/error.png}
556-
\caption{package error}
557-
\label{fig:error}
558-
\end{figure}
559-
\begin{figure}[h]
560-
\includegraphics[width=1.0\textwidth]{../model/error.png}
561-
\caption{package error}
562-
\label{fig:error}
563-
\end{figure}
564544
\begin{figure}[h]
565545
\includegraphics[width=1.0\textwidth]{../model/error.png}
566546
\caption{package error}
@@ -649,16 +629,6 @@ \section{Package: error}
649629
Error on the second dimension (declination in case of sky coordinates)
650630

651631
\section{Package: origin}
652-
\begin{figure}[h]
653-
\includegraphics[width=1.0\textwidth]{../model/origin.png}
654-
\caption{package origin}
655-
\label{fig:origin}
656-
\end{figure}
657-
\begin{figure}[h]
658-
\includegraphics[width=1.0\textwidth]{../model/origin.png}
659-
\caption{package origin}
660-
\label{fig:origin}
661-
\end{figure}
662632
\begin{figure}[h]
663633
\includegraphics[width=1.0\textwidth]{../model/origin.png}
664634
\caption{package origin}

doc/usecases.tex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ \subsubsection{Vizier catalog archive}
172172
MANGO is not meant to replace the current management of the ViZier metadata, but rather
173173
to make those understandable/interoperable for a wide panel of VO-compliant clients.
174174

175-
\subsubsection{Client Requirements}
175+
\subsubsection{Client Use-cases}
176176
Right now, the meta-data provided within the VOTable allow client software such Aladin or Topcat to run most
177177
of the functionalities expected by the user, either for data analysis or plotting.
178178
This information is often inferred from UCDs, UTypes or column names. It can also be given by the user.

mivot/mango/mango.Brightness.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<INSTANCE dmrole="" dmtype="mango:Brightness">
22
<!-- Observed brightness of the \texttt{MangoObject}.
3-
The purpose of this property is to gather a brightness value with its error and its photometric calibration
3+
The purpose of this property is to gather a brightness value with its error and the its photometric calibration
44
The distinction between fluxes and magnitudes is made by the unit.
55
The photometric calibration is modeled by the \texttt{Phot} data model (1.1)." -->
66
<INSTANCE dmrole="mango:Property.semantics" dmtype="mango:VocabularyTerm">

mivot/mango/mango.EpochPosition.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ All components use the same coordinate systems for both time and space coordinat
2121
\begin{itemize}
2222
\item Both position and proper motion reuse \texttt{coords:LonLatPoint} elements.
2323
\item The space coordinate system is imported from \texttt{coords:spaceSys}.
24-
\item The time coordinate system is imported from \texttt{coords:timeSys}.
24+
\item The time coordinate system is imported from \texttt{coords:simeSys}.
2525
\end{itemize}
2626
2727
@@ -33,9 +33,9 @@ There are 2 reasons for this:
3333
\texttt{coords:CustomRefLocation} class to carry the reference location.
3434
This class does not support the standard reference locations such as e.g. BARYCENTER.
3535
\item the observation date can be read in a column and therefore change with each data row.
36-
In this case, it cannot be stored as an element of the space coordinate system
36+
I this case, it cannot be stored as an element of the space coordinate system
3737
but as an \texttt{EPochPosition} attribute.
38-
38+
\end{itemize}
3939
4040
All components have their own units which must be consistent with each other.
4141
This consistency is not enforced by the model.

vo-dml/desc.mango.vo-dml.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -733,7 +733,7 @@ There are 2 reasons for this:
733733
\item the observation date can be read in a column and therefore change with each data row.
734734
I this case, it cannot be stored as an element of the space coordinate system
735735
but as an \texttt{EPochPosition} attribute.
736-
736+
\end{itemize}
737737

738738
All components have their own units which must be consistent with each other.
739739
This consistency is not enforced by the model.

vo-dml/desc/desc.EpochPosition.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ There are 2 reasons for this:
3434
\item the observation date can be read in a column and therefore change with each data row.
3535
I this case, it cannot be stored as an element of the space coordinate system
3636
but as an \texttt{EPochPosition} attribute.
37-
37+
\end{itemize}
3838

3939
All components have their own units which must be consistent with each other.
4040
This consistency is not enforced by the model.

0 commit comments

Comments
 (0)