Skip to content

Commit 4267f09

Browse files
committed
fix null value for show=false columns in gatherupdates
1 parent c2d722f commit 4267f09

File tree

2 files changed

+9
-8
lines changed

2 files changed

+9
-8
lines changed

src/SvelteGenericCrudTableService.js

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -100,11 +100,13 @@ export class SvelteGenericCrudTableService {
100100
gatherUpdates(id, table) {
101101
const body = table[id];
102102
this.table_config.columns_setting.forEach((elem) => {
103-
if (this.shadowed) {
104-
body[elem.name] = document.querySelector('crud-table').shadowRoot
105-
.getElementById(this.name + elem.name + id).value;
106-
} else {
107-
body[elem.name] = document.getElementById(this.name + elem.name + id).value;
103+
if (elem.show) {
104+
if (this.shadowed) {
105+
body[elem.name] = document.querySelector('crud-table').shadowRoot
106+
.getElementById(this.name + elem.name + id).value;
107+
} else {
108+
body[elem.name] = document.getElementById(this.name + elem.name + id).value;
109+
}
108110
}
109111
})
110112
return body;
@@ -114,7 +116,6 @@ export class SvelteGenericCrudTableService {
114116
this.table_config.columns_setting.forEach((elem) => {
115117
if (elem.show) {
116118
if (this.shadowed) {
117-
console.log(this.name + elem.name + id)
118119
document.querySelector('crud-table').shadowRoot.getElementById(this.name + elem.name + id).value = table[id][elem.name]
119120
} else {
120121
document.getElementById(this.name + elem.name + id).value = table[id][elem.name];

src/SvelteGenericCrudTableService.spec.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -219,10 +219,10 @@ function runTest(shadowed) {
219219
genericCrudTable.resetRawValues(0, table);
220220

221221
if (shadowed) {
222-
expect(document.querySelector('crud-table').shadowRoot.getElementById(config.name + 'id0').value).toBe('42');
222+
expect(document.querySelector('crud-table').shadowRoot.getElementById(config.name + 'id0').value).toBe('424242');
223223
expect(document.querySelector('crud-table').shadowRoot.getElementById(config.name + 'name0').value).toBe('A_NAME');
224224
} else {
225-
expect(document.getElementById(config.name + 'id0').value).toBe('42');
225+
expect(document.getElementById(config.name + 'id0').value).toBe('424242');
226226
expect(document.getElementById(config.name + 'name0').value).toBe('A_NAME');
227227
}
228228
})

0 commit comments

Comments
 (0)