Fix for readVariable with drush 7+

PJnes · PJnes · commit fd7e93d306e7 · 2016-04-04T12:40:55.000+01:00
We were relying on a regression in Drush 6 for the output when reading variables, so bad things happen on Drush 7+.

Adding the --pipe option gives us the same output across all versions.
diff --git a/src/Drupal/Variable/VariableStorage/Drush.php b/src/Drupal/Variable/VariableStorage/Drush.php
@@ -62,7 +62,7 @@ public function writeVariable($name, $value)
      */
     public function readVariable($name, $default = null)
     {
-        $serialized = $this->execDrush("vget --format=php --exact " . escapeshellarg($name) . " 2>/dev/null");
+        $serialized = $this->execDrush("vget --format=php --exact --pipe " . escapeshellarg($name) . " 2>/dev/null");
         // Skip any SSH warnings, e.g.
         // Warning: Permanently added 'X.X.X.X' (RSA) to the list of known hosts.
         // TODO: how to improve this?

Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ public function writeVariable($name, $value)`
`62`	`62`	`*/`
`63`	`63`	`public function readVariable($name, $default = null)`
`64`	`64`	`{`
`65`		`- $serialized = $this->execDrush("vget --format=php --exact " . escapeshellarg($name) . " 2>/dev/null");`
	`65`	`+ $serialized = $this->execDrush("vget --format=php --exact --pipe " . escapeshellarg($name) . " 2>/dev/null");`
`66`	`66`	`// Skip any SSH warnings, e.g.`
`67`	`67`	`// Warning: Permanently added 'X.X.X.X' (RSA) to the list of known hosts.`
`68`	`68`	`// TODO: how to improve this?`