fix: throw error if api key doesnt exist

Author: izadoesdev

rulesets/tests/adapters.md

@@ -10,6 +10,8 @@ This document outlines all features that must be implemented and tested for each
   - Saves all metadata fields correctly
   - Handles concurrent saves
   - Returns without errors on success
+  - Overwrites existing record with same ID
+  - Preserves record integrity after save
 
 - [ ] **findByHash()** - Lookup by key hash
   - Returns correct record when exists
@@ -34,16 +36,21 @@ This document outlines all features that must be implemented and tested for each
   - Preserves unchanged fields
   - Throws error if key not found
   - Atomically updates entire metadata object
+  - Multiple updates to same key work correctly
 
 - [ ] **delete()** - Single record deletion
   - Removes record from storage
   - No error if already deleted
   - Does not affect other records
+  - Removes record from hash index (findByHash returns null after delete)
+  - Idempotent operation (multiple deletes don't error)
 
 - [ ] **deleteByOwner()** - Bulk deletion by owner
   - Deletes all keys for given owner
   - Does not delete keys from other owners
   - Returns without error when none exist
+  - Removes all hash indexes for deleted keys
+  - Idempotent operation (multiple calls don't error)
 
 ## Metadata Field Support
 
@@ -178,10 +185,14 @@ This document outlines all features that must be implemented and tested for each
 
 ### Concurrent Operations
 
-- [ ] Concurrent saves
-- [ ] Concurrent updates
-- [ ] Concurrent deletes
-- [ ] Read during write
+- [ ] Concurrent saves to different records
+- [ ] Concurrent saves to same record (last write wins)
+- [ ] Concurrent updates to different records
+- [ ] Concurrent updates to same record
+- [ ] Concurrent deletes don't conflict
+- [ ] Read during write operations
+- [ ] findByHash during concurrent saves
+- [ ] No data corruption under concurrency
 
 ### Error Handling
 
@@ -300,11 +311,11 @@ This document outlines all features that must be implemented and tested for each
 
 ## Checklist Summary
 
-Total features: **87**
-- Core Storage: 7 operations
+Total features: **97**
+- Core Storage: 7 operations (+5 sub-requirements)
 - Metadata Fields: 11 fields with various scenarios
 - Data Types: 8 type handling scenarios
-- Edge Cases: 10 edge case categories
+- Edge Cases: 10 edge case categories (+4 concurrency items)
 - Query Operations: 6 query patterns
 - Performance: 7 performance characteristics
 - Integration: 7 integration points

src/storage/memory.test.ts

@@ -135,9 +135,10 @@ describe("MemoryStore", () => {
 			expect(found?.metadata.ownerId).toBe("user_123");
 		});
 
-		it("should do nothing for non-existent ID", async () => {
-			await store.updateMetadata("non-existent", { name: "New Name" });
-			// Should not throw
+		it("should throw error for non-existent ID", async () => {
+			await expect(
+				store.updateMetadata("non-existent", { name: "New Name" })
+			).rejects.toThrow("API key with id non-existent not found");
 		});
 	});
 

src/storage/memory.ts

@@ -32,9 +32,10 @@ export class MemoryStore implements Storage {
 		metadata: Partial<ApiKeyMetadata>
 	): Promise<void> {
 		const record = await this.keys.get(id);
-		if (record) {
-			record.metadata = { ...record.metadata, ...metadata };
+		if (!record) {
+			throw new Error(`API key with id ${id} not found`);
 		}
+		record.metadata = { ...record.metadata, ...metadata };
 	}
 
 	async delete(id: string): Promise<void> {

src/storage/redis.test.ts

@@ -172,9 +172,10 @@ describe("RedisStore", () => {
 			expect(found?.metadata.ownerId).toBe("user_123");
 		});
 
-		it("should do nothing for non-existent ID", async () => {
-			await store.updateMetadata("non-existent", { name: "New Name" });
-			// Should not throw
+		it("should throw error for non-existent ID", async () => {
+			await expect(
+				store.updateMetadata("non-existent", { name: "New Name" })
+			).rejects.toThrow("API key with id non-existent not found");
 		});
 	});
 

src/storage/redis.ts

@@ -73,13 +73,15 @@ export class RedisStore implements Storage {
 		metadata: Partial<ApiKeyMetadata>
 	): Promise<void> {
 		const record = await this.findById(id);
-		if (record) {
-			record.metadata = { ...record.metadata, ...metadata };
-			await this.redis.set(this.key(id), JSON.stringify(record));
+		if (!record) {
+			throw new Error(`API key with id ${id} not found`);
+		}
 
-			if (metadata.revokedAt) {
-				await this.redis.del(this.hashKey(record.keyHash));
-			}
+		record.metadata = { ...record.metadata, ...metadata };
+		await this.redis.set(this.key(id), JSON.stringify(record));
+
+		if (metadata.revokedAt) {
+			await this.redis.del(this.hashKey(record.keyHash));
 		}
 	}