fix: bug fixes avoiding ttl being reset on each increment

Author: max-programming

src/core/cache.ts

@@ -7,6 +7,7 @@ export type Cache = {
 	/**
 	 * Atomically increments the value at key by 1 and returns the new value.
 	 * If the key doesn't exist, it's set to 1.
+	 * The TTL is reset when the key is first created, not on subsequent increments.
 	 * @param key - The cache key
 	 * @param ttl - Time to live in seconds
 	 * @returns The new value after incrementing
@@ -49,14 +50,23 @@ export class MemoryCache implements Cache {
 	incr(key: string, ttl = 60): number {
 		const item = this.cache.get(key);
 		const currentValue =
-			item && item.expires >= Date.now() ? Number.parseInt(item.value, 10) : 0;
+			item && item.expires >= Date.now()
+				? Number.parseInt(item.value, 10) || 0
+				: 0;
 		const newValue = currentValue + 1;
 
-		this.cache.set(key, {
-			value: String(newValue),
-			// biome-ignore lint/style/noMagicNumbers: 1000ms to seconds
-			expires: Date.now() + ttl * 1000,
-		});
+		if (currentValue === 0) {
+			this.cache.set(key, {
+				value: String(newValue),
+				// biome-ignore lint/style/noMagicNumbers: 1000ms to seconds
+				expires: Date.now() + ttl * 1000,
+			});
+		} else if (item) {
+			this.cache.set(key, {
+				value: String(newValue),
+				expires: item.expires,
+			});
+		}
 
 		return newValue;
 	}
@@ -90,7 +100,9 @@ export class RedisCache implements Cache {
 		// Using a Lua script ensures both operations are atomic
 		const script = `
 			local count = redis.call('INCR', KEYS[1])
-			redis.call('EXPIRE', KEYS[1], ARGV[1])
+			if count == 1 then
+				redis.call('EXPIRE', KEYS[1], ARGV[1])
+			end
 			return count
 		`;