Fix crash using echo_pillar effect on image with alpha

j-b-m · j-b-m · commit ca100ea03f26 · 2025-08-29T10:01:32.000+02:00
diff --git a/src/modules/core/filter_pillar_echo.c b/src/modules/core/filter_pillar_echo.c
@@ -271,7 +271,7 @@ static void bilinear_scale_rgba(mlt_image src, mlt_image dst, mlt_rect rect)
         desc.rect.h = rect.h * sourceAr / destAr;
         desc.rect.y = rect.y + (rect.h - desc.rect.h) / 2.0;
     }
-    if (src->format == mlt_image_rgb) {
+    if (src->format == mlt_image_rgb || src->format == mlt_image_rgba) {
         mlt_slices_run_normal(0, scale_sliced_proc_rgba32, &desc);
     } else {
         mlt_slices_run_normal(0, scale_sliced_proc_rgba64, &desc);

Original file line number	Diff line number	Diff line change
`@@ -271,7 +271,7 @@ static void bilinear_scale_rgba(mlt_image src, mlt_image dst, mlt_rect rect)`
`271`	`271`	`desc.rect.h = rect.h * sourceAr / destAr;`
`272`	`272`	`desc.rect.y = rect.y + (rect.h - desc.rect.h) / 2.0;`
`273`	`273`	`}`
`274`		`- if (src->format == mlt_image_rgb) {`
	`274`	`+ if (src->format == mlt_image_rgb \|\| src->format == mlt_image_rgba) {`
`275`	`275`	`mlt_slices_run_normal(0, scale_sliced_proc_rgba32, &desc);`
`276`	`276`	`} else {`
`277`	`277`	`mlt_slices_run_normal(0, scale_sliced_proc_rgba64, &desc);`