@jeffro256 comment

Author: j-berman

src/crypto/crypto.h

@@ -350,16 +350,7 @@ namespace crypto {
   inline bool operator<(const key_image &p1, const key_image &p2) { return memcmp(&p1, &p2, sizeof(key_image)) < 0; }
   inline bool operator>(const key_image &p1, const key_image &p2) { return p2 < p1; }
 
-  static const ec_point EC_I = {{
-      static_cast<char>(0x01), static_cast<char>(0x00), static_cast<char>(0x00), static_cast<char>(0x00),
-      static_cast<char>(0x00), static_cast<char>(0x00), static_cast<char>(0x00), static_cast<char>(0x00),
-      static_cast<char>(0x00), static_cast<char>(0x00), static_cast<char>(0x00), static_cast<char>(0x00),
-      static_cast<char>(0x00), static_cast<char>(0x00), static_cast<char>(0x00), static_cast<char>(0x00),
-      static_cast<char>(0x00), static_cast<char>(0x00), static_cast<char>(0x00), static_cast<char>(0x00),
-      static_cast<char>(0x00), static_cast<char>(0x00), static_cast<char>(0x00), static_cast<char>(0x00),
-      static_cast<char>(0x00), static_cast<char>(0x00), static_cast<char>(0x00), static_cast<char>(0x00),
-      static_cast<char>(0x00), static_cast<char>(0x00), static_cast<char>(0x00), static_cast<char>(0x00)
-    }};
+  static const ec_point EC_I = {1};
 
   static const ec_point EC_INV_EIGHT = {{
       static_cast<char>(0x79), static_cast<char>(0x2f), static_cast<char>(0xdc), static_cast<char>(0xe2),

tests/unit_tests/crypto.cpp

@@ -460,14 +460,8 @@ TEST(Crypto, fe_constants)
 
 TEST(Crypto, ec_constants_rct_parity)
 {
-  struct ec_rct_pair_t { crypto::ec_point ec; rct::key rct; };
-  const std::vector<ec_rct_pair_t> constants{
-    {crypto::EC_I,         rct::I},
-    {crypto::EC_INV_EIGHT, rct::INV_EIGHT}
-  };
-
-  for (const auto &pair : constants)
-    ASSERT_TRUE(memcmp(&pair.ec, &pair.rct, 32) == 0);
+  ASSERT_TRUE(memcmp(&crypto::EC_I,         &rct::I,         32) == 0);
+  ASSERT_TRUE(memcmp(&crypto::EC_INV_EIGHT, &rct::INV_EIGHT, 32) == 0);
 }
 
 TEST(Crypto, torsion_check_pass_random)