Skip to content

Conversation

@paletteguy
Copy link

No description provided.

@j-ulrich
Copy link
Owner

Thank you for the PR and sorry for the late response!

Yeah, I guess it's time to modernize the Qt variant. However, I think I would rather introduce it as another variant.

However, I wonder about the Invalid code: why did you choose -1 as value for the invalid code? Why not 0?

@paletteguy
Copy link
Author

Thank you for the PR and sorry for the late response!

Yeah, I guess it's time to modernize the Qt variant. However, I think I would rather introduce it as another variant.

However, I wonder about the Invalid code: why did you choose -1 as value for the invalid code? Why not 0?

I guess 0 could used instead. It's just -1 a common undefined :)

@j-ulrich
Copy link
Owner

I guess 0 could used instead. It's just -1 a common undefined :)

Oh well... in the meantime I realized that I already defined -1 to be the "invalid" code implicitly. 😆

@j-ulrich
Copy link
Owner

I implemented it as a new variant and pushed it to https://github.com/j-ulrich/http-status-codes-cpp/tree/feature/%2328-Qt-Cpp11.
What do you think?

@j-ulrich j-ulrich mentioned this pull request Feb 9, 2025
j-ulrich added a commit that referenced this pull request Feb 9, 2025
@j-ulrich
Copy link
Owner

j-ulrich commented Feb 9, 2025

Implemented in #30.
Released in version 1.6.0, however I made a mistake during release so use 1.6.2 instead.

@j-ulrich j-ulrich closed this Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants