TransactionManager catches Exceptions, not Throwables

[noordawod]

Hey there, long time no talk :) I hope you're doing fine, and happy new year to you and your family!

Recently, I've been debugging an app for a few hours and didn't understand why the transaction isn't being rolled back when an error occurs. The thrown error was app-specific and extended Throwable, not Exception. After careful inspection, I saw this in TransactionManager.java: https://github.com/j256/ormlite-core/blob/main/src/main/java/com/j256/ormlite/misc/TransactionManager.java#L255

It seems the callInTransaction will catch only Exceptions, not Throwables.

I reckon it'd be better if the code catches the latter, what do you think @j256 ?

[j256]

Hey Noor. Interesting. I worry a bit about trying to do things with the database after the program has suffered a critical error but I think your example shows that catching throwable would (i.e. including error) is warranted. Can you turn this into an issue that I can code against? Thanks!

[noordawod]

For sure, and I can do you one better: I'll open a pr :)

[noordawod]

Here it is: #307

[j256]

Submitted as 59309e5