mediainfo_alt WDX - Compiling and Updates

[advice2020]

This post is based on the following WDX plugin
mediainfo_crap.tar.gz
Thank you for creating this.

COMPILING
Debian based distro / GTK based DE
DC 1.2.0 alpha QT5.15.8 Standalone Version
Revision 11938 / Commit 8fd3f8780
Lazarus 3.6.0.0 / Free Pascal 3.2.2

When trying to compile the following errors were generated

plugin.cpp: In function ‘int ContentGetSupportedField(int, char*, char*, int)’:
plugin.cpp:95:9: error: ‘strlcpy’ was not declared in this scope; did you mean ‘strncpy’?
   95 |         strlcpy(FieldName, gFields[FieldIndex].name, maxlen - 1);
      |         ^~~~~~~
      |         strncpy
plugin.cpp: In function ‘int ContentGetValue(char*, int, int, void*, int, int)’:
plugin.cpp:167:17: error: ‘strlcpy’ was not declared in this scope; did you mean ‘strncpy’?
  167 |                 strlcpy(gLastFile, FileName, PATH_MAX);
      |                 ^~~~~~~
      |                 strncpy
plugin.cpp:177:17: error: ‘strlcpy’ was not declared in this scope; did you mean ‘strncpy’?
  177 |                 strlcpy((char*)FieldValue, gFields[FieldIndex].value, maxlen - 1);
      |                 ^~~~~~~
      |                 strncpy
/bin/sh: 1: cannot create ../../../dist/.build_fail.lst: Directory nonexistent
make: *** [Makefile:17: all] Error 2

I decided to see what would happen if I did a find & replace of all 4 instances of strlcpy with strncpy

Recompiling this again after generated no messages/errors.
This generates an executable file in the mediainfo_crap folder which is expected behavior.
However instead of the file having a .wdx extension, it uses the parent folders name as the extension
Location
~/Documents/<this-folder-name>/mediainfo_crap/src/
Filename
mediainfo_crap.<name-of-parent-folder>
I had this happen in past with WLX plugin compiles, cannot remember what fixed this naming from happening?

I renamed file to mediainfo_crap.wdx

I linked this WDX plugin in DC Options - Plugins - WDX
I tested this plugin out using Options - Columns - Custom Columns
First MIME type I tested this out with was mp3
All columns showed up empty so I thought the compile was unsuccessful but then realized there was no MPV in "detect string"
Retested and this plugin works!
Similar/maybe slightly faster then the LuaJIT version as far as speed.

Hopefully viewed as being helpful, I created a list of things that I came across (mainly things I just mentioned above) that hopefully helps you when updating.
I will put list in reply after this post.

Okay so this solves the issue of not being able to use DC QT5 + LuaJIT library + mpv_alt WLX plugin.
Thank you again for creating this, I really appreciate it.

[advice2020]

If interested here is the update list I mentioned I would provide

UPDATES

1.) The mediainfo_crap.tar.gz archive contains a precompile .wdx plugin which is probably an Arch compile, would remove it.

2.) Although find and replace worked with replacing all 4 instances of strlcpy with strncpy, probably would just verify if this makes sense (because I obviously do not know, I just went by the terminal message).

3.) Determine if there is any reason for mediainfo_crap.<name-of-parent-folder> naming extension issue rather then .wdx

4.) Being that mp3 is a popular format, would add |(EXT="MP3") to the generated detect string

5.) I would update the name of the plugin itself :) remove the _crap suffix because this is great, not crap :)
Not sure if would call it just mediainfo because it is the only one included in this plugin collection, or to not confuse with the 3rd party plugins collection mediainfo plugin, maybe add a suffix similar to how did with mpv_alt plugin, mediainfo_alt
Not sure, up to you?

6.) Again so far this is great, I would add this into the official collection found on this site.

7.) Not used to compiling WDX plugins I at first totally forgot that '-dev' package was needed for compiling.
I would update the build instructions for this like how you guys provide the needed packages list for compiling.
Not sure which ones exactly are needed but I have the following "mediainfo" based items installed on my Debian based machine
mediainfo libmediainfo0v5 libmediainfo-dev

I still have to test plugin more but I think these items will allow this plugin to be added into official plugin collection available on this site, which I think it should be considered to be added.

Again this list is meant to be helpful, hopefully it is.
Thank you again for this plugin

[j2969719]

makefile is the same as for the rest of my wdx, it is expected that it should be near other plugins. strlcpy is safer, it was included in string.h at some point but it is not available for debian yet, strncpy will do too. this plugin is based on a lua script from skif/alex that is intended for video, detectstring is the same. maybe someday will commit it to the repo, cant do atm

[advice2020]

Okay, wasn't expecting that, thank you.

I made a separate post but I will link it here because the two posts have to do with same general mediainfo plugin idea.
Can be found here
(#48)

[j2969719]

free file hosting

audioinfo.tar.gz
mediainfo_crap.tar.gz

[advice2020]

@j2969719
:) Thank you, did not realize about hosting?
I am not sure if I did this right but I was able to try audioinfo provided and I did not notice a difference?

This archive you provided did not have a typical compiling structure, it appears more like it is for adding right to DC source code before compiling, so that is what I did.
I removed the audioinfo folder provided in DC source code and replaced it with the audioinfo folder in archive you provided.
I then compiled DC QT6 and when I open for example column set in DC Options it just showed the regular audio based items it usually does.
Is it supposed to show other video based items?

Did I not do this correctly?
Thank You

[j2969719]

i hijacked this discussion because needed to upload slightly modified plugins somewhere. the only difference is that they have an additional duration field for searching files

[advice2020]

@j2969719
What are doing to me Sloth, you had me thinking you figured out some way of achieving this in AudioInfo plugin :)
Just writing because I saw that you added the MediaInfo plugin into the main plugin bundle.
I was able test this out a little bit and everything seems okay, the only thing I noticed is that this plugin is still crap! :)
Why didn't you change the name like I mentioned, it is good, not crap :)
Just wanted to thank you for adding this.

Also thank you to Skif and (you mentioned) Alex and any other developers who worked on the original plugin which provided coding for this plugin version. All of these MediaInfo plugins are very useful.

[j2969719]

regarding my favorite suffix in plugin names: usually i add it if there is some stupid stuff in the code, or if the wheel is reinvented, often a square one. eg there may or may not be a memory leak here, and unlike the original script, all the code is dumped into one function. which is..

dont take this repo too seriously