use StringSet

Author: j2kun

mlir/lib/Dialect/Polynomial/IR/PolynomialAttributes.cpp

@@ -13,6 +13,7 @@
 #include "llvm/ADT/SmallSet.h"
 #include "llvm/ADT/StringExtras.h"
 #include "llvm/ADT/StringRef.h"
+#include "llvm/ADT/StringSet.h"
 
 namespace mlir {
 namespace polynomial {
@@ -76,7 +77,7 @@ Attribute PolynomialAttr::parse(AsmParser &parser, Type type) {
     return {};
 
   llvm::SmallVector<Monomial> monomials;
-  llvm::SmallSet<std::string, 2> variables;
+  llvm::StringSet<> variables;
   llvm::DenseSet<APInt> exponents;
 
   while (true) {
@@ -127,7 +128,7 @@ Attribute PolynomialAttr::parse(AsmParser &parser, Type type) {
   }
 
   if (variables.size() > 1) {
-    std::string vars = llvm::join(variables.begin(), variables.end(), ", ");
+    std::string vars = llvm::join(variables.keys(), ", ");
     parser.emitError(
         parser.getCurrentLocation(),
         "polynomials must have one indeterminate, but there were multiple: " +

mlir/test/Dialect/Polynomial/attributes.mlir

@@ -1,7 +1,7 @@
 // RUN: mlir-opt %s --split-input-file --verify-diagnostics
 
 #my_poly = #polynomial.polynomial<y + x**1024>
-// expected-error@below {{polynomials must have one indeterminate, but there were multiple: y, x}}
+// expected-error@below {{polynomials must have one indeterminate, but there were multiple: x, y}}
 #ring1 = #polynomial.ring<coefficientType=i32, coefficientModulus=2837465, polynomialModulus=#my_poly>
 
 // -----