Skip to content

Commit 724f51a

Browse files
committed
feat: Fix for the network remove omissions
1 parent aeb5e19 commit 724f51a

File tree

1 file changed

+16
-5
lines changed
  • docker-controller-scala-kafka/src/main/scala/com/github/j5ik2o/dockerController/kafka

1 file changed

+16
-5
lines changed

docker-controller-scala-kafka/src/main/scala/com/github/j5ik2o/dockerController/kafka/KafkaController.scala

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,8 @@ class KafkaController(
5050
val networkId: String = dockerClient.createNetworkCmd().withName("kafka-" + UUID.randomUUID().toString).exec().getId
5151

5252
val kafkaNetwork: Network = Network(networkId)
53-
val zkAlias: NetworkAlias = NetworkAlias(kafkaNetwork, "zk1")
54-
val kafkaAlias: NetworkAlias = NetworkAlias(kafkaNetwork, "kafka1")
53+
val zkAlias: NetworkAlias = NetworkAlias(kafkaNetwork, "zk1-" + UUID.randomUUID().toString)
54+
val kafkaAlias: NetworkAlias = NetworkAlias(kafkaNetwork, "kafka1-" + UUID.randomUUID().toString)
5555

5656
val zooKeeperHostPort: Int = RandomPortUtil.temporaryServerPort()
5757

@@ -98,10 +98,21 @@ class KafkaController(
9898
zooKeeperController.stopContainer()
9999
}
100100

101+
override protected def newRemoveContainerCmd(): RemoveContainerCmd = {
102+
require(containerId.isDefined)
103+
dockerClient.removeContainerCmd(containerId.get).withForce(true)
104+
}
105+
101106
override def removeContainer(f: RemoveContainerCmd => RemoveContainerCmd): Unit = {
102-
super.removeContainer(f)
103-
zooKeeperController.removeContainer()
104-
dockerClient.removeNetworkCmd(networkId).exec()
107+
try {
108+
super.removeContainer(f)
109+
} finally {
110+
try {
111+
zooKeeperController.removeContainer()
112+
} finally {
113+
dockerClient.removeNetworkCmd(networkId).exec()
114+
}
115+
}
105116
}
106117

107118
override def awaitCondition(duration: Duration)(predicate: Option[Frame] => Boolean): Unit = {

0 commit comments

Comments
 (0)