Skip to content

Commit db84871

Browse files
committed
feat: remove PLUGIN_NAME env variable
1 parent 4fe5467 commit db84871

File tree

6 files changed

+28
-18
lines changed

6 files changed

+28
-18
lines changed

.env.example

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
11
GITHUB_TOKEN="ghp_xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx"
2-
PLUGIN_NAME="wp-react-plugin"

release/.release-it.cjs

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,17 @@
1010
* documentation
1111
* @see https://github.com/release-it/release-it/blob/main/docs/configuration.md
1212
*/
13-
const pluginName = process?.env?.PLUGIN_NAME || 'wp-react-plugin'
13+
14+
const path = require('path')
15+
16+
// get parent directory path
17+
const parentDirectoryPath = path.resolve(__dirname, `../`)
18+
19+
// get parent directory name
20+
const pluginName = path.basename(parentDirectoryPath)
1421

1522
module.exports = {
23+
releasedPluginName: 'wp-react-plugin',
1624
git: {
1725
commit: true,
1826
commitMessage: 'chore: release v${version}',
@@ -44,7 +52,7 @@ module.exports = {
4452
assets: [`./release/${pluginName}.zip`], // relative path
4553
web: false,
4654
},
47-
includes: [
55+
allowedItems: [
4856
'inc',
4957
'js/dist',
5058
'required_plugins',

release/README_cn-zh.md

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -79,11 +79,8 @@ composer install
7979

8080
`GITHUB_TOKEN` 填入您的 [`github personal token`](https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/managing-your-personal-access-tokens#creating-a-personal-access-token-classic)
8181

82-
`PLUGIN_NAME` 填入您的套件目錄名稱,如果填寫錯誤,將無法正確完成打包,🚩寫名稱就好,不需要寫路徑
83-
8482
```bash
8583
GITHUB_TOKEN="ghp_xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx"
86-
PLUGIN_NAME="wp-react-plugin"
8784
```
8885

8986
🚩🚩🚩 因為安全因素,請勿將 GITHUB_TOKEN, 即此 `.env` 納入 github 版本控制中 (預設已在 `.gitignore` 排除),否則 github 將會 Block 你的 push
@@ -96,13 +93,17 @@ PLUGIN_NAME="wp-react-plugin"
9693

9794
所有預設 config 可以參考這 [default config](https://github.com/release-it/release-it/blob/main/config/release-it.json)
9895

99-
接著到設定您要打包的目錄,只有被寫入在 `includes` array 內的檔案會被複製 (會遞規複製裡面的檔案&目錄),例如
96+
---
97+
98+
我們在 `.release-it.cjs` 有兩個自訂的配置項: `allowedItems``releasedPluginName`
99+
100+
`allowedItems`: 只有被寫入在 `allowedItems` array 內的檔案會被複製 (會遞規複製裡面的檔案&目錄),例如
100101

101102
```
102103
// .release-it.cjs
103104
{
104105
...
105-
includes: [
106+
allowedItems: [
106107
'inc',
107108
'js/dist', // 只複製 js/dist,而不會複製 js/src
108109
'required_plugins',
@@ -115,6 +116,9 @@ PLUGIN_NAME="wp-react-plugin"
115116
}
116117
```
117118

119+
`releasedPluginName`: 最終打包的 zip 檔案名稱,例如: 您也可以叫做 my-plugin-release
120+
121+
118122
### 3. 發布
119123

120124
發布前確保一系列工具指令是可以運作的,例如 `eslint`, `phpcbf` 可以作用

release/create-release.cjs

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,9 @@
1212
const fs = require('fs')
1313
const path = require('path')
1414
const { deleteRelease } = require('./delete-release.cjs')
15-
const { includes } = require('./.release-it.cjs')
16-
const pluginName = process?.env?.PLUGIN_NAME || 'wp-react-plugin'
15+
const { allowedItems, releasedPluginName } = require('./.release-it.cjs')
1716
const sourceDir = path.resolve(__dirname, '../')
18-
const destinationDir = path.resolve(__dirname, `./${pluginName}`)
17+
const destinationDir = path.resolve(__dirname, `./${releasedPluginName}`)
1918

2019
/**
2120
* Recursively copy directories and files
@@ -88,4 +87,4 @@ deleteRelease()
8887

8988
// then create release directory
9089

91-
recursiveCopy(sourceDir, destinationDir, includes)
90+
recursiveCopy(sourceDir, destinationDir, allowedItems)

release/delete-release.cjs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,11 @@
33
* Clear files in the release directory
44
*/
55

6-
const pluginName = process?.env?.PLUGIN_NAME || 'wp-react-plugin'
6+
const { releasedPluginName } = require('./.release-it.cjs')
77
const fs = require('fs')
88
const path = require('path')
9-
const entryDir = path.resolve(__dirname, `./${pluginName}`)
10-
const outputZip = path.resolve(__dirname, `./${pluginName}.zip`)
9+
const entryDir = path.resolve(__dirname, `./${releasedPluginName}`)
10+
const outputZip = path.resolve(__dirname, `./${releasedPluginName}.zip`)
1111

1212
/**
1313
* Delete directory recursively

release/zip.cjs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,11 @@
55
* @see https://www.npmjs.com/package/archiver
66
*/
77

8-
const pluginName = process?.env?.PLUGIN_NAME || 'wp-react-plugin'
8+
const { releasedPluginName } = require('./.release-it.cjs')
99
const fs = require('fs')
1010
const path = require('path')
11-
const entryDir = path.resolve(__dirname, `./${pluginName}`)
12-
const outputZip = path.resolve(__dirname, `./${pluginName}.zip`)
11+
const entryDir = path.resolve(__dirname, `./${releasedPluginName}`)
12+
const outputZip = path.resolve(__dirname, `./${releasedPluginName}.zip`)
1313
const archiver = require('archiver')
1414

1515
// 創建一個檔案來存儲zip檔案

0 commit comments

Comments
 (0)