jme3-examples: convert fields to local variables (#1501)

Author: stephengold

jme3-examples/src/main/java/jme3test/animation/TestCinematic.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2009-2020 jMonkeyEngine
+ * Copyright (c) 2009-2021 jMonkeyEngine
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -57,11 +57,9 @@ public class TestCinematic extends SimpleApplication {
 
     private Spatial model;
     private Spatial teapot;
-    private MotionPath path;
     private MotionEvent cameraMotionEvent;
     private Cinematic cinematic;
     private ChaseCamera chaseCam;
-    private FilterPostProcessor fpp;
     private FadeFilter fade;
     private float time = 0;
 
@@ -181,7 +179,7 @@ private void createCameraMotion() {
         camNode.lookAt(teapot.getLocalTranslation(), Vector3f.UNIT_Y);
 
         CameraNode camNode2 = cinematic.bindCamera("aroundCam", cam);
-        path = new MotionPath();
+        MotionPath path = new MotionPath();
         path.setCycle(true);
         path.addWayPoint(new Vector3f(20, 3, 0));
         path.addWayPoint(new Vector3f(0, 3, 20));
@@ -227,7 +225,7 @@ private void createScene() {
         light.setColor(ColorRGBA.White.mult(1.5f));
         rootNode.addLight(light);
 
-        fpp = new FilterPostProcessor(assetManager);
+        FilterPostProcessor fpp = new FilterPostProcessor(assetManager);
         fade = new FadeFilter();
         fpp.addFilter(fade);
 

jme3-examples/src/main/java/jme3test/audio/TestAmbient.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2009-2012 jMonkeyEngine
+ * Copyright (c) 2009-2021 jMonkeyEngine
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -43,8 +43,6 @@
 
 public class TestAmbient extends SimpleApplication {
 
-  private AudioNode nature, waves;
-
   public static void main(String[] args) {
     TestAmbient test = new TestAmbient();
     test.start();
@@ -59,15 +57,15 @@ public void simpleInitApp() {
     Environment env = new Environment(eax);
     audioRenderer.setEnvironment(env);
 
-    waves = new AudioNode(assetManager, "Sound/Environment/Ocean Waves.ogg",
-            DataType.Buffer);
+    AudioNode waves = new AudioNode(assetManager,
+            "Sound/Environment/Ocean Waves.ogg", DataType.Buffer);
     waves.setPositional(true);
     waves.setLocalTranslation(new Vector3f(0, 0,0));
     waves.setMaxDistance(100);
     waves.setRefDistance(5);
 
-    nature = new AudioNode(assetManager, "Sound/Environment/Nature.ogg",
-            DataType.Stream);
+    AudioNode nature = new AudioNode(assetManager,
+            "Sound/Environment/Nature.ogg", DataType.Stream);
     nature.setPositional(false);
     nature.setVolume(3);
 

jme3-examples/src/main/java/jme3test/batching/TestBatchNodeCluster.java

@@ -331,7 +331,6 @@ public int getz(int i) {
         return zPosition.get(i);
     }
     private float time = 0;
-    private Spatial box;
 
     @Override
     public void simpleUpdate(float tpf) {
@@ -352,7 +351,7 @@ public void simpleUpdate(float tpf) {
             mult1 = -1.0f;
             mult2 = -1.0f;
         }
-        box = batchNode.getChild("Box" + random);
+        Spatial box = batchNode.getChild("Box" + random);
         if (box != null) {
             Vector3f v = box.getLocalTranslation();
             box.setLocalTranslation(v.x + FastMath.sin(time * mult1) * 20, v.y + (FastMath.sin(time * mult1) * FastMath.cos(time * mult1) * 20), v.z + FastMath.cos(time * mult2) * 20);

jme3-examples/src/main/java/jme3test/batching/TestBatchNodeTower.java

@@ -78,7 +78,6 @@ public class TestBatchNodeTower extends SimpleApplication {
     private Material mat;
     private Material mat2;
     private Material mat3;
-    private DirectionalLightShadowFilter shadowRenderer;
     private Sphere bullet;
     private Box brick;
     private SphereCollisionShape bulletCollisionShape;
@@ -120,9 +119,9 @@ public void simpleInitApp() {
         batchNode.batch();
         batchNode.setShadowMode(ShadowMode.CastAndReceive);
         rootNode.attachChild(batchNode);
-        
-        
-        shadowRenderer = new DirectionalLightShadowFilter(assetManager, 1024, 2);
+
+        DirectionalLightShadowFilter shadowRenderer
+                = new DirectionalLightShadowFilter(assetManager, 1024, 2);
         DirectionalLight dl = new DirectionalLight();
         dl.setDirection(new Vector3f(-1, -1, -1).normalizeLocal());
         shadowRenderer.setLight(dl);

jme3-examples/src/main/java/jme3test/bullet/TestAttachDriver.java

@@ -60,7 +60,6 @@
 public class TestAttachDriver extends SimpleApplication implements ActionListener {
 
     private VehicleControl vehicle;
-    private RigidBodyControl driver;
     private RigidBodyControl bridge;
     private SliderJoint slider;
     private final float accelerationForce = 1000.0f;
@@ -202,7 +201,8 @@ private void buildPlayer() {
         //driver
         Node driverNode=new Node("driverNode");
         driverNode.setLocalTranslation(0,2,0);
-        driver=new RigidBodyControl(new BoxCollisionShape(new Vector3f(0.2f,.5f,0.2f)));
+        RigidBodyControl driver
+                = new RigidBodyControl(new BoxCollisionShape(new Vector3f(0.2f,.5f,0.2f)));
         driverNode.addControl(driver);
 
         rootNode.attachChild(driverNode);

jme3-examples/src/main/java/jme3test/bullet/TestCollisionListener.java

@@ -48,7 +48,6 @@
 public class TestCollisionListener extends SimpleApplication implements PhysicsCollisionListener {
 
     private BulletAppState bulletAppState;
-    private Sphere bullet;
 
     public static void main(String[] args) {
         TestCollisionListener app = new TestCollisionListener();
@@ -60,7 +59,7 @@ public void simpleInitApp() {
         bulletAppState = new BulletAppState();
         stateManager.attach(bulletAppState);
         bulletAppState.setDebugEnabled(true);
-        bullet = new Sphere(32, 32, 0.4f, true, false);
+        Sphere bullet = new Sphere(32, 32, 0.4f, true, false);
         bullet.setTextureMode(TextureMode.Projected);
 
         PhysicsTestHelper.createPhysicsTestWorld(rootNode, assetManager, bulletAppState.getPhysicsSpace());

jme3-examples/src/main/java/jme3test/bullet/TestFancyCar.java

@@ -54,7 +54,6 @@ public class TestFancyCar extends SimpleApplication implements ActionListener {
 
     private BulletAppState bulletAppState;
     private VehicleControl player;
-    private float wheelRadius;
     private float steeringValue = 0;
     private float accelerationValue = 0;
     private Node carNode;
@@ -174,7 +173,7 @@ private void buildPlayer() {
         Geometry wheel_fr = findGeom(carNode, "WheelFrontRight");
         wheel_fr.center();
         box = (BoundingBox) wheel_fr.getModelBound();
-        wheelRadius = box.getYExtent();
+        float wheelRadius = box.getYExtent();
         float back_wheel_h = (wheelRadius * 1.7f) - 1f;
         float front_wheel_h = (wheelRadius * 1.9f) - 1f;
         player.addWheel(wheel_fr.getParent(), box.getCenter().add(0, -front_wheel_h, 0),

jme3-examples/src/main/java/jme3test/bullet/TestHoveringTank.java

@@ -70,8 +70,6 @@ public class TestHoveringTank extends SimpleApplication implements AnalogListene
     private BulletAppState bulletAppState;
     private PhysicsHoverControl hoverControl;
     private Spatial spaceCraft;
-    private TerrainQuad terrain;
-    private Material matRock;
     /**
      * initial location of the tank (in world/physics-space coordinates)
      */
@@ -252,7 +250,8 @@ public void simpleUpdate(float tpf) {
     }
 
     private void createTerrain() {
-        matRock = new Material(assetManager, "Common/MatDefs/Terrain/TerrainLighting.j3md");
+        Material matRock = new Material(assetManager,
+                "Common/MatDefs/Terrain/TerrainLighting.j3md");
         matRock.setBoolean("useTriPlanarMapping", false);
         matRock.setBoolean("WardIso", true);
         matRock.setTexture("AlphaMap", assetManager.loadTexture("Textures/Terrain/splat/alphamap.png"));
@@ -286,7 +285,8 @@ private void createTerrain() {
         } catch (Exception e) {
             e.printStackTrace();
         }
-        terrain = new TerrainQuad("terrain", 65, 513, heightmap.getHeightMap());
+        TerrainQuad terrain
+                = new TerrainQuad("terrain", 65, 513, heightmap.getHeightMap());
         List<Camera> cameras = new ArrayList<>();
         cameras.add(getCamera());
         TerrainLodControl control = new TerrainLodControl(terrain, cameras);

jme3-examples/src/main/java/jme3test/bullet/TestIssue1120.java

@@ -68,8 +68,6 @@ public class TestIssue1120 extends SimpleApplication {
     private static TestIssue1120 test;
     private BulletAppState bulletAppState;
     private final boolean physicsDebug = true;
-    private BitmapFont font;
-    private final BitmapText[] testInfo = new BitmapText[2];
     private BitmapText speedText;
     private final List<Spatial> testObjects = new ArrayList<>();
     private static final boolean SKIP_SETTINGS = false;//Used for repeated runs of this test during dev
@@ -133,7 +131,8 @@ public void simpleInitApp() {
         }, "pause", "restart", "+", "-");
 
         guiNode = getGuiNode();
-        font = assetManager.loadFont("Interface/Fonts/Default.fnt");
+        BitmapFont font = assetManager.loadFont("Interface/Fonts/Default.fnt");
+        BitmapText[] testInfo = new BitmapText[2];
         testInfo[0] = new BitmapText(font);
         testInfo[1] = new BitmapText(font);
         speedText = new BitmapText(font);

jme3-examples/src/main/java/jme3test/bullet/TestPhysicsCharacter.java

@@ -56,8 +56,6 @@ public class TestPhysicsCharacter extends SimpleApplication implements ActionLis
 
   private BulletAppState bulletAppState;
   private CharacterControl physicsCharacter;
-  private Node characterNode;
-  private CameraNode camNode;
   final private Vector3f walkDirection = new Vector3f(0,0,0);
   final private Vector3f viewDirection = new Vector3f(0,0,0);
   private boolean leftStrafe = false, rightStrafe = false, forward = false, backward = false, 
@@ -110,7 +108,7 @@ public void simpleInitApp() {
     // Add a physics character to the world
     physicsCharacter = new CharacterControl(new CapsuleCollisionShape(0.5f, 1.8f), .1f);
     physicsCharacter.setPhysicsLocation(new Vector3f(0, 1, 0));
-    characterNode = new Node("character node");
+    Node characterNode = new Node("character node");
     Spatial model = assetManager.loadModel("Models/Sinbad/Sinbad.mesh.xml");
     model.scale(0.25f);
     characterNode.addControl(physicsCharacter);
@@ -119,7 +117,7 @@ public void simpleInitApp() {
     characterNode.attachChild(model);
 
     // set forward camera node that follows the character
-    camNode = new CameraNode("CamNode", cam);
+    CameraNode camNode = new CameraNode("CamNode", cam);
     camNode.setControlDir(ControlDirection.SpatialToCamera);
     camNode.setLocalTranslation(new Vector3f(0, 1, -5));
     camNode.lookAt(model.getLocalTranslation(), Vector3f.UNIT_Y);