Clean up unneeded changes

Author: richardTingle

.github/workflows/main.yml

@@ -53,23 +53,22 @@ on:
       - v3.3
   pull_request:
   release:
-    types: [ published ]
+    types: [published]
 
 jobs:
   ScreenshotTests:
     name: Run Screenshot Tests
     runs-on: ubuntu-latest
     permissions:
       contents: read
-      pull-requests: write
     steps:
     - uses: actions/checkout@v4
     - name: Set up JDK 17
       uses: actions/setup-java@v4
       with:
         java-version: '17'
         distribution: 'temurin'
-    - name: Install Mesa3D and OpenCL
+    - name: Install Mesa3D
       run: |
         sudo apt-get update
         sudo apt-get install -y mesa-utils libgl1-mesa-dri libgl1 libglx-mesa0 xvfb
@@ -127,14 +126,14 @@ jobs:
 
   # Build the engine, we only deploy from ubuntu-latest jdk21
   BuildJMonkey:
-    needs: [ BuildAndroidNatives ]
+    needs: [BuildAndroidNatives]
     name: Build on ${{ matrix.osName }} jdk${{ matrix.jdk }}
     runs-on: ${{ matrix.os }}
     strategy:
       fail-fast: false
       matrix:
-        os: [ ubuntu-latest,windows-latest,macOS-latest ]
-        jdk: [ 11, 17, 21 ]
+        os: [ubuntu-latest,windows-latest,macOS-latest]
+        jdk: [11, 17, 21]
         include:
           - os: ubuntu-latest
             osName: linux
@@ -230,7 +229,7 @@ jobs:
           path: dist/maven
 
       - name: Upload javadoc
-        if: matrix.deploy==true
+        if:  matrix.deploy==true
         uses: actions/upload-artifact@master
         with:
           name: javadoc
@@ -249,7 +248,7 @@ jobs:
   # this is useful for people that want to build only the java part and don't have
   # all the stuff needed to compile natives.
   DeployNativeSnapshot:
-    needs: [ BuildJMonkey ]
+    needs: [BuildJMonkey]
     name: "Deploy native snapshot"
     runs-on: ubuntu-latest
     if: github.event_name == 'push'
@@ -335,7 +334,7 @@ jobs:
 
   # This job deploys snapshots on the master branch
   DeployJavaSnapshot:
-    needs: [ BuildJMonkey ]
+    needs: [BuildJMonkey]
     name: Deploy Java Snapshot
     runs-on: ubuntu-latest
     if: github.event_name == 'push' && github.ref_name == 'master'
@@ -379,7 +378,7 @@ jobs:
 
   # This job deploys the release
   DeployRelease:
-    needs: [ BuildJMonkey ]
+    needs: [BuildJMonkey]
     name: Deploy Release
     runs-on: ubuntu-latest
     if: github.event_name == 'release'
@@ -460,7 +459,7 @@ jobs:
 
   # Deploy the javadoc
   DeployJavaDoc:
-    needs: [ BuildJMonkey ]
+    needs: [BuildJMonkey]
     name: Deploy Javadoc
     runs-on: ubuntu-latest
     if: github.event_name == 'release'

jme3-screenshot-tests/src/main/java/org/jmonkeyengine/screenshottests/testframework/ScreenshotTest.java

@@ -49,8 +49,6 @@ public class ScreenshotTest{
 
     AppState[] states;
 
-    boolean withOpenClSupport;
-
     List<Integer> framesToTakeScreenshotsOn = new ArrayList<>();
 
     TestResolution resolution = new TestResolution(500, 400);
@@ -71,11 +69,6 @@ public ScreenshotTest setFramesToTakeScreenshotsOn(Integer... frames){
         return this;
     }
 
-    public ScreenshotTest withOpenCLSupport(){
-        withOpenClSupport = true;
-        return this;
-    }
-
     /**
      * Sets the test type (i.e. what the pass/fail rules are for the test
      */
@@ -104,7 +97,7 @@ public void run(){
         settings.setResolution(resolution.getWidth(), resolution.getHeight());
         settings.setAudioRenderer(null); // Disable audio (for headless)
         settings.setUseInput(false); //while it will run with inputs on it causes non-fatal errors.
-        settings.setOpenCLSupport(withOpenClSupport);
+
         String imageFilePrefix = baseImageFileName == null ? calculateImageFilePrefix() : baseImageFileName;
 
         TestDriver.bootAppForTest(testType,settings,imageFilePrefix, framesToTakeScreenshotsOn, states);