PROPERTY_BUFFER_ALLOCATOR_IMPLEMENTATION set by LwjglContext gets ignored sometimes

[Ali-RS]

Hi

LwjglContext (in jme3-lwjgl3 module) specifies its own implementation of buffer allocator to be used by BufferAllocatorFactory by setting PROPERTY_BUFFER_ALLOCATOR_IMPLEMENTATION property in this static code block:

jmonkeyengine/jme3-lwjgl3/src/main/java/com/jme3/system/lwjgl/LwjglContext.java

Lines 91 to 102 in 8af0c92

	static {
	final String implementation = BufferAllocatorFactory.PROPERTY_BUFFER_ALLOCATOR_IMPLEMENTATION;
	if (System.getProperty(implementation) == null) {
	if (Boolean.parseBoolean(System.getProperty(PROPERTY_CONCURRENT_BUFFER_ALLOCATOR, "true"))) {
	System.setProperty(implementation, ConcurrentLWJGLBufferAllocator.class.getName());
	} else {
	System.setProperty(implementation, LWJGLBufferAllocator.class.getName());
	}
	}
	}

the issue is that sometimes this property gets ignored by BufferAllocatorFactory and a ReflectionAllocator is created instead. That is because BufferAllocatorFactory.create() method sometimes is called before the LwjglContext sets the new property. Inside the BufferUtils class:

jmonkeyengine/jme3-core/src/main/java/com/jme3/util/BufferUtils.java

Line 65 in 8af0c92

private static final BufferAllocator allocator = BufferAllocatorFactory.create();

Sometimes the order of these static executions is different, e.g the one in the BufferUtils runs before the LwjglContext, which will cause BufferAllocator allocator to get initialized with Reflectionallocator and bypass the LWJGL3 allocator.

Edit:
2 possible fixes are suggested for this issue:

#1674 (comment)

and:

#1674 (comment)

Edit2:
Forum topic:
https://hub.jmonkeyengine.org/t/buffer-allocator-implementation-set-by-lwjglcontext-gets-ignored-sometimes/45594

[Ali-RS]

We might have the same issue in android OGLESContext as well:

jmonkeyengine/jme3-android/src/main/java/com/jme3/system/android/OGLESContext.java

Lines 81 to 87 in 8af0c92

	static {
	final String implementation = BufferAllocatorFactory.PROPERTY_BUFFER_ALLOCATOR_IMPLEMENTATION;
	if (System.getProperty(implementation) == null) {
	System.setProperty(implementation, AndroidBufferAllocator.class.getName());
	}
	}

[Ali-RS]

Put simply we can also fix it at initializer: https://start.jmonkeyengine.org

So if someone picks lwjgl3 backend the initializer should define this VM option inside applicationDefaultJvmArgs of gradle build. Easy-peasy!

'-Dcom.jme3.BufferAllocatorImplementation=com.jme3.util.LWJGLBufferAllocator$ConcurrentLWJGLBufferAllocator' 

It should be similar for android as well in which case we should set the android native allocator.

Edit:
Well, not that easy! I just remembered that in the case of lwjgl3 the above line will appear wrong in the generated Linux start script. Afaik there will be a \ added before $. Not sure why!

But it can be fixed by adding this in startScripts task:

startScripts {
    doLast {
        unixScript.text  = unixScript.text.replace('LWJGLBufferAllocator\\$', 'LWJGLBufferAllocator$')
    }
}