Skip to content

Commit fea615b

Browse files
committed
Issue-606. replace String list with TreeSet
1 parent 828da64 commit fea615b

File tree

1 file changed

+10
-9
lines changed

1 file changed

+10
-9
lines changed

jme3-core/src/com/jme3/gde/core/assets/ProjectAssetManager.java

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@
5050
import java.util.LinkedList;
5151
import java.util.List;
5252
import java.util.Set;
53+
import java.util.TreeSet;
5354
import java.util.logging.Level;
5455
import java.util.logging.Logger;
5556
import org.netbeans.api.java.classpath.ClassPath;
@@ -506,12 +507,12 @@ public String[] getMatDefs(boolean includeDependencies) {
506507
return filesWithSuffix("j3md", includeDependencies);
507508
}
508509

509-
public List<String> getProjectShaderNodeDefs() {
510-
return collectProjectFilesWithSuffix("j3sn", new LinkedList<>());
510+
public Set<String> getProjectShaderNodeDefs() {
511+
return collectProjectFilesWithSuffix("j3sn", new TreeSet<>());
511512
}
512513

513-
public List<String> getDependenciesShaderNodeDefs() {
514-
return collectDependenciesFilesWithSuffix("j3sn", new LinkedList<>());
514+
public Set<String> getDependenciesShaderNodeDefs() {
515+
return collectDependenciesFilesWithSuffix("j3sn", new TreeSet<>());
515516
}
516517

517518
public String[] getAssetsWithSuffix(String string) {
@@ -523,20 +524,20 @@ public String[] getAssetsWithSuffix(String string, boolean includeDependencies)
523524
}
524525

525526
private String[] filesWithSuffix(String string, boolean includeDependencies) {
526-
List<String> list = collectFilesWithSuffix(string, includeDependencies);
527+
Set<String> list = collectFilesWithSuffix(string, includeDependencies);
527528
return list.toArray(String[]::new);
528529
}
529530

530-
private List<String> collectFilesWithSuffix(String suffix, boolean includeDependencies) {
531-
List<String> list = new LinkedList<>();
531+
private Set<String> collectFilesWithSuffix(String suffix, boolean includeDependencies) {
532+
Set<String> list = new TreeSet<>();
532533
collectProjectFilesWithSuffix(suffix, list);
533534
if(includeDependencies) {
534535
collectDependenciesFilesWithSuffix(suffix, list);
535536
}
536537
return list;
537538
}
538539

539-
private List<String> collectProjectFilesWithSuffix(String suffix, List<String> list) {
540+
private Set<String> collectProjectFilesWithSuffix(String suffix, Set<String> list) {
540541
FileObject assetsFolder = getAssetFolder();
541542
if (assetsFolder != null) {
542543
Enumeration<FileObject> assets = (Enumeration<FileObject>) assetsFolder.getChildren(true);
@@ -550,7 +551,7 @@ private List<String> collectProjectFilesWithSuffix(String suffix, List<String> l
550551
return list;
551552
}
552553

553-
private List<String> collectDependenciesFilesWithSuffix(String suffix, List<String> list) {
554+
private Set<String> collectDependenciesFilesWithSuffix(String suffix, Set<String> list) {
554555
synchronized (classPathItems) {
555556
// TODO I need to find out if classPathItems contains all jars added to a project
556557
Iterator<ClassPathItem> classPathItemsIter = classPathItems.iterator();

0 commit comments

Comments
 (0)