addressing review comments

Author: jabez007

.github/workflows/publish.yml

@@ -64,7 +64,7 @@ jobs:
           path: dist/
 
       - name: Upload to GitHub Release
-        uses: softprops/action-gh-release@v1
+        uses: softprops/action-gh-release@v2
         with:
           files: dist/*
 

src/mccann_hub/odoolib/connector/json_rpc.py

@@ -75,14 +75,23 @@ def _json_rpc(self, fct_name, params):
             "params": params,
             "id": random.randint(0, 1000000000),
         }
-        result_req = requests.post(
-            self.url,
-            data=json.dumps(data),
-            headers={
-                "Content-Type": "application/json",
-            },
-        )
+
+        try:
+            result_req = requests.post(
+                self.url,
+                data=json.dumps(data),
+                headers={
+                    "Content-Type": "application/json",
+                },
+                # timeout=10 # ← sensible default
+            )
+            result_req.raise_for_status()
+        except requests.RequestException as err:  # network / HTTP errors
+            raise JsonRpcException({"code": -32000, "message": str(err)}) from err
+
         result = result_req.json()
+
         if result.get("error", None):
             raise JsonRpcException(result["error"])
+
         return result.get("result", False)

src/mccann_hub/odoolib/main.py

@@ -49,17 +49,17 @@ def get_connector(hostname: str, protocol="xmlrpc", port=8069):
     :param protocol: The name of the protocol, must be "xmlrpc", "xmlrpcs", "jsonrpc" or "jsonrpcs".
     :param port: The number of the port. Defaults to 8069.
     """
-    if protocol == "xmlrpc":
-        return XmlRpcConnector(hostname, port)
-    elif protocol == "xmlrpcs":
-        return XmlRpcsConnector(hostname, port)
-    if protocol == "jsonrpc":
-        return JsonRpcConnector(hostname, port)
-    elif protocol == "jsonrpcs":
-        return JsonRpcsConnector(hostname, port)
-    else:
-        raise ValueError("You must choose xmlrpc, xmlrpcs, jsonrpc or jsonrpcs")
-
+    match protocol:
+        case "xmlrpc":
+            return XmlRpcConnector(hostname, port)
+        case "xmlrpcs":
+            return XmlRpcsConnector(hostname, port)
+        case "jsonrpc":
+            return JsonRpcConnector(hostname, port)
+        case "jsonrpcs":
+            return JsonRpcsConnector(hostname, port)
+        case _:
+            raise ValueError("You must choose xmlrpc, xmlrpcs, jsonrpc or jsonrpcs")
 
 def get_connection(
     hostname: str,