Merge branch 'master' of https://github.com/Microsoft/TypeScript into bug/24542-bad-error-message-for-import-ing-an-export

Author: a-tarasyuk

.github/ISSUE_TEMPLATE/Bug_report.md

@@ -16,10 +16,10 @@ Please fill in the *entire* template below.
 -->
 
 <!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->
-**TypeScript Version:**  3.0.0-dev.201xxxxx
+**TypeScript Version:**  3.1.0-dev.201xxxxx
 
 <!-- Search terms you tried before logging this (so others can find this issue more easily) -->
-**Search Terms:** 
+**Search Terms:**
 
 **Code**
 
@@ -32,6 +32,6 @@ Please fill in the *entire* template below.
 
 **Actual behavior:**
 
-**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior --> 
+**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior -->
 
 **Related Issues:** <!-- Did you find other bugs that looked similar? -->

.gitignore

@@ -74,4 +74,6 @@ tests/cases/user/*/**/*.d.ts
 !tests/cases/user/bignumber.js/
 !tests/cases/user/discord.js/
 tests/baselines/reference/dt
-.failed-tests
+.failed-tests
+TEST-results.xml
+package-lock.json

.mailmap

@@ -163,7 +163,7 @@ Rostislav Galimsky  <[email protected]>
 Richard Knoll <[email protected]> Richard Knoll <[email protected]>
 Richard Karmazín  <[email protected]>
 Rowan Wyborn <[email protected]>
-Ryan Cavanaugh <[email protected]> Ryan Cavanaugh <[email protected]> Ryan Cavanaugh <[email protected]>
+Ryan Cavanaugh <[email protected]> Ryan Cavanaugh <[email protected]> Ryan Cavanaugh <[email protected]> Ryan Cavanaugh  <[email protected]>
 Ryohei Ikegami <[email protected]>
 Sarangan Rajamanickam <[email protected]>
 Sébastien Arod <[email protected]>
@@ -340,4 +340,22 @@ EcoleKeine  <[email protected]> # Ecole Keine
 Khải  <[email protected]>
 rhysd  <[email protected]> # @rhysd
 Zen  <[email protected]> Zzzen  <[email protected]> # @Zzzen
-bluelovers  <[email protected]> # @bluelovers
+bluelovers  <[email protected]> # @bluelovers
+Dan Freeman  <[email protected]>
+David Sherret  <[email protected]>
+David Staheli  <[email protected]>
+Elizabeth Dinella  <[email protected]>
+John Doe  <[email protected]>
+Kevin Gibbons  <[email protected]>
+Markus Johnsson  <[email protected]>
+Martin Probst  <[email protected]>
+Mateusz Burzyński  <[email protected]>
+Steven  <[email protected]> # @styfle
+Pi Lanningham  <[email protected]>
+Sam Bostock  <[email protected]>
+Vimal Raghubir  <[email protected]>
+Vyacheslav Pukhanov  <[email protected]>
+dangoo  <[email protected]> # Daniel Gooss
+krk  <[email protected]> # Kerem Kat
+micnic  <[email protected]> # Nicu Micleușanu
+rflorian  <[email protected]> # @rflorian

.npmignore

@@ -19,8 +19,10 @@ Jakefile.js
 .circleci
 .vscode/
 .parallelperf.json
+.mailmap
 test.config
 package-lock.json
 yarn.lock
 .github/
 CONTRIBUTING.md
+TEST-results.xml

.npmrc

@@ -0,0 +1 @@
+package-lock=false

.travis.yml

@@ -19,6 +19,7 @@ branches:
   - release-2.7
   - release-2.8
   - release-2.9
+  - release-3.0
 
 install:
   - npm uninstall typescript --no-save

AUTHORS.md

@@ -74,15 +74,19 @@ TypeScript is authored by:
 * Dafrok Zhang
 * Dahan Gong
 * Dan Corder
+* Dan Freeman 
 * Dan Quirk
+* Daniel Gooss
 * Daniel Hollocher
 * Daniel Król 
 * Daniel Lehenbauer
 * Daniel Rosenwasser
 * David Kmenta
 * David Li
 * David Sheldrick 
+* David Sherret 
 * David Souther
+* David Staheli 
 * Denis Nedelyaev
 * Derek P Sifford 
 * Dhruv Rajvanshi 
@@ -96,6 +100,7 @@ TypeScript is authored by:
 * @e-cloud
 * Ecole Keine
 * Elisée Maurer
+* Elizabeth Dinella 
 * Emilio García-Pumarino
 * Eric Grube 
 * Eric Tsang
@@ -161,6 +166,7 @@ TypeScript is authored by:
 * Joel Day 
 * Joey Wilson
 * Johannes Rieken
+* John Doe 
 * John Vilk
 * Jonathan Bond-Caron
 * Jonathan Park
@@ -184,7 +190,9 @@ TypeScript is authored by:
 * Keith Mashinter
 * Ken Howard
 * Kenji Imamula
+* Kerem Kat
 * Kevin Donnelly 
+* Kevin Gibbons 
 * Kevin Lang 
 * Khải 
 * Kitson Kelly 
@@ -201,10 +209,13 @@ TypeScript is authored by:
 * Manish Giri
 * Marin Marinov
 * Marius Schulz 
+* Markus Johnsson 
 * Martin Hiller 
+* Martin Probst 
 * Martin Vseticka
 * Martyn Janes 
 * Masahiro Wakame
+* Mateusz Burzyński 
 * Matt Bierner 
 * Matt McCutchen
 * Matt Mitchell 
@@ -223,10 +234,10 @@ TypeScript is authored by:
 * Mohamed Hegazy
 * Mohsen Azimi 
 * Myles Megyesi 
-* Natalie Coley
 * Nathan Shively-Sanders
 * Nathan Yee
 * Nicolas Henry
+* Nicu Micleușanu
 * @nieltg
 * Nima Zahedi
 * Noah Chen 
@@ -248,6 +259,7 @@ TypeScript is authored by:
 * Peter Burns
 * Philip Bulley
 * Philippe Voinov 
+* Pi Lanningham 
 * Piero Cangianiello
 * @piloopin
 * Prayag Verma
@@ -270,6 +282,7 @@ TypeScript is authored by:
 * Rowan Wyborn
 * Ryan Cavanaugh
 * Ryohei Ikegami
+* Sam Bostock 
 * Sam El-Husseini 
 * Sarangan Rajamanickam
 * Sean Barag 
@@ -290,6 +303,7 @@ TypeScript is authored by:
 * Stas Vilchik 
 * Stephan Ginthör 
 * Steve Lucco
+* @styfle
 * Sudheesh Singanamalla 
 * Sébastien Arod
 * @T18970237136
@@ -316,8 +330,10 @@ TypeScript is authored by:
 * Vidar Tonaas Fauske
 * Viktor Zozulyak
 * Vilic Vane
+* Vimal Raghubir 
 * Vladimir Kurchatkin 
 * Vladimir Matveev
+* Vyacheslav Pukhanov 
 * Wenlu Wang 
 * Wesley Wigham
 * William Orr 

CONTRIBUTING.md

@@ -61,7 +61,7 @@ Design changes will not be accepted at this time. If you have a design change pr
 
 You will need to complete a Contributor License Agreement (CLA). Briefly, this agreement testifies that you are granting us permission to use the submitted change according to the terms of the project's license, and that the work being submitted is under appropriate copyright.
 
-Please submit a Contributor License Agreement (CLA) before submitting a pull request. You may visit https://cla.microsoft.com to sign digitally. Alternatively, download the agreement ([Microsoft Contribution License Agreement.docx](https://www.codeplex.com/Download?ProjectName=typescript&DownloadId=822190) or [Microsoft Contribution License Agreement.pdf](https://www.codeplex.com/Download?ProjectName=typescript&DownloadId=921298)), sign, scan, and email it back to <[email protected]>. Be sure to include your github user name along with the agreement. Once we have received the signed CLA, we'll review the request. 
+Please submit a Contributor License Agreement (CLA) before submitting a pull request. You may visit https://cla.microsoft.com to sign digitally. Alternatively, download the agreement ([Microsoft Contribution License Agreement.pdf](https://opensource.microsoft.com/pdf/microsoft-contribution-license-agreement.pdf)), sign, scan, and email it back to <[email protected]>. Be sure to include your github user name along with the agreement. Once we have received the signed CLA, we'll review the request. 
 
 ## Housekeeping
 

Gulpfile.js

@@ -24,10 +24,9 @@ const baselineAccept = require("./scripts/build/baselineAccept");
 const cmdLineOptions = require("./scripts/build/options");
 const exec = require("./scripts/build/exec");
 const browserify = require("./scripts/build/browserify");
-const debounce = require("./scripts/build/debounce");
 const prepend = require("./scripts/build/prepend");
 const { removeSourceMaps } = require("./scripts/build/sourcemaps");
-const { CancelSource, CancelError } = require("./scripts/build/cancellation");
+const { CancellationTokenSource, CancelError, delay, Semaphore } = require("prex"); 
 const { libraryTargets, generateLibs } = require("./scripts/build/lib");
 const { runConsoleTests, cleanTestDirs, writeTestConfigFile, refBaseline, localBaseline, refRwcBaseline, localRwcBaseline } = require("./scripts/build/tests");
 
@@ -534,57 +533,80 @@ gulp.task(
     ["watch-diagnostics", "watch-lib"].concat(useCompilerDeps),
     () => project.watch(tsserverProject, { typescript: useCompiler }));
 
-gulp.task(
-    "watch-local",
-    /*help*/ false,
-    ["watch-lib", "watch-tsc", "watch-services", "watch-server"]);
-
 gulp.task(
     "watch-runner",
     /*help*/ false,
     useCompilerDeps,
     () => project.watch(testRunnerProject, { typescript: useCompiler }));
 
-const watchPatterns = [
-    runJs,
-    typescriptDts,
-    tsserverlibraryDts
-];
+gulp.task(
+    "watch-local",
+    "Watches for changes to projects in src/ (but does not execute tests).",
+    ["watch-lib", "watch-tsc", "watch-services", "watch-server", "watch-runner", "watch-lssl"]);
 
 gulp.task(
     "watch",
-    "Watches for changes to the build inputs for built/local/run.js, then executes runtests-parallel.",
+    "Watches for changes to the build inputs for built/local/run.js, then runs tests.",
     ["build-rules", "watch-runner", "watch-services", "watch-lssl"],
     () => {
-        /** @type {CancelSource | undefined} */
-        let runTestsSource;
+        const sem = new Semaphore(1);
 
-        const fn = debounce(() => {
-            runTests().catch(error => {
-                if (error instanceof CancelError) {
-                    log.warn("Operation was canceled");
-                }
-                else {
-                    log.error(error);
-                }
-            });
-        }, /*timeout*/ 100, { max: 500 });
-
-        gulp.watch(watchPatterns, () => project.wait().then(fn));
+        gulp.watch([runJs, typescriptDts, tsserverlibraryDts], () => {
+            runTests();
+        });
 
         // NOTE: gulp.watch is far too slow when watching tests/cases/**/* as it first enumerates *every* file
         const testFilePattern = /(\.ts|[\\/]tsconfig\.json)$/;
         fs.watch("tests/cases", { recursive: true }, (_, file) => {
-            if (testFilePattern.test(file)) project.wait().then(fn);
+            if (testFilePattern.test(file)) runTests();
         });
 
-        function runTests() {
-            if (runTestsSource) runTestsSource.cancel();
-            runTestsSource = new CancelSource();
-            return cmdLineOptions.tests || cmdLineOptions.failed
-                ? runConsoleTests(runJs, "mocha-fivemat-progress-reporter", /*runInParallel*/ false, /*watchMode*/ true, runTestsSource.token)
-                : runConsoleTests(runJs, "min", /*runInParallel*/ true, /*watchMode*/ true, runTestsSource.token);
-        }
+        async function runTests() {
+            try {
+                // Ensure only one instance of the test runner is running at any given time.
+                if (sem.count > 0) {
+                    await sem.wait();
+                    try {
+                        // Wait for any concurrent recompilations to complete...
+                        try {
+                            await delay(100);
+                            while (project.hasRemainingWork()) {
+                                await project.waitForWorkToComplete();
+                                await delay(500);
+                            }
+                        }
+                        catch (e) {
+                            if (e instanceof CancelError) return;
+                            throw e;
+                        }
+
+                        // cancel any pending or active test run if a new recompilation is triggered
+                        const source = new CancellationTokenSource();
+                        project.waitForWorkToStart().then(() => {
+                            source.cancel();
+                        });
+                    
+                        if (cmdLineOptions.tests || cmdLineOptions.failed) {
+                            await runConsoleTests(runJs, "mocha-fivemat-progress-reporter", /*runInParallel*/ false, /*watchMode*/ true, source.token);
+                        }
+                        else {
+                            await runConsoleTests(runJs, "min", /*runInParallel*/ true, /*watchMode*/ true, source.token);
+                        }
+                    }
+                    finally {
+                        sem.release();
+                    }
+                }
+            }
+            catch (e) {
+                if (e instanceof CancelError) {
+                    log.warn("Operation was canceled");
+                }
+                else {
+                    log.error(e);
+                }
+            }
+        };
     });
 
 gulp.task("clean-built", /*help*/ false, [`clean:${diagnosticInformationMapTs}`], () => del(["built"]));

Jakefile.js

@@ -51,7 +51,8 @@ const TaskNames = {
     configureInsiders: "configure-insiders",
     publishInsiders: "publish-insiders",
     configureNightly: "configure-nightly",
-    publishNightly: "publish-nightly"
+    publishNightly: "publish-nightly",
+    help: "help"
 };
 
 const Paths = {};
@@ -258,6 +259,11 @@ task(TaskNames.publishNightly, [TaskNames.coreBuild, TaskNames.configureNightly,
     exec(cmd, () => complete());
 }, { async: true });
 
+task(TaskNames.help, function() {
+    var cmd = "jake --tasks";
+    exec(cmd, () => complete());
+})
+
 task(TaskNames.configureInsiders, [TaskNames.scripts], function () {
     const cmd = `${host} ${Paths.scripts.configurePrerelease} insiders ${Paths.packageJson} ${Paths.versionFile}`;
     exec(cmd, () => complete());
@@ -817,7 +823,7 @@ function diagnosticsToString(diagnostics, pretty) {
  * Concatenate a list of sourceFiles to a destinationFile
  * @param {string} destinationFile
  * @param {string[]} sourceFiles
- * @param {string} extraContent
+ * @param {string=} extraContent
  */
 function concatenateFiles(destinationFile, sourceFiles, extraContent) {
     var temp = "temptemp";