Skip to content

Commit 3ff0a24

Browse files
committed
Update based on PR feedback
1 parent 5710f7d commit 3ff0a24

17 files changed

+23
-23
lines changed

src/compiler/factory.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3645,7 +3645,7 @@ namespace ts {
36453645
return { value: o && o[i++], done: !o };
36463646
}
36473647
};
3648-
throw new TypeError(s ? "Object not iterable." : "Symbol.iterator is not defined.");
3648+
throw new TypeError(s ? "Object is not iterable." : "Symbol.iterator is not defined.");
36493649
};`
36503650
};
36513651

src/testRunner/unittests/evaluation/forOf.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ describe("unittests:: evaluation:: forOfEvaluation", () => {
6666
}
6767
`, { downlevelIteration: true, target: ts.ScriptTarget.ES5 });
6868

69-
assert.throws(() => result.main(), "undefined is not iterable (cannot read property Symbol(Symbol.iterator))");
69+
assert.throws(() => result.main(), /cannot read property.*Symbol\(Symbol\.iterator\).*/i);
7070
});
7171

7272
it("es5 over object with no Symbol.iterator with no Symbol", () => {
@@ -93,7 +93,7 @@ describe("unittests:: evaluation:: forOfEvaluation", () => {
9393
}
9494
`, { downlevelIteration: true, target: ts.ScriptTarget.ES5 });
9595

96-
assert.throws(() => result.main(), "Object not iterable");
96+
assert.throws(() => result.main(), "Object is not iterable");
9797
});
9898

9999
it("es5 over object with Symbol.iterator", () => {
@@ -110,7 +110,7 @@ describe("unittests:: evaluation:: forOfEvaluation", () => {
110110
{
111111
output.push(value)
112112
}
113-
113+
114114
}`, { downlevelIteration: true, target: ts.ScriptTarget.ES5 });
115115

116116
result.main();

tests/baselines/reference/ES5For-of33.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tests/baselines/reference/ES5For-of33.sourcemap.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ sourceFile:ES5For-of33.ts
1717
>>> return { value: o && o[i++], done: !o };
1818
>>> }
1919
>>> };
20-
>>> throw new TypeError(s ? "Object not iterable." : "Symbol.iterator is not defined.");
20+
>>> throw new TypeError(s ? "Object is not iterable." : "Symbol.iterator is not defined.");
2121
>>>};
2222
>>>var e_1, _a;
2323
>>>try {

tests/baselines/reference/ES5For-of34.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tests/baselines/reference/ES5For-of34.sourcemap.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ sourceFile:ES5For-of34.ts
1717
>>> return { value: o && o[i++], done: !o };
1818
>>> }
1919
>>> };
20-
>>> throw new TypeError(s ? "Object not iterable." : "Symbol.iterator is not defined.");
20+
>>> throw new TypeError(s ? "Object is not iterable." : "Symbol.iterator is not defined.");
2121
>>>};
2222
>>>var e_1, _a;
2323
>>>function foo() {

tests/baselines/reference/ES5For-of35.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tests/baselines/reference/ES5For-of35.sourcemap.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ sourceFile:ES5For-of35.ts
1717
>>> return { value: o && o[i++], done: !o };
1818
>>> }
1919
>>> };
20-
>>> throw new TypeError(s ? "Object not iterable." : "Symbol.iterator is not defined.");
20+
>>> throw new TypeError(s ? "Object is not iterable." : "Symbol.iterator is not defined.");
2121
>>>};
2222
>>>var e_1, _a;
2323
>>>try {

tests/baselines/reference/ES5For-of36.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tests/baselines/reference/ES5For-of36.sourcemap.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ sourceFile:ES5For-of36.ts
1717
>>> return { value: o && o[i++], done: !o };
1818
>>> }
1919
>>> };
20-
>>> throw new TypeError(s ? "Object not iterable." : "Symbol.iterator is not defined.");
20+
>>> throw new TypeError(s ? "Object is not iterable." : "Symbol.iterator is not defined.");
2121
>>>};
2222
>>>var __read = (this && this.__read) || function (o, n) {
2323
>>> var m = typeof Symbol === "function" && o[Symbol.iterator];

0 commit comments

Comments
 (0)