Report config file parsing diagnostics correctly with tsc --b (microsoft#36520)

* Refactor the test

* Add tests for syntax errors in tsconfig not being reported

* Report config file parsing diagnostics correctly
Fixes microsoft#36515

* Fix errors in existing tests for unintended tsconfig parse errors

* Fix lint

Author: sheetalkamat

src/compiler/tsbuildPublic.ts

@@ -828,7 +828,7 @@ namespace ts {
             if (state.options.verbose) reportStatus(state, Diagnostics.Building_project_0, project);
 
             if (config.fileNames.length === 0) {
-                reportAndStoreErrors(state, projectPath, config.errors);
+                reportAndStoreErrors(state, projectPath, getConfigFileParsingDiagnostics(config));
                 // Nothing to build - must be a solution file, basically
                 buildResult = BuildResultFlags.None;
                 step = Step.QueueReferencingProjects;
@@ -846,7 +846,7 @@ namespace ts {
                 config.options,
                 compilerHost,
                 getOldProgram(state, projectPath, config),
-                config.errors,
+                getConfigFileParsingDiagnostics(config),
                 config.projectReferences
             );
             step++;
@@ -1118,7 +1118,7 @@ namespace ts {
     function needsBuild({ options }: SolutionBuilderState, status: UpToDateStatus, config: ParsedCommandLine) {
         if (status.type !== UpToDateStatusType.OutOfDateWithPrepend || options.force) return true;
         return config.fileNames.length === 0 ||
-            !!config.errors.length ||
+            !!getConfigFileParsingDiagnostics(config).length ||
             !isIncrementalCompilation(config.options);
     }
 
@@ -1172,7 +1172,7 @@ namespace ts {
             verboseReportProjectStatus(state, project, status);
             if (!options.force) {
                 if (status.type === UpToDateStatusType.UpToDate) {
-                    reportAndStoreErrors(state, projectPath, config.errors);
+                    reportAndStoreErrors(state, projectPath, getConfigFileParsingDiagnostics(config));
                     projectPendingBuild.delete(projectPath);
                     // Up to date, skip
                     if (options.dry) {
@@ -1183,7 +1183,7 @@ namespace ts {
                 }
 
                 if (status.type === UpToDateStatusType.UpToDateWithUpstreamTypes) {
-                    reportAndStoreErrors(state, projectPath, config.errors);
+                    reportAndStoreErrors(state, projectPath, getConfigFileParsingDiagnostics(config));
                     return createUpdateOutputFileStampsProject(
                         state,
                         project,
@@ -1195,7 +1195,7 @@ namespace ts {
             }
 
             if (status.type === UpToDateStatusType.UpstreamBlocked) {
-                reportAndStoreErrors(state, projectPath, config.errors);
+                reportAndStoreErrors(state, projectPath, getConfigFileParsingDiagnostics(config));
                 projectPendingBuild.delete(projectPath);
                 if (options.verbose) {
                     reportStatus(
@@ -1211,7 +1211,7 @@ namespace ts {
             }
 
             if (status.type === UpToDateStatusType.ContainerOnly) {
-                reportAndStoreErrors(state, projectPath, config.errors);
+                reportAndStoreErrors(state, projectPath, getConfigFileParsingDiagnostics(config));
                 projectPendingBuild.delete(projectPath);
                 // Do nothing
                 continue;

src/testRunner/tsconfig.json

@@ -107,6 +107,7 @@
         "unittests/services/textChanges.ts",
         "unittests/services/transpile.ts",
         "unittests/tsbuild/amdModulesWithOut.ts",
+        "unittests/tsbuild/configFileErrors.ts",
         "unittests/tsbuild/containerOnlyReferenced.ts",
         "unittests/tsbuild/demo.ts",
         "unittests/tsbuild/emitDeclarationOnly.ts",
@@ -116,7 +117,6 @@
         "unittests/tsbuild/inferredTypeFromTransitiveModule.ts",
         "unittests/tsbuild/javascriptProjectEmit.ts",
         "unittests/tsbuild/lateBoundSymbol.ts",
-        "unittests/tsbuild/missingExtendedFile.ts",
         "unittests/tsbuild/moduleSpecifiers.ts",
         "unittests/tsbuild/noEmitOnError.ts",
         "unittests/tsbuild/outFile.ts",

src/testRunner/unittests/tsbuild/configFileErrors.ts

@@ -0,0 +1,57 @@
+namespace ts {
+    describe("unittests:: tsbuild:: configFileErrors:: when tsconfig extends the missing file", () => {
+        verifyTsc({
+            scenario: "configFileErrors",
+            subScenario: "when tsconfig extends the missing file",
+            fs: () => loadProjectFromDisk("tests/projects/missingExtendedConfig"),
+            commandLineArgs: ["--b", "/src/tsconfig.json"],
+        });
+    });
+
+    describe("unittests:: tsbuild:: configFileErrors:: reports syntax errors in config file", () => {
+        verifyTscIncrementalEdits({
+            scenario: "configFileErrors",
+            subScenario: "reports syntax errors in config file",
+            fs: () => loadProjectFromFiles({
+                "/src/a.ts": "export function foo() { }",
+                "/src/b.ts": "export function bar() { }",
+                "/src/tsconfig.json": Utils.dedent`
+{
+    "compilerOptions": {
+        "composite": true,
+    },
+    "files": [
+        "a.ts"
+        "b.ts"
+    ]
+}`
+            }),
+            commandLineArgs: ["--b", "/src/tsconfig.json"],
+            incrementalScenarios: [
+                {
+                    buildKind: BuildKind.IncrementalDtsUnchanged,
+                    modifyFs: fs => replaceText(fs, "/src/tsconfig.json", ",", `,
+        "declaration": true,`),
+                    subScenario: "reports syntax errors after change to config file"
+                },
+                {
+                    buildKind: BuildKind.IncrementalDtsUnchanged,
+                    modifyFs: fs => appendText(fs, "/src/a.ts", "export function fooBar() { }"),
+                    subScenario: "reports syntax errors after change to ts file"
+                },
+                noChangeRun,
+                {
+                    buildKind: BuildKind.IncrementalDtsChange,
+                    modifyFs: fs => fs.writeFileSync(
+                        "/src/tsconfig.json",
+                        JSON.stringify({
+                            compilerOptions: { composite: true, declaration: true },
+                            files: ["a.ts", "b.ts"]
+                        })
+                    ),
+                    subScenario: "builds after fixing config file errors"
+                },
+            ]
+        });
+    });
+}

src/testRunner/unittests/tsbuild/containerOnlyReferenced.ts

@@ -1,18 +1,9 @@
 namespace ts {
     describe("unittests:: tsbuild:: when containerOnly project is referenced", () => {
-        let projFs: vfs.FileSystem;
-        before(() => {
-            projFs = loadProjectFromDisk("tests/projects/containerOnlyReferenced");
-        });
-
-        after(() => {
-            projFs = undefined!; // Release the contents
-        });
-
         verifyTscIncrementalEdits({
             scenario: "containerOnlyReferenced",
             subScenario: "verify that subsequent builds after initial build doesnt build anything",
-            fs: () => projFs,
+            fs: () => loadProjectFromDisk("tests/projects/containerOnlyReferenced"),
             commandLineArgs: ["--b", "/src", "--verbose"],
             incrementalScenarios: [noChangeRun]
         });

src/testRunner/unittests/tsbuild/javascriptProjectEmit.ts

@@ -212,7 +212,7 @@ namespace ts {
                     {
                         "extends": "../tsconfig.base.json",
                         "compilerOptions": {
-                            "outDir": null
+                            "outDir": null,
                             "composite": true
                         },
                         "include": ["index.ts", "obj.json"]

src/testRunner/unittests/tsbuild/lateBoundSymbol.ts

@@ -1,16 +1,8 @@
 namespace ts {
     describe("unittests:: tsbuild:: lateBoundSymbol:: interface is merged and contains late bound member", () => {
-        let projFs: vfs.FileSystem;
-        before(() => {
-            projFs = loadProjectFromDisk("tests/projects/lateBoundSymbol");
-        });
-        after(() => {
-            projFs = undefined!; // Release the contents
-        });
-
         verifyTscIncrementalEdits({
             subScenario: "interface is merged and contains late bound member",
-            fs: () => projFs,
+            fs: () => loadProjectFromDisk("tests/projects/lateBoundSymbol"),
             scenario: "lateBoundSymbol",
             commandLineArgs: ["--b", "/src/tsconfig.json", "--verbose"],
             incrementalScenarios: [{

src/testRunner/unittests/tsbuild/missingExtendedFile.ts

@@ -1,16 +1,9 @@
 namespace ts {
     describe("unittests:: tsbuild - with noEmitOnError", () => {
-        let projFs: vfs.FileSystem;
-        before(() => {
-            projFs = loadProjectFromDisk("tests/projects/noEmitOnError");
-        });
-        after(() => {
-            projFs = undefined!;
-        });
         verifyTsc({
             scenario: "noEmitOnError",
             subScenario: "has empty files diagnostic when files is empty and no references are provided",
-            fs: () => projFs,
+            fs: () => loadProjectFromDisk("tests/projects/noEmitOnError"),
             commandLineArgs: ["--b", "/src/tsconfig.json"],
         });
     });

src/testRunner/unittests/tsbuild/noEmitOnError.ts

@@ -453,7 +453,7 @@ namespace ts {
 
                 function stripInternalOfThird(fs: vfs.FileSystem) {
                     replaceText(fs, sources[project.third][source.config], `"declaration": true,`, `"declaration": true,
-"stripInternal": true`);
+    "stripInternal": true,`);
                 }
 
                 function stripInternalScenario(fs: vfs.FileSystem, removeCommentsDisabled?: boolean, jsDocStyle?: boolean) {

src/testRunner/unittests/tsbuild/outFile.ts

@@ -71,19 +71,10 @@ export default hello.hello`);
     });
 
     describe("unittests:: tsbuild:: with resolveJsonModule option on project importJsonFromProjectReference", () => {
-        let projFs: vfs.FileSystem;
-        before(() => {
-            projFs = loadProjectFromDisk("tests/projects/importJsonFromProjectReference");
-        });
-
-        after(() => {
-            projFs = undefined!; // Release the contents
-        });
-
         verifyTscIncrementalEdits({
             scenario: "resolveJsonModule",
             subScenario: "importing json module from project reference",
-            fs: () => projFs,
+            fs: () => loadProjectFromDisk("tests/projects/importJsonFromProjectReference"),
             commandLineArgs: ["--b", "src/tsconfig.json", "--verbose"],
             incrementalScenarios: [noChangeRun]
         });