Improve error message and update baselines

Author: sandersn

src/compiler/checker.ts

@@ -21120,13 +21120,20 @@ namespace ts {
          * @param signature a candidate signature we are trying whether it is a call signature
          * @param relation a relationship to check parameter and argument type
          */
-        function checkApplicableSignatureForJsxOpeningLikeElement(node: JsxOpeningLikeElement, signature: Signature, relation: Map<RelationComparisonResult>, checkMode: CheckMode, reportErrors: boolean) {
+        function checkApplicableSignatureForJsxOpeningLikeElement(
+            node: JsxOpeningLikeElement,
+            signature: Signature,
+            relation: Map<RelationComparisonResult>,
+            checkMode: CheckMode,
+            reportErrors: boolean,
+            containingMessageChain: (() => DiagnosticMessageChain | undefined) | undefined,
+        ) {
             // Stateless function components can have maximum of three arguments: "props", "context", and "updater".
             // However "context" and "updater" are implicit and can't be specify by users. Only the first parameter, props,
             // can be specified by users through attributes property.
             const paramType = getEffectiveFirstArgumentForJsxSignature(signature, node);
             const attributesType = checkExpressionWithContextualType(node.attributes, paramType, /*inferenceContext*/ undefined, checkMode);
-            return checkTypeRelatedToAndOptionallyElaborate(attributesType, paramType, relation, reportErrors ? node.tagName : undefined, node.attributes, undefined, undefined, /*breakdown*/ true);
+            return checkTypeRelatedToAndOptionallyElaborate(attributesType, paramType, relation, reportErrors ? node.tagName : undefined, node.attributes, undefined, containingMessageChain, /*breakdown*/ true);
         }
 
         function getSignatureApplicabilityError(
@@ -21139,8 +21146,7 @@ namespace ts {
             containingMessageChain: (() => DiagnosticMessageChain | undefined) | undefined,
         ) {
             if (isJsxOpeningLikeElement(node)) {
-                // TODO: Maybe containingMessageChain too?
-                return checkApplicableSignatureForJsxOpeningLikeElement(node, signature, relation, checkMode, reportErrors);
+                return checkApplicableSignatureForJsxOpeningLikeElement(node, signature, relation, checkMode, reportErrors, containingMessageChain);
             }
             const thisType = getThisTypeOfSignature(signature);
             if (thisType && thisType !== voidType && node.kind !== SyntaxKind.NewExpression) {
@@ -21151,7 +21157,7 @@ namespace ts {
                 const thisArgumentType = thisArgumentNode ? checkExpression(thisArgumentNode) : voidType;
                 const errorNode = reportErrors ? (thisArgumentNode || node) : undefined;
                 const headMessage = Diagnostics.The_this_context_of_type_0_is_not_assignable_to_method_s_this_of_type_1;
-                const r = checkTypeRelatedTo(thisArgumentType, thisType, relation, errorNode, headMessage, undefined, undefined, /*breakdown*/ true);
+                const r = checkTypeRelatedTo(thisArgumentType, thisType, relation, errorNode, headMessage, containingMessageChain, undefined, /*breakdown*/ true);
                 if (r) {
                     return r;
                 }
@@ -21512,7 +21518,7 @@ namespace ts {
                         let chain: DiagnosticMessageChain | undefined = undefined;
                         if (candidatesForArgumentError.length > 3) {
                             chain = chainDiagnosticMessages(chain, Diagnostics.The_last_overload_gave_the_following_error);
-                            chain = chainDiagnosticMessages(chain, Diagnostics.Failed_to_find_a_suitable_overload_for_this_call_from_0_overloads, candidatesForArgumentError.length);
+                            chain = chainDiagnosticMessages(chain, Diagnostics.No_suitable_overload_for_this_call);
                         }
                         const r = getSignatureApplicabilityError(node, args, last, assignableRelation, CheckMode.Normal, /*reportErrors*/ true, () => chain);
                         Debug.assert(!!r && !!r[0], "No error for last signature");
@@ -21522,15 +21528,17 @@ namespace ts {
                     }
                     else {
                         const related: DiagnosticRelatedInformation[] = [];
+                        let i = 0;
                         for (const c of candidatesForArgumentError) {
-                            const chain = chainDiagnosticMessages(undefined, Diagnostics.Overload_0_gave_the_following_error, signatureToString(c));
+                            i++;
+                            const chain = chainDiagnosticMessages(undefined, Diagnostics.Overload_0_of_1_2_gave_the_following_error, i, candidates.length, signatureToString(c));
                             const r = getSignatureApplicabilityError(node, args, c, assignableRelation, CheckMode.Normal, /*reportErrors*/ true, () => chain);
                             Debug.assert(!!r && !!r[0], "No error for signature (1)");
                             if (r) {
                                 related.push(createDiagnosticForNodeFromMessageChain(...r));
                             }
                         }
-                        diagnostics.add(createDiagnosticForNodeFromMessageChain(node, chainDiagnosticMessages(undefined, Diagnostics.Failed_to_find_a_suitable_overload_for_this_call_from_0_overloads, candidatesForArgumentError.length), related));
+                        diagnostics.add(createDiagnosticForNodeFromMessageChain(node, chainDiagnosticMessages(undefined, Diagnostics.No_suitable_overload_for_this_call), related));
                     }
                 }
                 else if (candidateForArgumentArityError) {

src/compiler/diagnosticMessages.json

@@ -2621,15 +2621,15 @@
         "category": "Error",
         "code": 2754
     },
-    "Failed to find a suitable overload for this call from {0} overloads.": {
+    "No suitable overload for this call.": {
         "category": "Error",
         "code": 2755
     },
     "The last overload gave the following error.": {
         "category": "Error",
         "code": 2756
     },
-    "Overload '{0}' gave the following error.": {
+    "Overload {0} of {1}, '{2}', gave the following error.": {
         "category": "Error",
         "code": 2757
     },

tests/baselines/reference/bigintWithLib.errors.txt

@@ -1,9 +1,7 @@
 tests/cases/compiler/bigintWithLib.ts(4,1): error TS2350: Only a void function can be called with the 'new' keyword.
-tests/cases/compiler/bigintWithLib.ts(16,33): error TS2345: Argument of type 'number[]' is not assignable to parameter of type 'ArrayBuffer | SharedArrayBuffer'.
-  Type 'number[]' is missing the following properties from type 'SharedArrayBuffer': byteLength, [Symbol.species], [Symbol.toStringTag]
+tests/cases/compiler/bigintWithLib.ts(16,15): error TS2755: No suitable overload for this call.
 tests/cases/compiler/bigintWithLib.ts(21,13): error TS2540: Cannot assign to 'length' because it is a read-only property.
-tests/cases/compiler/bigintWithLib.ts(28,35): error TS2345: Argument of type 'number[]' is not assignable to parameter of type 'ArrayBuffer | SharedArrayBuffer'.
-  Type 'number[]' is not assignable to type 'SharedArrayBuffer'.
+tests/cases/compiler/bigintWithLib.ts(28,16): error TS2755: No suitable overload for this call.
 tests/cases/compiler/bigintWithLib.ts(33,13): error TS2540: Cannot assign to 'length' because it is a read-only property.
 tests/cases/compiler/bigintWithLib.ts(40,25): error TS2345: Argument of type '-1' is not assignable to parameter of type 'bigint'.
 tests/cases/compiler/bigintWithLib.ts(43,26): error TS2345: Argument of type '123' is not assignable to parameter of type 'bigint'.
@@ -28,9 +26,22 @@ tests/cases/compiler/bigintWithLib.ts(43,26): error TS2345: Argument of type '12
     bigIntArray = new BigInt64Array(10);
     bigIntArray = new BigInt64Array([1n, 2n, 3n]);
     bigIntArray = new BigInt64Array([1, 2, 3]); // should error
-                                    ~~~~~~~~~
-!!! error TS2345: Argument of type 'number[]' is not assignable to parameter of type 'ArrayBuffer | SharedArrayBuffer'.
-!!! error TS2345:   Type 'number[]' is missing the following properties from type 'SharedArrayBuffer': byteLength, [Symbol.species], [Symbol.toStringTag]
+                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+!!! error TS2755: No suitable overload for this call.
+!!! related TS2757 tests/cases/compiler/bigintWithLib.ts:16:33: Overload 1 of 3, '(length?: number): BigInt64Array', gave the following error.
+  Argument of type 'number[]' is not assignable to parameter of type 'number'.
+!!! related TS2757 tests/cases/compiler/bigintWithLib.ts:16:33: Overload 2 of 3, '(array: Iterable<bigint>): BigInt64Array', gave the following error.
+  Argument of type 'number[]' is not assignable to parameter of type 'Iterable<bigint>'.
+    Types of property '[Symbol.iterator]' are incompatible.
+      Type '() => IterableIterator<number>' is not assignable to type '() => Iterator<bigint>'.
+        Type 'IterableIterator<number>' is not assignable to type 'Iterator<bigint>'.
+          Types of property 'next' are incompatible.
+            Type '(value?: any) => IteratorResult<number>' is not assignable to type '(value?: any) => IteratorResult<bigint>'.
+              Type 'IteratorResult<number>' is not assignable to type 'IteratorResult<bigint>'.
+                Type 'number' is not assignable to type 'bigint'.
+!!! related TS2757 tests/cases/compiler/bigintWithLib.ts:16:33: Overload 3 of 3, '(buffer: ArrayBuffer | SharedArrayBuffer, byteOffset?: number, length?: number): BigInt64Array', gave the following error.
+  Argument of type 'number[]' is not assignable to parameter of type 'ArrayBuffer | SharedArrayBuffer'.
+    Type 'number[]' is missing the following properties from type 'SharedArrayBuffer': byteLength, [Symbol.species], [Symbol.toStringTag]
     bigIntArray = new BigInt64Array(new ArrayBuffer(80));
     bigIntArray = new BigInt64Array(new ArrayBuffer(80), 8);
     bigIntArray = new BigInt64Array(new ArrayBuffer(80), 8, 3);
@@ -45,9 +56,15 @@ tests/cases/compiler/bigintWithLib.ts(43,26): error TS2345: Argument of type '12
     bigUintArray = new BigUint64Array(10);
     bigUintArray = new BigUint64Array([1n, 2n, 3n]);
     bigUintArray = new BigUint64Array([1, 2, 3]); // should error
-                                      ~~~~~~~~~
-!!! error TS2345: Argument of type 'number[]' is not assignable to parameter of type 'ArrayBuffer | SharedArrayBuffer'.
-!!! error TS2345:   Type 'number[]' is not assignable to type 'SharedArrayBuffer'.
+                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+!!! error TS2755: No suitable overload for this call.
+!!! related TS2757 tests/cases/compiler/bigintWithLib.ts:28:35: Overload 1 of 3, '(length?: number): BigUint64Array', gave the following error.
+  Argument of type 'number[]' is not assignable to parameter of type 'number'.
+!!! related TS2757 tests/cases/compiler/bigintWithLib.ts:28:35: Overload 2 of 3, '(array: Iterable<bigint>): BigUint64Array', gave the following error.
+  Argument of type 'number[]' is not assignable to parameter of type 'Iterable<bigint>'.
+!!! related TS2757 tests/cases/compiler/bigintWithLib.ts:28:35: Overload 3 of 3, '(buffer: ArrayBuffer | SharedArrayBuffer, byteOffset?: number, length?: number): BigUint64Array', gave the following error.
+  Argument of type 'number[]' is not assignable to parameter of type 'ArrayBuffer | SharedArrayBuffer'.
+    Type 'number[]' is not assignable to type 'SharedArrayBuffer'.
     bigUintArray = new BigUint64Array(new ArrayBuffer(80));
     bigUintArray = new BigUint64Array(new ArrayBuffer(80), 8);
     bigUintArray = new BigUint64Array(new ArrayBuffer(80), 8, 3);

tests/baselines/reference/checkJsxChildrenCanBeTupleType.errors.txt

@@ -1,8 +1,4 @@
-tests/cases/conformance/jsx/checkJsxChildrenCanBeTupleType.tsx(17,18): error TS2322: Type '{ children: [Element, Element, Element]; }' is not assignable to type 'Readonly<ResizablePanelProps>'.
-  Types of property 'children' are incompatible.
-    Type '[Element, Element, Element]' is not assignable to type '[ReactNode, ReactNode]'.
-      Types of property 'length' are incompatible.
-        Type '3' is not assignable to type '2'.
+tests/cases/conformance/jsx/checkJsxChildrenCanBeTupleType.tsx(17,17): error TS2755: No suitable overload for this call.
 
 
 ==== tests/cases/conformance/jsx/checkJsxChildrenCanBeTupleType.tsx (1 errors) ====
@@ -23,12 +19,18 @@ tests/cases/conformance/jsx/checkJsxChildrenCanBeTupleType.tsx(17,18): error TS2
     </ResizablePanel>
 
     const testErr = <ResizablePanel>
-                     ~~~~~~~~~~~~~~
-!!! error TS2322: Type '{ children: [Element, Element, Element]; }' is not assignable to type 'Readonly<ResizablePanelProps>'.
-!!! error TS2322:   Types of property 'children' are incompatible.
-!!! error TS2322:     Type '[Element, Element, Element]' is not assignable to type '[ReactNode, ReactNode]'.
-!!! error TS2322:       Types of property 'length' are incompatible.
-!!! error TS2322:         Type '3' is not assignable to type '2'.
+                    ~~~~~~~~~~~~~~~~
+!!! error TS2755: No suitable overload for this call.
+!!! related TS2757 tests/cases/conformance/jsx/checkJsxChildrenCanBeTupleType.tsx:17:18: Overload 1 of 2, '(props: Readonly<ResizablePanelProps>): ResizablePanel', gave the following error.
+  Type '{ children: [Element, Element, Element]; }' is not assignable to type 'Readonly<ResizablePanelProps>'.
+    Types of property 'children' are incompatible.
+      Type '[Element, Element, Element]' is not assignable to type '[ReactNode, ReactNode]'.
+        Types of property 'length' are incompatible.
+          Type '3' is not assignable to type '2'.
+!!! related TS2757 tests/cases/conformance/jsx/checkJsxChildrenCanBeTupleType.tsx:17:18: Overload 2 of 2, '(props: ResizablePanelProps, context?: any): ResizablePanel', gave the following error.
+  Type '{ children: [Element, Element, Element]; }' is not assignable to type 'Readonly<ResizablePanelProps>'.
+    Types of property 'children' are incompatible.
+      Type '[Element, Element, Element]' is not assignable to type '[ReactNode, ReactNode]'.
       <div />
       <div />
       <div />

tests/baselines/reference/constructorOverloads1.errors.txt

@@ -2,8 +2,8 @@ tests/cases/compiler/constructorOverloads1.ts(2,5): error TS2392: Multiple const
 tests/cases/compiler/constructorOverloads1.ts(3,5): error TS2392: Multiple constructor implementations are not allowed.
 tests/cases/compiler/constructorOverloads1.ts(4,5): error TS2392: Multiple constructor implementations are not allowed.
 tests/cases/compiler/constructorOverloads1.ts(7,5): error TS2392: Multiple constructor implementations are not allowed.
-tests/cases/compiler/constructorOverloads1.ts(16,18): error TS2345: Argument of type 'Foo' is not assignable to parameter of type 'number'.
-tests/cases/compiler/constructorOverloads1.ts(17,18): error TS2345: Argument of type 'any[]' is not assignable to parameter of type 'number'.
+tests/cases/compiler/constructorOverloads1.ts(16,10): error TS2755: No suitable overload for this call.
+tests/cases/compiler/constructorOverloads1.ts(17,10): error TS2755: No suitable overload for this call.
 
 
 ==== tests/cases/compiler/constructorOverloads1.ts (6 errors) ====
@@ -35,11 +35,19 @@ tests/cases/compiler/constructorOverloads1.ts(17,18): error TS2345: Argument of
     var f1 = new Foo("hey");
     var f2 = new Foo(0);
     var f3 = new Foo(f1);
-                     ~~
-!!! error TS2345: Argument of type 'Foo' is not assignable to parameter of type 'number'.
+             ~~~~~~~~~~~
+!!! error TS2755: No suitable overload for this call.
+!!! related TS2757 tests/cases/compiler/constructorOverloads1.ts:16:18: Overload 1 of 2, '(s: string): Foo', gave the following error.
+  Argument of type 'Foo' is not assignable to parameter of type 'string'.
+!!! related TS2757 tests/cases/compiler/constructorOverloads1.ts:16:18: Overload 2 of 2, '(n: number): Foo', gave the following error.
+  Argument of type 'Foo' is not assignable to parameter of type 'number'.
     var f4 = new Foo([f1,f2,f3]);
-                     ~~~~~~~~~~
-!!! error TS2345: Argument of type 'any[]' is not assignable to parameter of type 'number'.
+             ~~~~~~~~~~~~~~~~~~~
+!!! error TS2755: No suitable overload for this call.
+!!! related TS2757 tests/cases/compiler/constructorOverloads1.ts:17:18: Overload 1 of 2, '(s: string): Foo', gave the following error.
+  Argument of type 'any[]' is not assignable to parameter of type 'string'.
+!!! related TS2757 tests/cases/compiler/constructorOverloads1.ts:17:18: Overload 2 of 2, '(n: number): Foo', gave the following error.
+  Argument of type 'any[]' is not assignable to parameter of type 'number'.
 
     f1.bar1();
     f1.bar2();