Properly check if a codefix is needed

rFlorian · rFlorian · commit 94118b64c5bf · 2018-11-15T23:05:14.000+01:00
diff --git a/src/services/codefixes/addMissingConstInForLoop.ts b/src/services/codefixes/addMissingConstInForLoop.ts
@@ -6,7 +6,7 @@ namespace ts.codefix {
         errorCodes,
         getCodeActions: (context) => {
             const changes = textChanges.ChangeTracker.with(context, t => makeChange(t, context.sourceFile, context.span.start));
-            if (changes) {
+            if (changes.length > 0) {
                 return [createCodeFixAction(fixId, changes, Diagnostics.Add_const_to_unresolved_variable, fixId, Diagnostics.Add_const_to_all_unresolved_variables)];
             }
         },

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@ namespace ts.codefix {`
`6`	`6`	`errorCodes,`
`7`	`7`	`getCodeActions: (context) => {`
`8`	`8`	`const changes = textChanges.ChangeTracker.with(context, t => makeChange(t, context.sourceFile, context.span.start));`
`9`		`- if (changes) {`
	`9`	`+ if (changes.length > 0) {`
`10`	`10`	`return [createCodeFixAction(fixId, changes, Diagnostics.Add_const_to_unresolved_variable, fixId, Diagnostics.Add_const_to_all_unresolved_variables)];`
`11`	`11`	`}`
`12`	`12`	`},`