Remove over-eager check of AccessFlags.Writing in getIndexedAccessType

ahejlsberg · ahejlsberg · commit 9c401b4dbbba · 2019-04-28T13:56:11.000-07:00
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -10080,7 +10080,7 @@ namespace ts {
                         error(indexNode, Diagnostics.Type_0_cannot_be_used_as_an_index_type, typeToString(indexType));
                         return indexInfo.type;
                     }
-                    if (indexInfo.isReadonly && (accessFlags & AccessFlags.Writing || accessExpression && (isAssignmentTarget(accessExpression) || isDeleteTarget(accessExpression)))) {
+                    if (indexInfo.isReadonly && accessExpression && (isAssignmentTarget(accessExpression) || isDeleteTarget(accessExpression))) {
                         if (accessExpression) {
                             error(accessExpression, Diagnostics.Index_signature_in_type_0_only_permits_reading, typeToString(objectType));
                             return indexInfo.type;

Original file line number	Diff line number	Diff line change
`@@ -10080,7 +10080,7 @@ namespace ts {`
`10080`	`10080`	`error(indexNode, Diagnostics.Type_0_cannot_be_used_as_an_index_type, typeToString(indexType));`
`10081`	`10081`	`return indexInfo.type;`
`10082`	`10082`	`}`
`10083`		`- if (indexInfo.isReadonly && (accessFlags & AccessFlags.Writing \|\| accessExpression && (isAssignmentTarget(accessExpression) \|\| isDeleteTarget(accessExpression)))) {`
	`10083`	`+ if (indexInfo.isReadonly && accessExpression && (isAssignmentTarget(accessExpression) \|\| isDeleteTarget(accessExpression))) {`
`10084`	`10084`	`if (accessExpression) {`
`10085`	`10085`	`error(accessExpression, Diagnostics.Index_signature_in_type_0_only_permits_reading, typeToString(objectType));`
`10086`	`10086`	`return indexInfo.type;`