Remove unnecessary internal tags, handle bad input

Ben Lichtman · Ben Lichtman · commit 9f1e389441bb · 2019-12-18T10:44:40.000-08:00
diff --git a/src/server/scriptInfo.ts b/src/server/scriptInfo.ts
@@ -622,6 +622,7 @@ namespace ts.server {
         }
 
         positionToLineOffset(position: number): protocol.Location {
+            failIfInvalidPosition(position);
             const location = this.textStorage.positionToLineOffset(position);
             failIfInvalidLocation(location);
             return location;
@@ -645,7 +646,11 @@ namespace ts.server {
         }
     }
 
-    /*@internal*/
+    function failIfInvalidPosition(position: number) {
+        Debug.assert(typeof position === "number", `Expected position ${position} to be a number.`);
+        Debug.assert(position >= 0, `Expected position to be non-negative.`);
+    }
+
     function failIfInvalidLocation(location: protocol.Location) {
         Debug.assert(typeof location.line === "number", `Expected line ${location.line} to be a number.`);
         Debug.assert(typeof location.offset === "number", `Expected offset ${location.offset} to be a number.`);

Original file line number	Diff line number	Diff line change
`@@ -622,6 +622,7 @@ namespace ts.server {`
`622`	`622`	`}`
`623`	`623`
`624`	`624`	`positionToLineOffset(position: number): protocol.Location {`
	`625`	`+ failIfInvalidPosition(position);`
`625`	`626`	`const location = this.textStorage.positionToLineOffset(position);`
`626`	`627`	`failIfInvalidLocation(location);`
`627`	`628`	`return location;`
`@@ -645,7 +646,11 @@ namespace ts.server {`
`645`	`646`	`}`
`646`	`647`	`}`
`647`	`648`
`648`		`- /@internal/`
	`649`	`+ function failIfInvalidPosition(position: number) {`
	`650`	+ Debug.assert(typeof position === "number", `Expected position ${position} to be a number.`);
	`651`	+ Debug.assert(position >= 0, `Expected position to be non-negative.`);
	`652`	`+ }`
	`653`	`+`
`649`	`654`	`function failIfInvalidLocation(location: protocol.Location) {`
`650`	`655`	Debug.assert(typeof location.line === "number", `Expected line ${location.line} to be a number.`);
`651`	`656`	Debug.assert(typeof location.offset === "number", `Expected offset ${location.offset} to be a number.`);