Fix arity error sometimes reaching out of bounds of the arguments actually present

andrewbranch · andrewbranch · commit da3fdd11c163 · 2019-04-04T11:47:26.000-07:00
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -20600,7 +20600,7 @@ namespace ts {
                 spanArray = createNodeArray(args);
                 if (hasSpreadArgument && argCount) {
                     const nextArg = elementAt(args, getSpreadArgumentIndex(args) + 1) || undefined;
-                    spanArray = createNodeArray(args.slice(max > argCount && nextArg ? args.indexOf(nextArg) : max));
+                    spanArray = createNodeArray(args.slice(max > argCount && nextArg ? args.indexOf(nextArg) : Math.min(max, args.length - 1)));
                 }
             }
             else {

Original file line number	Diff line number	Diff line change
`@@ -20600,7 +20600,7 @@ namespace ts {`
`20600`	`20600`	`spanArray = createNodeArray(args);`
`20601`	`20601`	`if (hasSpreadArgument && argCount) {`
`20602`	`20602`	`const nextArg = elementAt(args, getSpreadArgumentIndex(args) + 1) \|\| undefined;`
`20603`		`- spanArray = createNodeArray(args.slice(max > argCount && nextArg ? args.indexOf(nextArg) : max));`
	`20603`	`+ spanArray = createNodeArray(args.slice(max > argCount && nextArg ? args.indexOf(nextArg) : Math.min(max, args.length - 1)));`
`20604`	`20604`	`}`
`20605`	`20605`	`}`
`20606`	`20606`	`else {`