Don't include headers within extern "C"

Including C headers inside of extern "C" breaks use from C++. Hoist
the includes of standard C headers above the block so we don't try
to mangle the stdlib.

See https://gitlab.freedesktop.org/pipewire/pipewire/-/merge_requests/2377 in
PipeWire where they bundle some JACK headers, so came across this.

Author: thesamesam

common/driver_interface.h

@@ -21,17 +21,16 @@
 #ifndef __jack_driver_interface_h__
 #define __jack_driver_interface_h__
 
-#ifdef __cplusplus
-extern "C"
-{
-#endif
-
 #include <limits.h>
 #include "jslist.h"
 
 #include "JackCompilerDeps.h"
 #include "JackSystemDeps.h"
 
+#ifdef __cplusplus
+extern "C" {
+#endif
+
 #define JACK_DRIVER_NAME_MAX          15
 #define JACK_DRIVER_PARAM_NAME_MAX    15
 #define JACK_DRIVER_PARAM_STRING_MAX  127

common/jack/intclient.h

@@ -20,13 +20,13 @@
 #ifndef __jack_intclient_h__
 #define __jack_intclient_h__
 
+#include <jack/types.h>
+
 #ifdef __cplusplus
 extern "C"
 {
 #endif
 
-#include <jack/types.h>
-
 /**
  * Get an internal client's name.  This is useful when @ref
  * JackUseExactName was not specified on jack_internal_client_load()

common/jack/jack.h

@@ -21,15 +21,16 @@
 #ifndef __jack_h__
 #define __jack_h__
 
+#include <jack/systemdeps.h>
+#include <jack/types.h>
+#include <jack/transport.h>
+#include <jack/weakmacros.h>
+
 #ifdef __cplusplus
 extern "C"
 {
 #endif
 
-#include <jack/systemdeps.h>
-#include <jack/types.h>
-#include <jack/transport.h>
-
 /**
  * Note: More documentation can be found in jack/types.h.
  */
@@ -46,8 +47,6 @@ extern "C"
      * <jack/weakjack.h> before jack.h.
      *************************************************************/
 
-#include <jack/weakmacros.h>
-
 /**
  * Call this function to get version of the JACK, in form of several numbers
  *

common/jack/midiport.h

@@ -21,14 +21,13 @@
 #ifndef __JACK_MIDIPORT_H
 #define __JACK_MIDIPORT_H
 
-#ifdef __cplusplus
-extern "C" {
-#endif
-
 #include <jack/weakmacros.h>
 #include <jack/types.h>
 #include <stdlib.h>
 
+#ifdef __cplusplus
+extern "C" {
+#endif
 
 /** Type for raw event data contained in @ref jack_midi_event_t. */
 typedef unsigned char jack_midi_data_t;

common/jack/net.h

@@ -20,15 +20,14 @@
 #ifndef __net_h__
 #define __net_h__
 
-#ifdef __cplusplus
-extern "C"
-{
-#endif
-
 #include <jack/systemdeps.h>
 #include <jack/types.h>
 #include <jack/weakmacros.h>
 
+#ifdef __cplusplus
+extern "C" {
+#endif
+
 #define DEFAULT_MULTICAST_IP    "225.3.19.154"
 #define DEFAULT_PORT            19000
 #define DEFAULT_MTU             1500

common/jack/ringbuffer.h

@@ -21,13 +21,12 @@
 #ifndef _RINGBUFFER_H
 #define _RINGBUFFER_H
 
+#include <sys/types.h>
+
 #ifdef __cplusplus
-extern "C"
-{
+extern "C" {
 #endif
 
-#include <sys/types.h>
-
 /** @file ringbuffer.h
  *
  * A set of library functions to make lock-free ringbuffers available

common/jack/session.h

@@ -21,13 +21,13 @@
 #ifndef __jack_session_h__
 #define __jack_session_h__
 
+#include <jack/types.h>
+#include <jack/weakmacros.h>
+
 #ifdef __cplusplus
 extern "C" {
 #endif
 
-#include <jack/types.h>
-#include <jack/weakmacros.h>
-
 /**
  * @defgroup SessionClientFunctions Session API for clients.
  *

common/jack/statistics.h

@@ -21,13 +21,12 @@
 #ifndef __statistics_h__
 #define __statistics_h__
 
+#include <jack/types.h>
+
 #ifdef __cplusplus
-extern "C"
-{
+extern "C" {
 #endif
 
-#include <jack/types.h>
-
 /**
  * @return the maximum delay reported by the backend since
  * startup or reset.  When compared to the period size in usecs, this

common/jack/thread.h

@@ -20,14 +20,14 @@
 #ifndef __jack_thread_h__
 #define __jack_thread_h__
 
+#include <jack/systemdeps.h>
+#include <jack/weakmacros.h>
+
 #ifdef __cplusplus
 extern "C"
 {
 #endif
 
-#include <jack/systemdeps.h>
-#include <jack/weakmacros.h>
-
 /* use 512KB stack per thread - the default is way too high to be feasible
  * with mlockall() on many systems */
 #define THREAD_STACK 524288

common/jack/transport.h

@@ -21,13 +21,13 @@
 #ifndef __jack_transport_h__
 #define __jack_transport_h__
 
+#include <jack/types.h>
+#include <jack/weakmacros.h>
+
 #ifdef __cplusplus
 extern "C" {
 #endif
 
-#include <jack/types.h>
-#include <jack/weakmacros.h>
-
 /**
  * @defgroup TransportControl Transport and Timebase control
  * @{