Merge pull request #1 from jackdevey/more-customisation

Add more customisation

Author: jackdevey

CodeView/src/main/java/me/jackdevey/libraries/codeview/CodeView.kt

@@ -6,24 +6,45 @@ import android.util.AttributeSet
 import androidx.recyclerview.widget.LinearLayoutManager
 import androidx.recyclerview.widget.RecyclerView
 
+/**
+ * The main CodeView element
+ */
 class CodeView : RecyclerView {
 
     constructor(context: Context) : super(context)
     constructor(context: Context, attrs: AttributeSet?) : super(context, attrs)
     constructor(context: Context, attrs: AttributeSet?, defStyle: Int) : super(context, attrs, defStyle)
 
+    /**
+     * The font size of the text
+     */
     var fontSize: Float = 14f
+
+    /**
+     * The code to display on the view
+     */
     var code: String = "No code provided"
 
+    /**
+     * Number each line
+     */
+    var numberLines: Boolean = true
+
+    /**
+     * Show all the changes made
+     */
     fun show() {
         val data : MutableList<Line> = mutableListOf()
         for ((i, line) in code.lines().withIndex()) {
             data.add(Line(i, line))
         }
-        this.adapter = LineAdapter(data, fontSize)
+        this.adapter = LineAdapter(data, fontSize, numberLines)
         this.layoutManager = LinearLayoutManager(context)
     }
 
+    /**
+     * Draw the element
+     */
     override fun onDraw(canvas: Canvas) {
         super.onDraw(canvas)
     }

CodeView/src/main/java/me/jackdevey/libraries/codeview/LineAdapter.kt

@@ -10,7 +10,8 @@ import org.bandev.libraries.databinding.LineBinding
 class LineAdapter(
 
     private val lines: MutableList<Line>,
-    private val fontSize: Float
+    private val fontSize: Float,
+    private val numberLines: Boolean
 
 ) : RecyclerView.Adapter<LineAdapter.ViewHolder>() {
 
@@ -28,10 +29,12 @@ class LineAdapter(
             text = currentItem.lineText
             textSize = fontSize
         }
-        with(holder.lineNumber) {
-            text = currentItem.lineNumber.toString().padStart(3, '0')
-            textSize = fontSize
-        }
+        if(numberLines) {
+            with(holder.lineNumber) {
+                text = currentItem.lineNumber.toString().padStart(3, '0')
+                textSize = fontSize
+            }
+        }else holder.lineNumber.visibility = View.INVISIBLE
     }
 
     override fun getItemCount(): Int = lines.size

README.md

@@ -44,7 +44,7 @@ You can customise the CodeView to make sure that it fits with the theme of your
 |----------|-----------|-------------|---------|--------|
 | code | String | The code to display on the view | "No code provided" | ✔ |
 | fontSize | Float | The font size of the text | 14f | ✔ |
-| numberLines | Boolean | Number each line | true | ❌ |
+| numberLines | Boolean | Number each line | true | ✔ |
 | backgroundColour | Color | The colour of the background | GREY | ❌ |