Fix string-append-and-string-join-to-string-join (#439)

Author: jackfirth

default-recommendations/string-shortcuts-test.rkt

@@ -44,6 +44,11 @@ test: "string-append around string-join refactorable to string-join with keyword
 - (string-join (list "fox" "hen" "dog") #:before-first "The " #:after-last " jumped")
 
 
+test: "string-append before string-join with sep refactorable to string-join with #:before-first"
+- (string-append "The " (string-join (list "fox" "hen" "dog") ", "))
+- (string-join (list "fox" "hen" "dog") ", " #:before-first "The ")
+
+
 test:
 "multiline string-append around string-join refactorable to multiline string-join with keyword\
  arguments"

default-recommendations/string-shortcuts.rkt

@@ -50,29 +50,23 @@
    (~@ . after)))
 
 
-(define-syntax-class keywordless-string-join-call
-  #:attributes ([original 1])
+(define-splicing-syntax-class keywordless-string-join-call
   #:literals (string-join)
-
-  (pattern ((~and id string-join) strs)
-    #:with (original ...) #'(id strs))
-
-  (pattern ((~and id string-join) strs sep)
-    #:with (original ...) #'(id sep)))
+  (pattern (~seq string-join strs (~optional sep))))
 
 
 (define-syntax-class string-append-and-string-join-expression
   #:attributes (refactored)
   #:literals (string-append)
 
-  (pattern (string-append before join-call:keywordless-string-join-call)
-    #:with refactored #'(join-call.original ... #:before-first before))
+  (pattern (string-append before (join-call:keywordless-string-join-call))
+    #:with refactored #'((~@ . join-call) #:before-first before))
 
-  (pattern (string-append join-call:keywordless-string-join-call after)
-    #:with refactored #'(join-call.original ... #:after-last after))
+  (pattern (string-append (join-call:keywordless-string-join-call) after)
+    #:with refactored #'((~@ . join-call) #:after-last after))
 
-  (pattern (string-append before join-call:keywordless-string-join-call after)
-    #:with refactored #'(join-call.original ... #:before-first before #:after-last after)))
+  (pattern (string-append before (join-call:keywordless-string-join-call) after)
+    #:with refactored #'((~@ . join-call) #:before-first before #:after-last after)))
 
 
 (define-refactoring-rule string-append-and-string-join-to-string-join