Complete refactoring rules for define-syntax-parse-rule

Co-authored-by: jackfirth <[email protected]>

Author: Copilot

default-recommendations/syntax-parse-shortcuts-test.rkt

@@ -49,6 +49,17 @@ test: "define-syntax with syntax-parse using stx name refactorable to define-syn
 ------------------------------
 
 
+no-change-test: "define-syntax with syntax-parse using custom name in directives not refactorable"
+------------------------------
+(define-syntax my-macro
+  (lambda (input-stx)
+    (syntax-parse input-stx
+      [(_ x:id)
+       #:with loc input-stx
+       #'(quote (x loc))])))
+------------------------------
+
+
 no-change-test: "define-syntax with syntax-parse and multiple clauses not refactorable"
 ------------------------------
 (define-syntax my-or

default-recommendations/syntax-parse-shortcuts.rkt

@@ -29,8 +29,23 @@ equivalent `define-syntax-parse-rule` macro."
       (syntax-parse-id:id parsed-stx:id
         [(_ . pattern) body ...])))
 
+  #:do [(define stx-id (attribute stx-var))
+        ;; Check if stx-var is referenced in the body
+        (define (has-stx-ref? stx)
+          (syntax-parse stx
+            [id:id
+             #:when (free-identifier=? #'id stx-id)
+             #t]
+            [(head . tail)
+             (or (has-stx-ref? #'head)
+                 (has-stx-ref? #'tail))]
+            [_ #f]))
+        (define body-has-stx-ref?
+          (ormap has-stx-ref? (attribute body)))]
+  
   #:when (and (free-identifier=? (attribute stx-var) (attribute parsed-stx))
-              (equal? (syntax-e (attribute syntax-parse-id)) 'syntax-parse))
+              (equal? (syntax-e (attribute syntax-parse-id)) 'syntax-parse)
+              (not body-has-stx-ref?))
 
   (define-syntax-parse-rule (macro . pattern) body ...))