Consolidate legacy migration rules into default-recommendations/legacy/ (#665)

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: jackfirth <[email protected]>

Author: Copilot

default-recommendations.rkt

@@ -18,9 +18,12 @@
                resyntax/default-recommendations/function-definition-shortcuts
                resyntax/default-recommendations/function-shortcuts
                resyntax/default-recommendations/hash-shortcuts
-               resyntax/default-recommendations/legacy-contract-migrations
-               resyntax/default-recommendations/legacy-struct-migrations
-               resyntax/default-recommendations/legacy-syntax-migrations
+               resyntax/default-recommendations/legacy/define-simple-macro-migration
+               resyntax/default-recommendations/legacy/legacy-contract-migrations
+               resyntax/default-recommendations/legacy/legacy-struct-migrations
+               resyntax/default-recommendations/legacy/legacy-syntax-migrations
+               resyntax/default-recommendations/legacy/make-temporary-directory-migration
+               resyntax/default-recommendations/legacy/provide-contract-migration
                resyntax/default-recommendations/let-binding-suggestions
                resyntax/default-recommendations/let-replacement/cond-let-replacement
                resyntax/default-recommendations/let-replacement/let-replacement
@@ -57,9 +60,12 @@
          resyntax/default-recommendations/function-definition-shortcuts
          resyntax/default-recommendations/function-shortcuts
          resyntax/default-recommendations/hash-shortcuts
-         resyntax/default-recommendations/legacy-contract-migrations
-         resyntax/default-recommendations/legacy-struct-migrations
-         resyntax/default-recommendations/legacy-syntax-migrations
+         resyntax/default-recommendations/legacy/define-simple-macro-migration
+         resyntax/default-recommendations/legacy/legacy-contract-migrations
+         resyntax/default-recommendations/legacy/legacy-struct-migrations
+         resyntax/default-recommendations/legacy/legacy-syntax-migrations
+         resyntax/default-recommendations/legacy/make-temporary-directory-migration
+         resyntax/default-recommendations/legacy/provide-contract-migration
          resyntax/default-recommendations/let-binding-suggestions
          resyntax/default-recommendations/let-replacement/cond-let-replacement
          resyntax/default-recommendations/let-replacement/let-replacement
@@ -91,6 +97,7 @@
             cond-let-replacement
             console-io-suggestions
             contract-shortcuts
+            define-simple-macro-migration
             definition-shortcuts
             dict-suggestions
             exception-suggestions
@@ -113,12 +120,14 @@
             let-replacement
             list-loopification
             list-shortcuts
+            make-temporary-directory-migration
             match-let-replacement
             match-shortcuts
             miscellaneous-suggestions
             mutability-predicates
             named-let-loopification
             numeric-shortcuts
+            provide-contract-migration
             require-and-provide-suggestions
             string-shortcuts
             syntax-shortcuts

default-recommendations/contract-shortcuts-test.rkt

@@ -93,23 +93,3 @@ test: "infix ->* contracts using #:rest (listof arg) can be replaced with -> and
 no-change-test:
 "->* contracts using #:rest and optional arguments not refactorable to -> and ellipses"
 - (void (->* () (string?) #:rest (listof symbol?) list?))
-
-
-test: "provide/contract refactorable to provide with contract-out"
-------------------------------
-(provide/contract [foo integer?])
-(define foo 42)
-==============================
-(provide (contract-out [foo integer?]))
-(define foo 42)
-------------------------------
-
-
-test: "provide/contract with unprotected submodule refactorable to provide with contract-out"
-------------------------------
-(provide/contract #:unprotected-submodule unsafe [foo integer?])
-(define foo 42)
-==============================
-(provide (contract-out #:unprotected-submodule unsafe [foo integer?]))
-(define foo 42)
-------------------------------

default-recommendations/contract-shortcuts.rkt

@@ -60,20 +60,8 @@
       result-contract))
 
 
-(define-splicing-syntax-class unprotected-submodule-option
-  (pattern (~optional (~seq #:unprotected-submodule submodule-name))))
-
-
-(define-refactoring-rule provide/contract-to-contract-out
-  #:description "The `provide/contract` form is a legacy form made obsolete by `contract-out`."
-  #:literals (provide/contract)
-  (provide/contract submod:unprotected-submodule-option item ...)
-  (provide (contract-out (~@ . submod) item ...)))
-
-
 (define-refactoring-suite contract-shortcuts
   #:rules (arrow-contract-with-rest-to-arrow-contract-with-ellipses
            explicit-path-string?-to-path-string?
            nested-or/c-to-flat-or/c
-           nested-and/c-to-flat-and/c
-           provide/contract-to-contract-out))
+           nested-and/c-to-flat-and/c))

default-recommendations/file-io-suggestions-test.rkt

@@ -11,22 +11,6 @@ header:
 ----------------------------------------
 
 
-test: "should migrate make-temporary-file with 'directory to make-temporary-directory"
-- (void (make-temporary-file #:copy-from 'directory))
-- (void (make-temporary-directory))
-
-
-test: "should migrate make-temporary-file with template and 'directory to make-temporary-directory"
-- (void (make-temporary-file "footmp~a" #:copy-from 'directory))
-- (void (make-temporary-file "footmp~a" 'directory))
-- (void (make-temporary-directory "footmp~a"))
-
-
-test: "should migrate make-temporary-file with base-dir and 'directory to make-temporary-directory"
-- (void (make-temporary-file #:base-dir #false #:copy-from 'directory))
-- (void (make-temporary-directory #:base-dir #false))
-
-
 no-change-test:
 "should not migrate make-temporary-file without 'directory to make-temporary-directory"
 - (make-temporary-file #:copy-from #false)

default-recommendations/file-io-suggestions.rkt

@@ -9,60 +9,12 @@
   [file-io-suggestions refactoring-suite?]))
 
 
-(require racket/file
-         racket/list
-         rebellion/private/static-name
-         resyntax/base
-         syntax/parse)
+(require rebellion/private/static-name
+         resyntax/base)
 
 
 ;@----------------------------------------------------------------------------------------------------
 
 
-(define-splicing-syntax-class function-call-argument
-  #:attributes (keyword expr)
-  (pattern (~seq expr:expr) #:attr keyword #false)
-  (pattern (~seq keyword:keyword expr:expr)))
-
-
-(define-splicing-syntax-class function-call-arguments
-  #:attributes ([positional 1] keyword)
-  (pattern (~seq arg:function-call-argument ...)
-    #:cut
-    #:with (positional ...)
-    (for/list ([expr (in-list (attribute arg.expr))]
-               [keyword (in-list (attribute arg.keyword))]
-               #:unless keyword)
-      expr)
-
-    #:attr keyword
-    (for/hasheq ([expr (in-list (attribute arg.expr))]
-                 [keyword (in-list (attribute arg.keyword))]
-                 #:when keyword)
-      (values (syntax-e keyword) expr))))
-
-
-(define-refactoring-rule make-temporary-directory-migration
-  #:description "Use `make-temporary-directory` to make directories instead of `make-temporary-file`."
-  #:literals (make-temporary-file)
-  #:datum-literals (quote directory)
-
-  (make-temporary-file args:function-call-arguments)
-  #:with 'directory
-  (or (and (>= (length (attribute args.positional)) 2)
-           (second (attribute args.positional)))
-      (hash-ref (attribute args.keyword) '#:copy-from #false))
-  #:cut
-  #:attr template-arg
-  (and (not (empty? (attribute args.positional)))
-       (first (attribute args.positional)))
-  #:attr base-dir-arg
-  (or (and (>= (length (attribute args.positional)) 3)
-           (third (attribute args.positional)))
-      (hash-ref (attribute args.keyword) '#:base-dir #false))
-
-  (make-temporary-directory (~? template-arg) (~? (~@ #:base-dir base-dir-arg))))
-
-
 (define-refactoring-suite file-io-suggestions
-  #:rules (make-temporary-directory-migration))
+  #:rules ())

…ndations/syntax-parse-shortcuts-test.rkt …y/define-simple-macro-migration-test.rktdefault-recommendations/syntax-parse-shortcuts-test.rkt renamed to default-recommendations/legacy/define-simple-macro-migration-test.rkt default-recommendations/syntax-parse-shortcuts-test.rkt renamed to default-recommendations/legacy/define-simple-macro-migration-test.rkt

@@ -1,7 +1,7 @@
 #lang resyntax/test
 
 
-require: resyntax/default-recommendations syntax-parse-shortcuts
+require: resyntax/default-recommendations define-simple-macro-migration
 
 
 header:

default-recommendations/legacy/define-simple-macro-migration.rkt

@@ -0,0 +1,50 @@
+#lang racket/base
+
+
+(require racket/contract/base)
+
+
+(provide
+ (contract-out
+  [define-simple-macro-migration refactoring-suite?]))
+
+
+(require resyntax/base
+         resyntax/default-recommendations/private/syntax-lines
+         syntax/parse/define)
+
+
+;@----------------------------------------------------------------------------------------------------
+
+
+(define define-simple-macro-migration-name-length-increase
+  (- (string-length "define-syntax-parse-rule") (string-length "define-simple-macro")))
+
+(define-refactoring-rule define-simple-macro-to-define-syntax-parse-rule
+  #:description "The `define-simple-macro` form has been renamed to `define-syntax-parse-rule`."
+  #:literals (define-simple-macro)
+  (original:define-simple-macro header form ...)
+
+  ;; The define-simple-macro is a renamed alias of define-syntax-parse-rule, so it's
+  ;; free-identifier=?. As a result, we need to check the actual symbol of the identifier instead of
+  ;; just its binding. See https://github.com/jackfirth/resyntax/issues/106.
+  #:when (equal? (syntax-e #'original) 'define-simple-macro)
+
+  #:do
+  [(define should-reformat?
+     (or (multiline-syntax? #'header)
+         (not (equal? (syntax-line #'original) (syntax-line #'header)))
+         (> (+ (syntax-column #'header)
+               (syntax-span #'header)
+               define-simple-macro-migration-name-length-increase)
+            102)))]
+
+  #:with new-id (if should-reformat?
+                    #'define-syntax-parse-rule
+                    #'(~focus-replacement-on define-syntax-parse-rule))
+   
+  (new-id header form ...))
+
+
+(define-refactoring-suite define-simple-macro-migration
+  #:rules (define-simple-macro-to-define-syntax-parse-rule))