Add more misbound suggestion logging (#494)

Author: jackfirth

main.rkt

@@ -281,12 +281,23 @@
             (refactoring-rule-refactor rule syntax (source-code-analysis-code analysis)))
           #:else absent)
         (guard (syntax-replacement-introduces-incorrect-bindings? replacement) #:else
+          (define bad-ids (syntax-replacement-introduced-incorrect-identifiers replacement))
+          (define orig-stx (syntax-replacement-original-syntax replacement))
+          (define intro (syntax-replacement-introduction-scope replacement))
           (log-resyntax-warning
            (string-append
             "~a: suggestion discarded because it introduces identifiers with incorrect bindings\n"
-            "  incorrect identifiers: ~a")
+            "  incorrect identifiers: ~a\n"
+            "  bindings in original context: ~a\n"
+            "  bindings in syntax replacement: ~a\n"
+            "  replaced syntax: ~a")
            (object-name rule)
-           (syntax-replacement-introduced-incorrect-identifiers replacement))
+           bad-ids
+           (for/list ([id (in-list bad-ids)])
+             (identifier-binding (datum->syntax orig-stx (syntax->datum id))))
+           (for/list ([id (in-list bad-ids)])
+             (identifier-binding (intro id 'remove)))
+           orig-stx)
           absent)
         (guard (syntax-replacement-preserves-comments? replacement comments) #:else
           (log-resyntax-warning

private/syntax-replacement.rkt

@@ -17,6 +17,8 @@
   [syntax-replacement-original-syntax (-> syntax-replacement? (and/c syntax? syntax-original?))]
   [syntax-replacement-new-syntax (-> syntax-replacement? syntax?)]
   [syntax-replacement-source (-> syntax-replacement? source?)]
+  [syntax-replacement-introduction-scope
+   (-> syntax-replacement? (->* (syntax?) ((or/c 'flip 'add 'remove)) syntax?))]
   [syntax-replacement-introduces-incorrect-bindings? (-> syntax-replacement? boolean?)]
   [syntax-replacement-introduced-incorrect-identifiers
    (-> syntax-replacement? (listof identifier?))]