Improve ignored-map-to-for-each (#548)

Closes #546.

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: jackfirth <[email protected]>

Author: jackfirth

default-recommendations/list-shortcuts-test.rkt

@@ -175,6 +175,18 @@ test: "used map expression not refactorable to for-each"
 ------------------------------
 
 
+test: "ignored map in begin0 refactorable to for-each"
+------------------------------
+(define (f xs)
+  (begin0 42
+    (map add1 xs)))
+==============================
+(define (f xs)
+  (begin0 42
+    (for-each add1 xs)))
+------------------------------
+
+
 test: "build-list with const refactorable to make-list"
 ------------------------------
 (require racket/function

default-recommendations/list-shortcuts.rkt

@@ -128,11 +128,13 @@
   (append arg ...))
 
 
-(define-definition-context-refactoring-rule ignored-map-to-for-each
-  #:description "The result of this `map` expression is unused. Consider using `for-each` instead."
+(define-refactoring-rule ignored-map-to-for-each
+  #:description
+  "The result of this `map` expression is unused. Make that explicit with `for-each` instead."
   #:literals (map)
-  (~seq body-before ... (~and map-expr (map proc list ...)) body-after ...+)
-  (body-before ... (~replacement (for-each proc list ...) #:original map-expr) body-after ...))
+  (map proc list ...)
+  #:when (equal? (syntax-property this-syntax 'expression-result) 'ignored)
+  (for-each proc list ...))
 
 
 (define-refactoring-rule build-list-const-to-make-list