Commit c0f08ae
authored
Fix Bugs Measuring Performance Track for Effects (facebook#32815)
This fixes two bugs with commit phase effect tracking.
I missed, or messed up the rebase for, deletion effects when a subtree
was deleted and for passive disconnects when a subtree was hidden.
The other bug is that when I started using self time
(componentEffectDuration) for color and for determining whether to
bother logging an entry, I didn't consider that the component with
effects can have children which end up resetting this duration before we
log. Which lead to most effects not having their components logged since
they almost always have children.
We don't necessarily have to push/pop but we have to store at least one
thing on the stack unfortunately. That's because we have to do the
actual log after the children to get the right end time. So might as
well use the push/pop strategy like the rest of them.1 parent b10cb4c commit c0f08ae
File tree
2 files changed
+138
-38
lines changed- packages/react-reconciler/src
2 files changed
+138
-38
lines changed
0 commit comments