Add Hindley-Milner type inference for recursive functions#15
Open
jacobaustin123 wants to merge 2 commits intomasterfrom
Open
Add Hindley-Milner type inference for recursive functions#15jacobaustin123 wants to merge 2 commits intomasterfrom
jacobaustin123 wants to merge 2 commits intomasterfrom
Conversation
fa85e45 to
0b8091e
Compare
0b8091e to
782be33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements Hindley-Milner type inference for Coral, enabling the compiler to correctly infer types for recursive functions.
Before this change:
dyntypefactorial(n)andfibonacci(n)would be typed asdyneven though they clearly return integersAfter this change:
factorial(5)is now typed asintinstead ofdynChanges
src/infer.ml(new): Core HM inference module with type variables, substitution, and unificationsrc/ast.ml: AddedTVar of intto the type system for type variablessrc/semant.ml: Updated recursive call handling to use type variables and unification for branch reconciliationsrc/utilities.ml: Added TVar support and substitution field to inference statetests/hm-test-*.cl: New test cases for recursive type inferenceType Inference Results
factorial(n)dynint✓fibonacci(n)dynint✓sum_to_n(n)dynint✓power(x, n)dynint✓gcd(a, b)dynint✓Test plan
Dynstill works as the dynamic type escape hatch🤖 Generated with Claude Code