Skip to content
This repository was archived by the owner on Jul 3, 2019. It is now read-only.

Conversation

@ydaniv
Copy link

@ydaniv ydaniv commented Sep 28, 2016

No description provided.

@alexdutton
Copy link

django-fsm transition methods aren't necessarily designed to be called from a request, so I'm not sure this is a good idea. My pull in #10 would let you provide a method on the viewset to construct the arguments that are to be passed to the transition method.

@ydaniv
Copy link
Author

ydaniv commented Oct 25, 2016

This is not django-fsm, this is drf-fsm-transitions, and DRF stands for the API part. So what can I do with an API endpoint if I can't get the request?!?

@alexdutton
Copy link

Because you don't always want to trigger a transition from a request (e.g. maybe from a celerybeat task), and you should be explicit about the bits of the request you want to use (easier to understand what it's doing, easier to test, can't start requiring other bits of the request without being explicit about it).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants