zonedatetime

Author: jacopocarlini

README.md

@@ -94,8 +94,8 @@ If the current time is outside the time window the flag will always be disabled.
 ``` java
 Flag.builder()
     ...
-    .timeWindowStart(LocalDateTime.of(2025, 1, 1, 0, 0))
-    .timeWindowEnd(LocalDateTime.of(2026, 1, 2, 0, 0))
+    .timeWindowStart(ZonedDateTime.of(2025, 1, 1, 0, 0))
+    .timeWindowEnd(ZonedDateTime.of(2026, 1, 2, 0, 0))
     .build();
 ```
 

example/ExampleUsage.java

@@ -28,8 +28,8 @@ public static void main(String[] args) {
                     put("big", "18");
                   }
                 })
-            //            .timeWindowStart(LocalDateTime.of(2025, 1, 1, 0, 0))
-            //            .timeWindowEnd(LocalDateTime.of(2026, 1, 2, 0, 0))
+//                        .timeWindowStart(ZonedDateTime.of(2025, 1, 1, 0, 0))
+            //            .timeWindowEnd(ZonedDateTime.of(2026, 1, 2, 0, 0))
             //            .target(
             //                Collections.singletonList(
             //                    Target.builder().filter(".*@email.it").variant("big").build()))

src/main/java/com/github/jacopocarlini/fffp/entity/Flag.java

@@ -1,6 +1,6 @@
 package com.github.jacopocarlini.fffp.entity;
 
-import java.time.LocalDateTime;
+import java.time.ZonedDateTime;
 import java.util.List;
 import java.util.Map;
 
@@ -25,18 +25,17 @@ public class Flag {
   @NotBlank
   private String flagKey;
 
-  @NotNull
-  private Boolean enabled;
+  @NotNull private Boolean enabled;
 
   @Size(min = 1)
   private Map<String, Object> variants;
-  @NotBlank
-  private String defaultVariant;
+
+  @NotBlank private String defaultVariant;
 
   private List<Target> target;
 
   private Map<String, Integer> rolloutPercentage;
 
-  private LocalDateTime timeWindowStart;
-  private LocalDateTime timeWindowEnd;
+  private ZonedDateTime timeWindowStart;
+  private ZonedDateTime timeWindowEnd;
 }

src/main/java/com/github/jacopocarlini/fffp/util/ProviderUtility.java

@@ -7,7 +7,7 @@
 import com.github.jacopocarlini.fffp.exceptions.InvalidFeatureFlagException;
 import dev.openfeature.sdk.EvaluationContext;
 import dev.openfeature.sdk.ProviderEvaluation;
-import java.time.LocalDateTime;
+import java.time.ZonedDateTime;
 import java.util.Map;
 import java.util.Optional;
 import java.util.Random;
@@ -47,7 +47,7 @@ public static boolean isOutsideTimeWindow(Flag flag) {
       return false;
     }
 
-    LocalDateTime now = LocalDateTime.now();
+    ZonedDateTime now = ZonedDateTime.now();
     return now.isBefore(flag.getTimeWindowStart()) || now.isAfter(flag.getTimeWindowEnd());
   }