Merge pull request #1 from jacoyutorius/v2

いくつか気になった箇所を改修

Author: jacoyutorius

Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    passfaker (0.1.0)
+    passfaker (0.2.0)
       faker (~> 2.0)
 
 GEM

lib/passfaker/generator.rb

@@ -12,17 +12,30 @@ module Generator
       -> { Faker::Creature::Animal.name },
       -> { Faker::Food.ingredient },
       -> { Faker::Games::Pokemon.name },
-      -> { Faker::Music.instrument }
+      -> { Faker::Music.instrument },
+      -> { Faker::Superhero.name },
+      -> { Faker::Music.genre }
     ].freeze
 
     def self.generate(word_count:, separator:, include_number:)
       words = word_count.times.map do
         generator = CATEGORIES[SecureRandom.random_number(CATEGORIES.size)]
-        generator.call.downcase.gsub(/\s+/, "-")
+        word = generator.call.downcase.gsub(/\s+/, "")
+        random_char_upcase(word)
       end
 
       words << ::SecureRandom.random_number(100).to_s if include_number
-      words.join(separator)
+      words.shuffle.join(separator)
+    end
+
+    # ランダムな文字を大文字に変換する
+    def self.random_char_upcase(word)
+      return word if word.empty?
+
+      chars = word.chars
+      index = SecureRandom.random_number(chars.size)
+      chars[index] = chars[index].upcase
+      chars.join
     end
   end
 end

lib/passfaker/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Passfaker
-  VERSION = "0.1.0"
+  VERSION = "0.2.0"
 end

spec/passfaker_spec.rb

@@ -20,7 +20,7 @@
 
     it "includes a number when include_number is true" do
       password = Passfaker.generate(include_number: true)
-      expect(password).to match(/\d+$/)
+      expect(password).to match(/\d+/)
     end
   end
 end