Proper closing of TCP client connections.

mschriscooper · mschriscooper · commit 5b6dad097c7e · 2019-07-09T14:57:04.000-07:00
Fixes socket closing behavior to be proper FIN-ACK=&gt;FIN-ACK instead of FIN-ACK=&gt;RST,ACK.  Restores system resources quicker.
diff --git a/src/JKang.IpcServiceFramework.Server/Tcp/TcpIpcServiceEndpoint.cs b/src/JKang.IpcServiceFramework.Server/Tcp/TcpIpcServiceEndpoint.cs
@@ -135,6 +135,7 @@ public TcpIpcServiceEndpoint(String name, IServiceProvider serviceProvider, IPAd
                         if (_throttle == null)
                         {
                             await ProcessAsync(server, _logger, cancellationToken);
+                            client.Close();
                         }
                         else
                         {
@@ -144,6 +145,7 @@ public TcpIpcServiceEndpoint(String name, IServiceProvider serviceProvider, IPAd
                                     try
                                     {
                                         await ProcessAsync(server, _logger, cancellationToken).ConfigureAwait(false);
+                                        client.Close();
                                     }
                                     catch when (cancellationToken.IsCancellationRequested) { }
                                     finally

Original file line number	Diff line number	Diff line change
`@@ -135,6 +135,7 @@ public TcpIpcServiceEndpoint(String name, IServiceProvider serviceProvider, IPAd`
`135`	`135`	`if (_throttle == null)`
`136`	`136`	`{`
`137`	`137`	`await ProcessAsync(server, _logger, cancellationToken);`
	`138`	`+ client.Close();`
`138`	`139`	`}`
`139`	`140`	`else`
`140`	`141`	`{`
`@@ -144,6 +145,7 @@ public TcpIpcServiceEndpoint(String name, IServiceProvider serviceProvider, IPAd`
`144`	`145`	`try`
`145`	`146`	`{`
`146`	`147`	`await ProcessAsync(server, _logger, cancellationToken).ConfigureAwait(false);`
	`148`	`+ client.Close();`
`147`	`149`	`}`
`148`	`150`	`catch when (cancellationToken.IsCancellationRequested) { }`
`149`	`151`	`finally`