Merge pull request #38 from jacqueskang/missing-dependencies

jacqueskang · web-flow · commit a6e900c4d5a3 · 2018-11-14T14:16:05.000+01:00
bugfix: ILogger&lt;&gt; dependency missing without explicitly add logging
diff --git a/src/JKang.IpcServiceFramework.Server/IpcServiceServiceCollectionExtensions.cs b/src/JKang.IpcServiceFramework.Server/IpcServiceServiceCollectionExtensions.cs
@@ -8,6 +8,7 @@ public static class IpcServiceServiceCollectionExtensions
         public static IIpcServiceBuilder AddIpc(this IServiceCollection services)
         {
             services
+                .AddLogging()
                 .AddScoped<IValueConverter, DefaultValueConverter>()
                 .AddScoped<IIpcMessageSerializer, DefaultIpcMessageSerializer>();
 
diff --git a/src/JKang.IpcServiceFramework.Server/JKang.IpcServiceFramework.Server.csproj b/src/JKang.IpcServiceFramework.Server/JKang.IpcServiceFramework.Server.csproj
@@ -8,7 +8,7 @@
 
   <ItemGroup>
     <PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="2.0.0" />
-    <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="2.0.0" />
+    <PackageReference Include="Microsoft.Extensions.Logging" Version="2.0.0" />
   </ItemGroup>
 
   <ItemGroup>

Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,7 @@ public static class IpcServiceServiceCollectionExtensions`
`8`	`8`	`public static IIpcServiceBuilder AddIpc(this IServiceCollection services)`
`9`	`9`	`{`
`10`	`10`	`services`
	`11`	`+ .AddLogging()`
`11`	`12`	`.AddScoped<IValueConverter, DefaultValueConverter>()`
`12`	`13`	`.AddScoped<IIpcMessageSerializer, DefaultIpcMessageSerializer>();`
`13`	`14`