Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

Commit 93d7ae1

Browse files
authored
Merge pull request #51 from jaebradley/linting
Add Linting
2 parents 38f1508 + 95da04c commit 93d7ae1

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

58 files changed

+493
-716
lines changed

.eslintrc.json

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
{
2+
"extends": "airbnb-base",
3+
"plugins": [
4+
"import",
5+
"chai-expect"
6+
],
7+
"rules": {
8+
"class-methods-use-this": "off"
9+
}
10+
}

.travis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@ node_js:
33
- 4.2.2
44
sudo: false
55
script:
6-
- npm run coveralls
6+
- npm run build

package.json

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,13 @@
3131
"chai-as-promised": "^6.0.0",
3232
"chai-immutable": "^1.6.0",
3333
"coveralls": "^2.11.9",
34+
"eslint": "^3.19.0",
35+
"eslint-config-airbnb-base": "^11.2.0",
36+
"eslint-plugin-chai-expect": "^1.1.1",
37+
"eslint-plugin-import": "^2.3.0",
38+
"eslint-plugin-mocha": "^4.10.1",
3439
"istanbul": "^1.0.0-alpha.2",
35-
"mocha": "^2.4.5",
40+
"mocha": "^2.5.3",
3641
"mocha-lcov-reporter": "^1.2.0 ",
3742
"sinon": "^2.1.0",
3843
"sinon-chai": "^2.9.0"
@@ -57,6 +62,8 @@
5762
"coverage": "babel-node ./node_modules/istanbul/lib/cli cover node_modules/mocha/bin/_mocha test -- --recursive --compilers js:babel-core/register",
5863
"coveralls": "npm run compile && npm run coverage && node_modules/.bin/coveralls < coverage/lcov.info",
5964
"prepublish": "npm run compile",
60-
"test": "npm run compile && mocha --compilers js:babel-core/register"
65+
"lint": "eslint src && eslint test",
66+
"test": "npm run compile && mocha --recursive --compilers js:babel-core/register",
67+
"build": "npm run lint && npm run coveralls"
6168
}
6269
}

src/Utilities.js

Lines changed: 0 additions & 46 deletions
This file was deleted.

src/data/Coordinate.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
1-
'use es6';
1+
import { Record } from 'immutable';
22

3-
import {Record} from 'immutable';
4-
5-
let defaults = {
3+
const defaults = {
64
latitude: 0,
75
longitude: 0,
86
};

src/data/Distance.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,10 @@
1-
'use es6';
2-
31
import { Record } from 'immutable';
42

53
import DistanceUnit from './DistanceUnit';
64

75
const defaults = {
86
value: 0,
9-
unit: DistanceUnit.MILE
7+
unit: DistanceUnit.MILE,
108
};
119

1210
export default class Distance extends Record(defaults) {}

src/data/DistanceUnit.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
'use es6';
2-
31
import { Enum } from 'enumify';
42

53
export default class DistanceUnit extends Enum {}

src/data/Duration.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,10 @@
1-
'use es6';
2-
31
import { Record } from 'immutable';
42

53
import TimeUnit from './TimeUnit';
64

75
const defaults = {
86
length: 0,
9-
unit: TimeUnit.SECOND
7+
unit: TimeUnit.SECOND,
108
};
119

1210
export default class Duration extends Record(defaults) {

src/data/Location.js

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,11 @@
1-
'use es6';
2-
3-
import {Record} from 'immutable';
1+
import { Record } from 'immutable';
42

53
import Coordinate from './Coordinate';
64

7-
let defaults = {
5+
const defaults = {
86
name: '',
97
coordinate: new Coordinate(),
10-
}
8+
};
119

1210
export default class Location extends Record(defaults) {
1311
}

src/data/PickupTimeEstimate.js

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,10 @@
1-
'use es6';
2-
31
import { Record } from 'immutable';
2+
43
import Duration from './Duration';
54

6-
let defaults = {
5+
const defaults = {
76
productName: '',
87
estimatedDuration: new Duration(),
98
};
109

11-
export default class PickupTimeEstimate extends Record(defaults){
12-
};
10+
export default class PickupTimeEstimate extends Record(defaults) {}

0 commit comments

Comments
 (0)