Skip to content
This repository was archived by the owner on Aug 30, 2022. It is now read-only.

Commit 1e13e4d

Browse files
isaachieryurishkuro
authored andcommitted
CMake build fixes (#25)
* Bump CMake to version 3.3 for IWYU support * Have Travis download recent CMake
1 parent 65436b5 commit 1e13e4d

File tree

3 files changed

+12
-6
lines changed

3 files changed

+12
-6
lines changed

.travis.yml

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,14 @@ branches:
2727
only:
2828
- master
2929
before_install:
30-
- eval "${MATRIX_EVAL}"
30+
- eval "${MATRIX_EVAL}"
31+
- mkdir cmake-download &&
32+
cd cmake-download &&
33+
curl -O https://cmake.org/files/v3.10/cmake-3.10.0-rc5-Linux-x86_64.sh &&
34+
bash cmake-3.10.0-rc5-Linux-x86_64.sh --skip-license &&
35+
cd ..
3136
script:
32-
- ./scripts/build.sh
37+
- ./scripts/build.sh
3338
after_success:
3439
- for f in $(find build -name '*.gcno'); do gcov-6 $f; done
3540
- bash <(curl -s https://codecov.io/bash) || echo "Codecov did not collect coverage
@@ -45,4 +50,5 @@ after_script: |
4550
env:
4651
global:
4752
- LANG="en_US.UTF-8"
53+
- PATH="$TRAVIS_BUILD_DIR/cmake-download/bin:$PATH"
4854
- secure: 1Pz1mI4PZdzFf2M33snYoaYu/gWxRGK22rw5h9DYtAMFyrqcTKJOI0WnXsIHxjZ5obqVLL/MaNTnO6PbO+sKGEueqNibZhYfjUbZtAV94/uXNkc6Qn6lNALJykqAueGXIkf04CLGpQaJoS8OebFdZODZMJzad58BpckJlF9O/v2OXNx244/bl4Eu61qvbLa/IgRUnLRwGUiHY4CN7Q8+6kNn2cu0nNb2bc+S01jB9PjC+lrkP39ant9f1fY3qWkN3blhLH7OsMaQ9tgs0c/fwCRpyNl95LYodL3Zzi/F61G0PPJL/B2jCGYwFPMsjIj+O6PwF+8k9iAnmA/hUdIQ7+a2l+/Pe9HrPstJD4V99Q922INBYLvgIkvCh7HIV9NDfJ3Ok8tA9PvvGXJ4y12aWvP6QYEfdDFcX6Yrc3NraVMMsz+UhkznHiLdTrj5UwFlmro4a0iRzKeEAOfBmb/pgeD8eESR2IGaZiFsGcLQ0RHFb477fiMJzCstLm/gfhlO6pOvbTMKItEswqePoJI9g0AxQT2Ib8F58Hp91G3U7kbtubZGIT4OZAv6ePj0WnL4FojFWM8TirmPkbVeKwBggxuI85BQO2XE8HhdJPZSz+vzUPPHZbspPdqMaEbk5WgnHv10TmL83VKof48sA4GxfDuXm+NlTan4sWgdPNKpSow=

CMakeLists.txt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
cmake_minimum_required(VERSION 3.1)
1+
cmake_minimum_required(VERSION 3.3)
22

33
set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} "${CMAKE_SOURCE_DIR}/cmake")
44

@@ -248,6 +248,7 @@ set(SRC
248248
src/jaegertracing/utils/ErrorUtil.cpp
249249
src/jaegertracing/utils/HexParsing.cpp
250250
src/jaegertracing/utils/RateLimiter.cpp
251+
src/jaegertracing/utils/Regex.cpp
251252
src/jaegertracing/utils/UDPClient.cpp
252253
src/jaegertracing/utils/YAML.cpp)
253254

@@ -305,7 +306,7 @@ if(BUILD_TESTING)
305306
src/jaegertracing/utils/UDPClientTest.cpp)
306307
add_executable(UnitTest ${TEST_SRC})
307308
target_compile_definitions(UnitTest PUBLIC
308-
GTEST_HAS_TR1_TUPLE=0
309+
GTEST_HAS_TR1_TUPLE=1
309310
GTEST_USE_OWN_TR1_TUPLE=0)
310311
target_link_libraries(
311312
UnitTest testutils GTest::main jaegertracing-static ${LIBS})

crossdock/Dockerfile

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
FROM gcc:7.2
22

33
WORKDIR /
4-
RUN curl -O https://cmake.org/files/v3.10/cmake-3.10.0-rc5-Linux-x86_64.sh && \
5-
bash cmake-3.10.0-rc5-Linux-x86_64.sh --skip-license
4+
RUN curl -O https://cmake.org/files/v3.10/cmake-3.10.0-rc5-Linux-x86_64.sh && bash cmake-3.10.0-rc5-Linux-x86_64.sh --skip-license
65

76
COPY . /app/jaegertracing
87
RUN rm -rf /app/jaegertracing/build && \

0 commit comments

Comments
 (0)