Fix -Werror=sign-compare warning (#106)

vadorovsky · isaachier · commit 29e04bec834f · 2018-05-23T12:10:23.000-04:00
Cast the numWritten variable to unsigned type - we expect it to be
positive.

Signed-off-by: Michal Rostecki &lt;mrostecki@suse.com&gt;
diff --git a/src/jaegertracing/utils/UDPClient.h b/src/jaegertracing/utils/UDPClient.h
@@ -60,7 +60,7 @@ class UDPClient : public agent::thrift::AgentIf {
             throw std::logic_error(oss.str());
         }
         const auto numWritten = ::write(_socket.handle(), data, size);
-        if (numWritten != size) {
+        if (static_cast<unsigned>(numWritten) != size) {
             std::ostringstream oss;
             oss << "Failed to write message"
                    ", numWritten="

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ class UDPClient : public agent::thrift::AgentIf {`
`60`	`60`	`throw std::logic_error(oss.str());`
`61`	`61`	`}`
`62`	`62`	`const auto numWritten = ::write(_socket.handle(), data, size);`
`63`		`- if (numWritten != size) {`
	`63`	`+ if (static_cast<unsigned>(numWritten) != size) {`
`64`	`64`	`std::ostringstream oss;`
`65`	`65`	`oss << "Failed to write message"`
`66`	`66`	`", numWritten="`