Skip to content
This repository was archived by the owner on Aug 30, 2022. It is now read-only.

Commit b749aed

Browse files
HugoMFernandesisaachier
authored andcommitted
Fix tracer.Inject(..., HTTPHeadersWriter&) (#107) (#108)
tracer.Inject(SpanContext&, HTTPHeadersWriter&) was using the underlying TextMapPropagator (instead of HTTPHeaderPropagator). This caused injected baggage values not to be encoded. Signed-off-by: Hugo Fernandes <[email protected]>
1 parent a758f0c commit b749aed

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/jaegertracing/Tracer.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ class Tracer : public opentracing::Tracer,
148148
return opentracing::make_expected_from_error<void>(
149149
opentracing::invalid_span_context_error);
150150
}
151-
_textPropagator.inject(*jaegerCtx, writer);
151+
_httpHeaderPropagator.inject(*jaegerCtx, writer);
152152
return opentracing::make_expected();
153153
}
154154

src/jaegertracing/TracerTest.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -327,7 +327,7 @@ TEST(Tracer, testPropagation)
327327
std::ostringstream oss;
328328
oss << span->context();
329329
ASSERT_EQ(oss.str(), headerMap.at(kTraceContextHeaderName));
330-
ASSERT_EQ("test baggage item value",
330+
ASSERT_EQ("test%20baggage%20item%20value",
331331
headerMap.at(std::string(kTraceBaggageHeaderPrefix) +
332332
"test-baggage-item-key"));
333333
ReaderMock<opentracing::HTTPHeadersReader> headerReader(headerMap);

0 commit comments

Comments
 (0)