Skip to content
This repository was archived by the owner on Jul 1, 2022. It is now read-only.

Commit 1430154

Browse files
ehsavoieyurishkuro
authored andcommitted
[ISSUE-669]: Update libthrift to 0.13.0 (#672)
Resolves #669 * Update libthrift to 0.13.0 * Fix code accordingly Issue: #669 Signed-off-by: Emmanuel Hugonnet <[email protected]>
1 parent 46798bd commit 1430154

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ plugins {
1919

2020
ext.opentracingVersion = getProperty('opentracingVersion','0.33.0')
2121
ext.guavaVersion = getProperty('guavaVersion','18.0')
22-
ext.apacheThriftVersion = getProperty('apacheThriftVersion','0.12.0')
22+
ext.apacheThriftVersion = getProperty('apacheThriftVersion','0.13.0')
2323
ext.jerseyVersion = getProperty('jerseyVersion','2.22.2')
2424
ext.slf4jVersion = getProperty('slf4jVersion','1.7.28')
2525
ext.gsonVersion = getProperty('gsonVersion','2.8.6')

jaeger-thrift/src/main/java/io/jaegertracing/thrift/internal/senders/ThriftSenderBase.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ protected byte[] serialize(TBase<?,?> thriftBase) throws Exception {
7979
public int getSize(TBase<?,?> thriftBase) throws Exception {
8080
memoryTransport.reset();
8181
thriftBase.write(protocolFactory.getProtocol(memoryTransport));
82-
return memoryTransport.getPos();
82+
return memoryTransport.getLength();
8383
}
8484

8585
}

jaeger-thrift/src/test/java/io/jaegertracing/thrift/internal/reporters/protocols/ThriftSenderBaseTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,13 +55,13 @@ private int calculateBatchOverheadDifference(int numberOfSpans) throws Exception
5555
}
5656

5757
memoryClient.emitBatch(new Batch(new io.jaegertracing.thriftjava.Process(SERVICE_NAME), spans));
58-
int emitBatchOverheadMultipleSpans = memoryTransport.getPos();
58+
int emitBatchOverheadMultipleSpans = memoryTransport.getLength();
5959

6060
memoryTransport.reset();
6161
for (int j = 0; j < numberOfSpans; j++) {
6262
span.write(new TCompactProtocol(memoryTransport));
6363
}
64-
int writeBatchOverheadMultipleSpans = memoryTransport.getPos();
64+
int writeBatchOverheadMultipleSpans = memoryTransport.getLength();
6565

6666
return emitBatchOverheadMultipleSpans - writeBatchOverheadMultipleSpans;
6767
}

0 commit comments

Comments
 (0)