Improve RemoteReporter code coverage (#380) (#692)

Signed-off-by: adnan <[email protected]>

Author: adnxn

jaeger-core/src/test/java/io/jaegertracing/internal/reporters/RemoteReporterTest.java

@@ -368,6 +368,31 @@ public int append(JaegerSpan span) {
     assertEquals(0, metricsFactory.getCounter("jaeger_tracer_reporter_spans", "result=dropped"));
   }
 
+  @Test
+  public void testUpdateErrorMetricWhenCommandExecuteFails() throws Exception {
+
+    int reporterFailures = 5;
+
+    sender = new InMemorySender() {
+      @Override
+      public int append(JaegerSpan span) throws SenderException {
+        throw new SenderException("", reporterFailures);
+      }
+    };
+
+    RemoteReporter reporter = new Builder()
+            .withSender(sender)
+            .withFlushInterval(flushInterval)
+            .withMaxQueueSize(maxQueueSize)
+            .withMetrics(metrics)
+            .build();
+
+    reporter.report(newSpan());
+    reporter.close();
+
+    assertEquals(reporterFailures, metricsFactory.getCounter("jaeger_tracer_reporter_spans", "result=err"));
+  }
+
   private JaegerSpan newSpan() {
     return tracer.buildSpan("x").start();
   }

jaeger-core/src/test/java/io/jaegertracing/internal/senders/InMemorySender.java

@@ -51,7 +51,7 @@ public List<JaegerSpan> getReceived() {
   }
 
   @Override
-  public int append(JaegerSpan span) {
+  public int append(JaegerSpan span) throws SenderException {
     try {
       semaphore.acquire();
     } catch (InterruptedException e) {