Add IP tag to tracer tags (#160)

Author: black-adder

jaeger_client/constants.py

@@ -45,7 +45,10 @@
 JAEGER_VERSION_TAG_KEY = 'jaeger.version'
 
 # Tracer-scoped tag that contains the hostname
-JAEGER_HOSTNAME_TAG_KEY = 'jaeger.hostname'
+JAEGER_HOSTNAME_TAG_KEY = 'hostname'
+
+# Tracer-scoped tag that is used to report ip of the process.
+JAEGER_IP_TAG_KEY = 'ip'
 
 # the type of sampler that always makes the same decision.
 SAMPLER_TYPE_CONST = 'const'

jaeger_client/tracer.py

@@ -80,6 +80,7 @@ def __init__(
             self.codecs.update(extra_codecs)
         self.tags = {
             constants.JAEGER_VERSION_TAG_KEY: constants.JAEGER_CLIENT_VERSION,
+            constants.JAEGER_IP_TAG_KEY: self.ip_address,
         }
         if tags:
             self.tags.update(tags)

tests/test_tracer.py

@@ -169,13 +169,15 @@ def test_serialization_error(tracer):
         )
 
 
-def test_tracer_tags_hostname():
+def test_tracer_tags():
     reporter = mock.MagicMock()
     sampler = ConstSampler(True)
 
     with mock.patch('socket.gethostname', return_value='dream-host.com'):
         t = Tracer(service_name='x', reporter=reporter, sampler=sampler)
-        assert t.tags.get(c.JAEGER_HOSTNAME_TAG_KEY) == 'dream-host.com'
+        assert t.tags.get('hostname') == 'dream-host.com'
+        assert 'ip' in t.tags
+        assert 'jaeger.version' in t.tags
 
 
 def test_tracer_tags_passed_to_reporter():