[test] Upgrade integration tests fixtures to OTLP traces#8079
[test] Upgrade integration tests fixtures to OTLP traces#8079Manik2708 wants to merge 3 commits intojaegertracing:mainfrom
Conversation
…l_trace.json Signed-off-by: Manik Mehta <mehtamanik96@gmail.com>
|
The script used here is (AI generated): |
There was a problem hiding this comment.
Pull request overview
This pull request converts integration test trace fixtures from the v1 Jaeger model format to the OTLP (OpenTelemetry Protocol) format. This is part of the larger effort tracked in issue #7050 to upgrade the e2e storage tests to use the v2 Storage API and OTLP data model. The conversion enables better testing of OTLP-specific features such as scope attributes that are not adequately represented in the v1 model.
Changes:
- Converted 28 trace fixture JSON files from v1 model format (with
spans,process,tags,logs,references) to OTLP format (withresourceSpans,scopeSpans,attributes,events,links) - Added trace sorting calls in the trace-converter validation function to ensure deterministic comparison when converting between formats
Reviewed changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| internal/storage/integration/fixtures/traces/tags_wildcard_regex_2.json | Converted to OTLP format with resource attributes for service.name and span attributes |
| internal/storage/integration/fixtures/traces/tags_wildcard_regex_1.json | Converted to OTLP format with resource attributes for service.name and span attributes |
| internal/storage/integration/fixtures/traces/tags_opname_trace.json | Converted to OTLP format including transformation of references to links with opentracing.ref_type attributes |
| internal/storage/integration/fixtures/traces/tags_opname_maxdur_trace.json | Converted to OTLP format with process tags moved to resource attributes and logs to events |
| internal/storage/integration/fixtures/traces/tags_opname_dur_trace.json | Converted to OTLP format with logs transformed to span events |
| internal/storage/integration/fixtures/traces/tags_maxdur_trace.json | Converted to OTLP format with process tags moved to resource attributes |
| internal/storage/integration/fixtures/traces/tags_escaped_operator_trace_2.json | Converted to OTLP format with span attributes and events |
| internal/storage/integration/fixtures/traces/tags_escaped_operator_trace_1.json | Converted to OTLP format with span attributes and events |
| internal/storage/integration/fixtures/traces/tags_dur_trace.json | Converted to OTLP format with span attributes |
| internal/storage/integration/fixtures/traces/process_tags_trace.json | Converted to OTLP format with process tags moved to resource attributes |
| internal/storage/integration/fixtures/traces/opname_trace.json | Converted to OTLP format with operation name as span name |
| internal/storage/integration/fixtures/traces/opname_maxdur_trace.json | Converted to OTLP format with parent-child span relationships using parentSpanId |
| internal/storage/integration/fixtures/traces/opname_dur_trace.json | Converted to OTLP format with span name and events |
| internal/storage/integration/fixtures/traces/multispottag_opname_trace.json | Converted to OTLP format with tags distributed across resource, span attributes, and event attributes |
| internal/storage/integration/fixtures/traces/multispottag_opname_maxdur_trace.json | Converted to OTLP format with multi-location tag placement |
| internal/storage/integration/fixtures/traces/multispottag_opname_dur_trace.json | Converted to OTLP format with multi-location tag placement |
| internal/storage/integration/fixtures/traces/multispottag_maxdur_trace.json | Converted to OTLP format with multi-location tag placement |
| internal/storage/integration/fixtures/traces/multispottag_dur_trace.json | Converted to OTLP format with multi-location tag placement |
| internal/storage/integration/fixtures/traces/multiple3_trace.json | Converted to OTLP format with basic span structure |
| internal/storage/integration/fixtures/traces/multiple2_trace.json | Converted to OTLP format with basic span structure |
| internal/storage/integration/fixtures/traces/multiple1_trace.json | Converted to OTLP format with basic span structure |
| internal/storage/integration/fixtures/traces/multi_spot_tags_trace.json | Converted to OTLP format with tags in multiple locations |
| internal/storage/integration/fixtures/traces/multi_index_trace.json | Converted to OTLP format with multiple spans and different timestamps |
| internal/storage/integration/fixtures/traces/max_dur_trace.json | Converted to OTLP format with duration-based span |
| internal/storage/integration/fixtures/traces/log_tags_trace.json | Converted to OTLP format with log tags transformed to event attributes |
| internal/storage/integration/fixtures/traces/example_trace.json | Converted to OTLP format with multiple resources, spans, and span kinds |
| internal/storage/integration/fixtures/traces/dur_trace.json | Converted to OTLP format with duration-based span |
| cmd/trace-converter/main.go | Added model.SortTrace() calls to ensure deterministic trace ordering before comparison |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8079 +/- ##
==========================================
- Coverage 95.50% 95.48% -0.02%
==========================================
Files 316 316
Lines 16735 16735
==========================================
- Hits 15982 15980 -2
- Misses 588 590 +2
Partials 165 165
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
make lint testAI Usage in this PR (choose one)
See AI Usage Policy.